Re: [PATCH 4/4] module: Use the binary search for symbols resolution

2011-4-19 9:37, Rusty Russell wroted: On Sat, 16 Apr 2011 22:32:08 +0800, Wanlong Gao wrote: + sym = bsearch(fsa->name, syms->start, syms->stop - syms->start, As the bsearch func, why not change the syms->stop to syms->end ? Hmm..Just a stupid suggestion. The names are derived from t

Re: [PATCH 4/4] module: Use the binary search for symbols resolution

On Sat, 16 Apr 2011 22:32:08 +0800, Wanlong Gao wrote: > > + sym = bsearch(fsa->name, syms->start, syms->stop - syms->start, > As the bsearch func, why not change the syms->stop to syms->end ? > Hmm..Just a stupid suggestion. The names are derived from the linker symbols for end of sections, w

Re: [PATCH 1/4] module: Restructure each_symbol() code

On Sat, 16 Apr 2011 15:26:10 +0200, Alessio Igor Bogani wrote: > Restructure code to better integrate future improvements. I like all the rest, but I find the function names here a bit confusing. How about using this (untested!) patch instead? Thanks! Rusty. --- Subject: module: each_symbol_se

Re: [PATCH] extra/1 Allow setting the maximum KBUS message size

On Fri, Apr 15, 2011 at 04:46:08PM -0600, Jonathan Corbet wrote: > That means getting more people to look at the patch, which could be hard. > The problem is that, if you wait, they'll only squeal when the code is > close to going in, and you could find yourself set back a long way. A > good firs