ers, making it clear it is a count
>rather than a boolean
> 10. Made pending and error fields int rather than char
Looks good.
You can also update the year in the copyright string in the files :)
--
Evgeniy Polyakov
--
To unsubscribe from this list: send the l
offset = SQUASHFS_INODE_OFFSET(ino);
> +
> + type = le16_to_cpu(sqshb_ino->inode_type);
> + switch (type) {
> + case SQUASHFS_REG_TYPE: {
> + unsigned int frag_offset, frag_size, frag;
> + u64 frag_blk;
Above variables can be moved out
locate squashfs_dir_entry\n");
> + return ERR_PTR(-ENOMEM);
> + }
> +
> + if (len > SQUASHFS_NAME_LEN) {
> + err = -ENAMETOOLONG;
> + goto failed;
> + }
> +
> + length = get_dir_index_using_name(dir->i_sb, &block, &offset,
>
d.
As a generic comment of the style: imho u64 is more appropriate than
long long, at least it is less keys to press when typing :)
--
Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-embedded" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
gt; + int c_byte = length;
> +
> + bh = kcalloc((msblk->block_size >> msblk->devblksize_log2) + 1,
> + sizeof(*bh), GFP_KERNEL);
Could be great to have a memory pool though...
--
Evgeniy Polyakov
--
To unsubscribe from this list: s
This is invoked for every read when cache is filled, if I understood
correctly, and having a modulo in this path is an additional overhead.
This may be hidden on behalf of compression overhead, but stil.
Also what happens when there are no unlocked entries? I.e. you will try
to work with existin
