Re: [PATCH 1/2] Squashfs: add LZ4 compression support

2013-07-21 Thread Joe Perches
On Mon, 2013-07-22 at 03:21 +0100, Phillip Lougher wrote: Add support for reading file systems compressed with the LZ4 compression algorithm. Some whitespace trivia and a naming comment. diff --git a/fs/squashfs/lz4_wrapper.c b/fs/squashfs/lz4_wrapper.c [] +static void *lz4_init(struct

Re: [PATCH 01/32] init.h: remove __cpuinit sections from the kernel

2013-06-24 Thread Joe Perches
On Mon, 2013-06-24 at 15:30 -0400, Paul Gortmaker wrote: The __cpuinit type of throwaway sections might have made sense some time ago when RAM was more constrained, but now the savings do not offset the cost and complications. For example, the fix in commit 5e427ec2d0 (x86: Fix bit corruption

Re: [PATCH] Revised patch

2011-06-09 Thread Joe Perches
On Thu, 2011-06-09 at 10:47 -0700, Randy Dunlap wrote: On Thu, 9 Jun 2011 18:33:46 +0100 Andrew Murray wrote: + For printing IPv6 network-order 16 bit hex addresses. The 'I6' and 'i6' 16-bit byte. octet if pedantry is desired. -- To unsubscribe from

Re: [PATCH] printk-formats.txt documentation update

2011-06-09 Thread Joe Perches
On Thu, 2011-06-09 at 14:51 -0700, Randy Dunlap wrote: On Thu, 9 Jun 2011 22:24:48 +0100 Andrew Murray wrote: + For printing-16 byte UUID/GUIDs addresses. The additional 'l', 'L', For printing 16-byte You want to resend or shall I just fix it? Hey Randy. I find your seeming

Re: [PATCH] module: Use binary search in lookup_symbol()

2011-05-16 Thread Joe Perches
On Mon, 2011-05-16 at 14:01 -0700, Joe Perches wrote: On Mon, 2011-05-16 at 22:23 +0200, Alessio Igor Bogani wrote: Signed-off-by: Alessio Igor Bogani abog...@kernel.org diff --git a/kernel/module.c b/kernel/module.c @@ -2055,10 +2055,8 @@ static const struct kernel_symbol *lookup_symbol

[PATCH] ssb: Use pr_fmt and pr_level, remove CONFIG_SSB_SILENT

2011-04-05 Thread Joe Perches
Use the more common logging styles. Remove CONFIG_SSB_SILENT which doesn't appear particularly useful. Remove ERROR: prefixes from pr_err messages. Signed-off-by: Joe Perches j...@perches.com --- drivers/ssb/Kconfig | 14 +- drivers/ssb/driver_chipcommon.c |2

Re: [PATCH] printk-formats.txt documentation update

2011-02-07 Thread Joe Perches
On Mon, 2011-02-07 at 18:12 +, Andrew Murray wrote: On 7 February 2011 09:29, Wolfram Sang w.s...@pengutronix.de wrote: On Sun, Feb 06, 2011 at 04:23:09PM +, Andrew Murray wrote: + + For printing kernel pointers which should be hidden from unprivileged + users. The

Re: [PATCH 0/7] printk: add pr_level_once, guard print_hex_dump

2010-12-06 Thread Joe Perches
On Mon, 2010-12-06 at 09:37 -0600, Matt Mackall wrote: On Sun, 2010-12-05 at 21:44 -0800, Joe Perches wrote: There are many uses of printk_once(KERN_level. Add pr_level_once macros to avoid printk_once(KERN_level pr_fmt(fmt). Add an #ifdef CONFIG_PRINTK for print_hex_dump and static inline

Re: [PATCH 0/7] printk: add pr_level_once, guard print_hex_dump

2010-12-06 Thread Joe Perches
On Mon, 2010-12-06 at 12:16 -0600, Matt Mackall wrote: On Mon, 2010-12-06 at 10:12 -0800, Joe Perches wrote: There could be ~500 bytes more saved if hex_dump_to_buffer was compiled out. Can't say I'm excited by this approach. .5k is under my threshold for this level of invasiveness. Mine

[PATCH 0/7] printk: add pr_level_once, guard print_hex_dump

2010-12-05 Thread Joe Perches
There are many uses of printk_once(KERN_level. Add pr_level_once macros to avoid printk_once(KERN_level pr_fmt(fmt). Add an #ifdef CONFIG_PRINTK for print_hex_dump and static inline void functions for the #else cases to reduce embedded code size. Neaten and organize the rest of the code. Joe

[PATCH 2/7] include/linux/printk.h: Use space after #define

2010-12-05 Thread Joe Perches
Signed-off-by: Joe Perches j...@perches.com --- include/linux/printk.h | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/include/linux/printk.h b/include/linux/printk.h index 0b4513b..b6218d3 100644 --- a/include/linux/printk.h +++ b/include/linux/printk.h

[PATCH 6/7] include/linux/printk.h: Organize printk_ratelimited macros

2010-12-05 Thread Joe Perches
Use no_printk for !CONFIG_PRINTK printk_ratelimited. Whitespace cleanup. Signed-off-by: Joe Perches j...@perches.com --- include/linux/printk.h | 25 - 1 files changed, 12 insertions(+), 13 deletions(-) diff --git a/include/linux/printk.h b/include/linux/printk.h index

[PATCH 7/7] include/linux/printk.h: Use tab not spaces for indent

2010-12-05 Thread Joe Perches
Signed-off-by: Joe Perches j...@perches.com --- include/linux/printk.h | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/linux/printk.h b/include/linux/printk.h index b4be1b1..41388e3 100644 --- a/include/linux/printk.h +++ b/include/linux/printk.h

[PATCH 3/7] include/linux/printk.h: Use and neaten no_printk

2010-12-05 Thread Joe Perches
space before pointer. Signed-off-by: Joe Perches j...@perches.com --- include/linux/printk.h | 75 +++ 1 files changed, 43 insertions(+), 32 deletions(-) diff --git a/include/linux/printk.h b/include/linux/printk.h index b6218d3..e3858f2 100644

[PATCH 1/7] include/linux/printk.h: Move console functions and variables together

2010-12-05 Thread Joe Perches
Signed-off-by: Joe Perches j...@perches.com --- include/linux/printk.h | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/include/linux/printk.h b/include/linux/printk.h index b772ca5..0b4513b 100644 --- a/include/linux/printk.h +++ b/include/linux

[RFC] move __devinit or __init printk constant format strings to __devinitconst or __initdata?

2009-07-21 Thread Joe Perches
Is moving constant string formats to __devinitconst or __initdata useful for embedded environments? As in: #define printk_section(section, fmt, ...) \ ({ static const section char __fmt[] = fmt; printk(__fmt, ##__VA_ARGS__); }) #define pr_err_section(section, fmt,

Re: [RFC] move __devinit or __init printk constant format strings to __devinitconst or __initdata?

2009-07-21 Thread Joe Perches
On Tue, 2009-07-21 at 16:48 -0500, Matt Mackall wrote: On Tue, 2009-07-21 at 14:20 -0700, Joe Perches wrote: Is moving constant string formats to __devinitconst or __initdata useful for embedded environments? As in: #define printk_section(section, fmt

Re: [RFC] move __devinit or __init printk constant format strings to __devinitconst or __initdata?

2009-07-21 Thread Joe Perches
On Tue, 2009-07-21 at 17:57 -0500, Matt Mackall wrote: On Tue, 2009-07-21 at 14:56 -0700, Joe Perches wrote: On Tue, 2009-07-21 at 16:48 -0500, Matt Mackall wrote: On Tue, 2009-07-21 at 14:20 -0700, Joe Perches wrote: Is moving constant string formats to __devinitconst or __initdata

Re: [RFC] move __devinit or __init printk constant format strings to __devinitconst or __initdata?

2009-07-21 Thread Joe Perches
On Tue, 2009-07-21 at 20:28 -0500, Matt Mackall wrote: On Tue, 2009-07-21 at 16:50 -0700, David Daney wrote: It would be tricky, the string data from the entire compilation unit is intermingled. You would have to separate out only those strings referenced from __init sections into their