Re: [PATCH] [RFC] emit-crash-char: Allow diversion of printk output for crash logging

2008-08-13 Thread David VomLehn
Grant Likely wrote: On Tue, Aug 12, 2008 at 06:30:54PM -0700, David VomLehn wrote: Regardless of implementation, it seems to me that it could be of use for some other embedded platforms. Any suggestions as to where it should go in the tree? drivers/char? drivers/misc? Depends on what

Re: [PATCH] [RFC] emit-crash-char: Allow diversion of printk output for crash logging

2008-08-13 Thread Tim Bird
David VomLehn wrote: Our use case is: 1. We register a panic handler 2. The kernel panics and calls our panic handler 3. We register a function to log printk output 4. We print registers, stack, memory, and various other pieces of information using standard kernel functions, which all use

Re: [PATCH] [RFC] emit-crash-char: Allow diversion of printk output for crash logging

2008-08-13 Thread David VomLehn
Tim Bird wrote: David VomLehn wrote: Our use case is: 1. We register a panic handler 2. The kernel panics and calls our panic handler 3. We register a function to log printk output 4. We print registers, stack, memory, and various other pieces of information using standard kernel functions,

Re: [PATCH] [RFC] emit-crash-char: Allow diversion of printk output for crash logging

2008-08-12 Thread Grant Likely
On Mon, Aug 11, 2008 at 5:34 PM, David VomLehn [EMAIL PROTECTED] wrote: Daniel Walker wrote: On Thu, 2008-08-07 at 19:20 -0700, David VomLehn wrote: Allow diversion of characters generated through printk so that they can be logged separately. The printk_time variables is made externally

Re: [PATCH] [RFC] emit-crash-char: Allow diversion of printk output for crash logging

2008-08-12 Thread Grant Likely
On Tue, Aug 12, 2008 at 06:30:54PM -0700, David VomLehn wrote: Grant Likely wrote: I'm not thrilled with this patch. It seems so much more straight forward in your special case, but it comes at the expense of making the code path more complex in every other case. I would much rather see

Re: [PATCH] [RFC] emit-crash-char: Allow diversion of printk output for crash logging

2008-08-08 Thread Daniel Walker
On Thu, 2008-08-07 at 19:20 -0700, David VomLehn wrote: Allow diversion of characters generated through printk so that they can be logged separately. The printk_time variables is made externally visible so that functions processing the diverted characters can parse off the time added if

Re: [PATCH] [RFC] emit-crash-char: Allow diversion of printk output for crash logging

2008-08-08 Thread Daniel Walker
On Fri, 2008-08-08 at 12:05 -0400, Mike Frysinger wrote: On Fri, Aug 8, 2008 at 11:55 AM, Daniel Walker wrote: Another note, usually when submitting new interfaces like this you should also submit the code that uses the interface .. In your case you might not be able to do that, but it

Re: [PATCH] [RFC] emit-crash-char: Allow diversion of printk output for crash logging

2008-08-08 Thread Mike Frysinger
On Fri, Aug 8, 2008 at 12:17 PM, Daniel Walker wrote: On Fri, 2008-08-08 at 12:05 -0400, Mike Frysinger wrote: On Fri, Aug 8, 2008 at 11:55 AM, Daniel Walker wrote: Another note, usually when submitting new interfaces like this you should also submit the code that uses the interface .. In

Re: [PATCH] [RFC] emit-crash-char: Allow diversion of printk output for crash logging

2008-08-08 Thread Daniel Walker
On Fri, 2008-08-08 at 14:09 -0400, Mike Frysinger wrote: you said usually people submit new interfaces, not it is usually not accepted without at least one user. Well, usually people do submit the users, and if they don't it's usually not accepted.. I invite you to give some of the plenty

Re: [PATCH] [RFC] emit-crash-char: Allow diversion of printk output for crash logging

2008-08-08 Thread Mike Frysinger
On Fri, Aug 8, 2008 at 4:10 PM, Daniel Walker wrote: On Fri, 2008-08-08 at 14:09 -0400, Mike Frysinger wrote: I invite you to give some of the plenty of examples in the tree, you might surprise me.. look at all the new syscalls added without any userspace code in place (still) to use it.

Re: [PATCH] [RFC] emit-crash-char: Allow diversion of printk output for crash logging

2008-08-08 Thread Daniel Walker
On Fri, 2008-08-08 at 16:13 -0400, Mike Frysinger wrote: same sort of things as the point of David's code. early/crash scenarios for people to safely extract portions of the kernel log buffer for transmission/storage elsewhere. as was explained in the original thread behind the commit. How