Re: [PATCH] Move an assert under DEBUG_KERNEL. (attempt 2)

2011-01-10 Thread Randy Dunlap
On Mon, 10 Jan 2011 02:35:33 -0600 Rob Landley wrote: > On 01/06/2011 05:41 PM, Andrew Morton wrote: > > Probably a worthwhile thing to do, IMO. If there's some net-specific > > CONFIG_DEBUG_ setting then that wold be a better thing to use. > > > > However the patch was a) wordwrapped, b) space-

Re: [PATCH] Move an assert under DEBUG_KERNEL. (attempt 2)

2011-01-10 Thread Randy Dunlap
On Mon, 10 Jan 2011 02:35:33 -0600 Rob Landley wrote: > On 01/06/2011 05:41 PM, Andrew Morton wrote: > > Probably a worthwhile thing to do, IMO. If there's some net-specific > > CONFIG_DEBUG_ setting then that wold be a better thing to use. > > > > However the patch was a) wordwrapped, b) space-

[PATCH] Move an assert under DEBUG_KERNEL. (attempt 2)

2011-01-10 Thread Rob Landley
On 01/06/2011 05:41 PM, Andrew Morton wrote: > Probably a worthwhile thing to do, IMO. If there's some net-specific > CONFIG_DEBUG_ setting then that wold be a better thing to use. > > However the patch was a) wordwrapped, b) space-stuffed and c) not cc'ed > to the networking list. So its prospe

Re: [PATCH] Move an assert under DEBUG_KERNEL.

2011-01-07 Thread Rob Landley
On 01/06/2011 05:41 PM, Andrew Morton wrote: +#ifdef CONFIG_DEBUG_KERNEL #define ASSERT_RTNL() do { \ if (unlikely(!rtnl_is_locked())) { \ printk(KERN_ERR "RTNL: assertion failed at %s (%d)\n", \ @@ -789,6 +790,9 @@ extern void __rtnl_unlock(void); dump_

Re: [PATCH] Move an assert under DEBUG_KERNEL.

2011-01-06 Thread Andrew Morton
On Thu, 6 Jan 2011 02:13:38 -0600 Rob Landley wrote: > From: Rob Landley > > Move an assert under DEBUG_KERNEL. > > Signed-off-by: Rob Landley > --- > > Saves about 3k from x86-64 defconfig according to scripts/bloat-o-meter. > > include/linux/rtnetlink.h |4 > 1 file changed, 4

[PATCH] Move an assert under DEBUG_KERNEL.

2011-01-06 Thread Rob Landley
From: Rob Landley Move an assert under DEBUG_KERNEL. Signed-off-by: Rob Landley --- Saves about 3k from x86-64 defconfig according to scripts/bloat-o-meter. include/linux/rtnetlink.h |4 1 file changed, 4 insertions(+) diff --git a/include/linux/rtnetlink.h b/include/linux/rtnetli