Re: [PATCH] bootup: Add built-in kernel command line for x86 (v2)

2008-08-12 Thread Tim Bird
Allow x86 to support a built-in kernel command line. The built-in command line can override the one provided by the boot loader, for those cases where the boot loader is broken or it is difficult to change the command line in the the boot loader. Signed-off-by: Tim Bird [EMAIL PROTECTED] ---

Re: [PATCH] bootup: Add built-in kernel command line for x86

2008-08-11 Thread Ingo Molnar
* Tim Bird [EMAIL PROTECTED] wrote: Add support for a built-in command line for x86 architectures. The Kconfig help gives the major rationale for this addition. i have actually used a local hack quite similar to this to inject boot options into bzImages via randconfig - so i would find this

Re: [PATCH] bootup: Add built-in kernel command line for x86

2008-08-11 Thread H. Peter Anvin
Ingo Molnar wrote: * Tim Bird [EMAIL PROTECTED] wrote: Add support for a built-in command line for x86 architectures. The Kconfig help gives the major rationale for this addition. i have actually used a local hack quite similar to this to inject boot options into bzImages via randconfig -

Re: [PATCH] bootup: Add built-in kernel command line for x86

2008-08-11 Thread Tim Bird
H. Peter Anvin wrote: Ingo Molnar wrote: * Tim Bird [EMAIL PROTECTED] wrote: Add support for a built-in command line for x86 architectures. The Kconfig help gives the major rationale for this addition. i have actually used a local hack quite similar to this to inject boot options into

[PATCH] bootup: Add built-in kernel command line for x86

2008-08-06 Thread Tim Bird
Add support for a built-in command line for x86 architectures. The Kconfig help gives the major rationale for this addition. Note that this option is available for many other arches, and its use is widespread in embedded projects. This patch addresses concerns that were raised with an earlier

Re: [PATCH] bootup: Add built-in kernel command line for x86

2008-08-06 Thread Robert Schwebel
On Wed, Aug 06, 2008 at 02:31:48PM -0700, Tim Bird wrote: Add support for a built-in command line for x86 architectures. The Kconfig help gives the major rationale for this addition. If this feature is desired on all architectures, shouldn't it go out of arch/? rsc -- Dipl.-Ing. Robert

Re: [PATCH] bootup: Add built-in kernel command line for x86

2008-08-06 Thread Matt Mackall
On Wed, 2008-08-06 at 14:31 -0700, Tim Bird wrote: The default behavior is to append the boot loader string to this one. However, there is a mechanism (leading '!') to force the built-in string to override the boot loader string. Nice solution. Where is this relative to early boot option

Re: [PATCH] bootup: Add built-in kernel command line for x86

2008-08-06 Thread Tim Bird
Matt Mackall wrote: On Wed, 2008-08-06 at 14:31 -0700, Tim Bird wrote: The default behavior is to append the boot loader string to this one. However, there is a mechanism (leading '!') to force the built-in string to override the boot loader string. Nice solution. Where is this

Re: [PATCH] bootup: Add built-in kernel command line for x86

2008-08-06 Thread H. Peter Anvin
Tim Bird wrote: One difficulty is that the other arches' command lines are not currently broken, so there's no real incentive to change them. The only thing novel thing I'm adding here is the addition of the leading '!' to allow for an override. This is needed in some x86 cases I'm familiar

Re: [PATCH] bootup: Add built-in kernel command line for x86

2008-08-06 Thread Matt Mackall
On Wed, 2008-08-06 at 15:31 -0700, Tim Bird wrote: Matt Mackall wrote: On Wed, 2008-08-06 at 14:31 -0700, Tim Bird wrote: The default behavior is to append the boot loader string to this one. However, there is a mechanism (leading '!') to force the built-in string to override the boot

Re: [PATCH] bootup: Add built-in kernel command line for x86

2008-08-06 Thread Matt Mackall
On Wed, 2008-08-06 at 15:48 -0700, H. Peter Anvin wrote: Tim Bird wrote: One difficulty is that the other arches' command lines are not currently broken, so there's no real incentive to change them. The only thing novel thing I'm adding here is the addition of the leading '!' to

Re: [PATCH] bootup: Add built-in kernel command line for x86

2008-08-06 Thread Tim Bird
H. Peter Anvin wrote: Tim Bird wrote: The only thing novel thing I'm adding here is the addition of the leading '!' to allow for an override. This is needed in some x86 cases I'm familiar with, but I've haven't seen any cases where it would be useful for other arches. (not to say they don't

Re: [PATCH] bootup: Add built-in kernel command line for x86

2008-08-06 Thread H. Peter Anvin
Matt Mackall wrote: On Wed, 2008-08-06 at 15:48 -0700, H. Peter Anvin wrote: Tim Bird wrote: One difficulty is that the other arches' command lines are not currently broken, so there's no real incentive to change them. The only thing novel thing I'm adding here is the addition of the leading

Re: [PATCH] bootup: Add built-in kernel command line for x86

2008-08-06 Thread H. Peter Anvin
Tim Bird wrote: CONFIG_CMDLINE_OVERRIDE is probably more palatable to other architectures. I'd be OK implementing it with an option, rather than a magic char. I was trying to avoid adding too many options, since many kernel developers prefer fewer options where possible. But the magic char