Re: [PATCH] phylib: make mdio-gpio work without OF (v2)

2008-11-04 Thread Grant Likely
On Tue, Nov 4, 2008 at 7:45 AM, Paulius Zaleckas [EMAIL PROTECTED] wrote: make mdio-gpio work with non OpenFirmware gpio implementation. Aditional changes to mdio-gpio: - use gpio_request() and gpio_free() - place irq[] array in struct mdio_gpio_info - add module description, author and

Re: [PATCH 1/6] [PWM] Generic PWM API implementation

2008-11-04 Thread Mike Frysinger
On Tue, Nov 4, 2008 at 15:16, Bill Gatliff wrote: Mike Frysinger wrote: On Wed, Oct 15, 2008 at 14:14, Bill Gatliff wrote: +int pwm_register(struct pwm_device *pwm) +{ + struct pwm_channel *p; + int wchan; + int ret = 0; the initialization to 0 here isnt needed This is

Re: [PATCH] phylib: make mdio-gpio work without OF (v2)

2008-11-04 Thread David Brownell
On Tuesday 04 November 2008, Grant Likely wrote: At this point, instead of #ifdeffing the function signature, I would much rather see this generalized as something like 'mdio_gpio_setup()'.  Then move the OF and non-OF specific bits into two new functions; mdio_ofgpio_probe() and

Re: [PATCH 1/6] [PWM] Generic PWM API implementation

2008-11-04 Thread Bill Gatliff
Mike Frysinger wrote: every Blackfin processor so far has had dedicated PWM hardware in it, so a backend driver for that arch would show up ... From who? I don't have that hardware. I'm happy to hear that someone is working on it, though, and I would be happy to help review. i'm guessing

Re: [PATCH 1/6] [PWM] Generic PWM API implementation

2008-11-04 Thread David Brownell
On Tuesday 04 November 2008, Mike Frysinger wrote: On Tue, Nov 4, 2008 at 18:55, David Brownell wrote: On Tuesday 04 November 2008, Bill Gatliff wrote: So, what's the next step? How do I advocate for getting this API into mainline? The number of backing implementations seemed a bit low