Re: [PATCH v4 0/3] staging: erofs: option validation for remount and some code cleanups

On 2018/9/20 7:34, cgxu519 wrote: > On 9/19/18 11:22 PM, Gao Xiang wrote: >> Hi Chengguang, >> >> On 2018/9/19 22:53, Chengguang Xu wrote: >>> Hi Greg, Xiang >>> >>> I rebased code on latest erofs-master branch and that branch >>> has already merged the first patch in my previous patchset, >>> so

Re: [PATCH v2 4/6] staging: erofs: cleanup `z_erofs_vle_normalaccess_readpages'

On 2018/9/20 0:06, Gao Xiang wrote: > From: Gao Xiang > > This patch introduces `__should_decompress_synchronously' to > cleanup `z_erofs_vle_normalaccess_readpages'. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

Re: [PATCH v4 0/3] staging: erofs: option validation for remount and some code cleanups

On 9/19/18 11:22 PM, Gao Xiang wrote: Hi Chengguang, On 2018/9/19 22:53, Chengguang Xu wrote: Hi Greg, Xiang I rebased code on latest erofs-master branch and that branch has already merged the first patch in my previous patchset, so this time I only post rest 3 patches. Great, at the most

[PATCH v2 4/6] staging: erofs: cleanup `z_erofs_vle_normalaccess_readpages'

From: Gao Xiang This patch introduces `__should_decompress_synchronously' to cleanup `z_erofs_vle_normalaccess_readpages'. Signed-off-by: Gao Xiang --- change log v2: - Leave the original threshold "3" for DEFAULT_MAX_SYNC_DECOMPRESS_PAGES and just do the cleanup work.

Re: [PATCH 4/6] staging: erofs: cleanup `z_erofs_vle_normalaccess_readpages'

Hi Chao, On 2018/9/19 23:45, Chao Yu wrote: > Hi Xiang, > > On 2018/9/19 23:32, Gao Xiang wrote: >> Hi Chao, >> >> On 2018/9/19 23:26, Chao Yu wrote: >>> Hi Xiang, >>> >>> On 2018/9/19 13:49, Gao Xiang wrote: This patch introduces `__should_decompress_synchronously' to cleanup

Re: [PATCH 4/6] staging: erofs: cleanup `z_erofs_vle_normalaccess_readpages'

Hi Xiang, On 2018/9/19 23:32, Gao Xiang wrote: > Hi Chao, > > On 2018/9/19 23:26, Chao Yu wrote: >> Hi Xiang, >> >> On 2018/9/19 13:49, Gao Xiang wrote: >>> This patch introduces `__should_decompress_synchronously' to >>> cleanup `z_erofs_vle_normalaccess_readpages'. >>> >>> Signed-off-by: Gao

Re: [PATCH 4/6] staging: erofs: cleanup `z_erofs_vle_normalaccess_readpages'

Hi Chao, On 2018/9/19 23:32, Gao Xiang via Linux-erofs wrote: > Hi Chao, > > On 2018/9/19 23:26, Chao Yu wrote: >> Hi Xiang, >> >> On 2018/9/19 13:49, Gao Xiang wrote: >>> This patch introduces `__should_decompress_synchronously' to >>> cleanup `z_erofs_vle_normalaccess_readpages'. >>> >>>

Re: [PATCH 4/6] staging: erofs: cleanup `z_erofs_vle_normalaccess_readpages'

Hi Xiang, On 2018/9/19 13:49, Gao Xiang wrote: > This patch introduces `__should_decompress_synchronously' to > cleanup `z_erofs_vle_normalaccess_readpages'. > > Signed-off-by: Gao Xiang > --- > drivers/staging/erofs/internal.h | 11 +++ > drivers/staging/erofs/super.c | 5 +

Re: [PATCH v4 0/3] staging: erofs: option validation for remount and some code cleanups

Hi Chengguang, On 2018/9/19 22:53, Chengguang Xu wrote: > Hi Greg, Xiang > > I rebased code on latest erofs-master branch and that branch > has already merged the first patch in my previous patchset, > so this time I only post rest 3 patches. Great, at the most time Chao's erofs-master is the

Re: [PATCH 2/6] staging: erofs: fold in `__update_workgrp_llen'

On 2018/9/19 13:49, Gao Xiang wrote: > There is the only one user to use `__update_workgrp_llen'. > Fold it in `z_erofs_vle_work_iter_begin' and cleanup related code. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

Re: [PATCH 1/6] staging: erofs: remove redundant CONFIG_EROFS_FS_XATTRs

On 2018/9/19 13:49, Gao Xiang wrote: > some CONFIG_EROFS_FS_XATTR conditions were added because of > the historial Linux kernel compatibility, which are unneeded now. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

[PATCH v4 3/3] staging: erofs: option validation in remount

Add option validation in remount. After this patch, remount can change recognized options, and for unknown options remount will fail and report error. Signed-off-by: Chengguang Xu Reviewed-by: Chao Yu Reviewed-by: Gao Xiang --- drivers/staging/erofs/super.c | 37

[PATCH v4 1/3] staging: erofs: code cleanup for option parsing of fault_injection

Define a dummpy function of erofs_build_fault_attr() when macro CONFIG_EROFS_FAULT_INJECTION is disabled, so that we don't have to check the macro in calling place. Based on above adjustment, do proper code cleanup for option parsing of fault_injection. Signed-off-by: Chengguang Xu Reviewed-by:

[PATCH v4 2/3] staging: erofs: code cleanup for erofs_show_options()

Add new helper erofs_get_fault_rate() to get fault rate instead of directly getting it from sbi, so we can remove the macro check surrounding it. Signed-off-by: Chengguang Xu Reviewed-by: Chao Yu Reviewed-by: Gao Xiang --- drivers/staging/erofs/super.c | 14 +++--- 1 file changed, 11

Re: [PATCH v3 4/4] staging: erofs: option validation in remount

Hi Chengguang, On 2018/9/19 0:58, Gao Xiang wrote: > Hi Chengguang, > > On 2018/9/18 23:10, Chengguang Xu wrote: >> Add option validation in remount. After this patch, remount >> can change recognized options, and for unknown options remount >> will fail and report error. >> >> Signed-off-by: