Re: [PREVIEW] [PATCH chao/erofs-dev 2/3] staging: erofs: fix race when the managed cache is enabled

2018-10-01 Thread Gao Xiang via Linux-erofs
Hi Chao, On 2018/10/1 17:49, Chao Yu wrote: > On 2018-9-21 11:43, Gao Xiang wrote: >> When the managed cache is enabled, the last reference count >> of a workgroup must be used for its workstation. >> >> Otherwise, it could lead to incorrect (un)freezes in >> the reclaim path, and it would be

Re: [PREVIEW] [PATCH chao/erofs-dev 3/3] staging: erofs: managed pages could be locked at the time of decompression

2018-10-01 Thread Chao Yu
On 2018-9-21 11:43, Gao Xiang wrote: > Managed compressed pages should be unlocked when IO ends by design. > Therefore, these pages will be up-to-date and unlocked at the time > of decompression in general. > > However managed pages could be re-locked in some other paths, such as > the reclaim

Re: [PREVIEW] [PATCH chao/erofs-dev 2/3] staging: erofs: fix race when the managed cache is enabled

2018-10-01 Thread Chao Yu
On 2018-9-21 11:43, Gao Xiang wrote: > When the managed cache is enabled, the last reference count > of a workgroup must be used for its workstation. > > Otherwise, it could lead to incorrect (un)freezes in > the reclaim path, and it would be harmful. Could you add related race condition stack