Re: [PATCH] staging: erofs: Add a blank line after declarations

2018-12-12 Thread Gao Xiang
Hi Sungkyung, On 2018/12/12 23:50, Sungkyung Kim wrote: > Fix a warning from checkpathch.pl: 'Missing a blank line after > declarations' > > Signed-off-by: Sungkyung Kim > --- > drivers/staging/erofs/inode.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH v2] staging:erofs: Remove __EROFS_BIT macro

2018-12-12 Thread Gao Xiang
Hi Aaron, On 2018/12/12 20:02, Aaron Strahlberger wrote: > The `__EROFS_BIT` macro is used only once, do define the > `EROFS_I_DATA_MAPPING_BIT` constant. This Patch removes this > macro and expands it in the place it is used. > > Signed-off-by: Aaron Strahlberger > Signed-off-by: Julius

Re: [PATCH v2] staging:erofs: Fix alignment issues

2018-12-12 Thread Gao Xiang
Hi Aaron, On 2018/12/12 20:00, Aaron Strahlberger wrote: > Fix of `CHECK: Alignment should match open parenthesis` issues, reported by > checkpatch.pl > > Signed-off-by: Aaron Strahlberger > Signed-off-by: Julius Wiedmann > Signed-off-by: Dominik Huber > --- > drivers/staging/erofs/dir.c |

[PATCH v2] staging:erofs: Fix alignment issues

2018-12-12 Thread Aaron Strahlberger
Fix of `CHECK: Alignment should match open parenthesis` issues, reported by checkpatch.pl Signed-off-by: Aaron Strahlberger Signed-off-by: Julius Wiedmann Signed-off-by: Dominik Huber --- drivers/staging/erofs/dir.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

Re: [PATCH] staging: erofs: remove __EROFS_BIT

2018-12-12 Thread Gao Xiang
Hi Chao, On 2018/12/12 19:22, Chao Yu wrote: > On 2018-12-12 1:57, Gao Xiang wrote: >> It's better to use pre-calculated values to make >> on-disk definition more straight-forward and human-readable. >> >> Since there is the only one user, let's remove >> __EROFS_BIT entirely. >> >> Suggested-by:

Re: [PATCH] staging: erofs: remove __EROFS_BIT

2018-12-12 Thread Chao Yu
On 2018-12-12 1:57, Gao Xiang wrote: > It's better to use pre-calculated values to make > on-disk definition more straight-forward and human-readable. > > Since there is the only one user, let's remove > __EROFS_BIT entirely. > > Suggested-by: Joe Perches > Signed-off-by: Gao Xiang It looks