Re: [PATCH] erofs-utils: rename the package name to erofs-utils

On 2019/1/16 13:53, Gao Xiang wrote: > mkfs.erofs is a part of erofs-utils, thus > it isn't suitable for the package name. > > Signed-off-by: Gao Xiang Reviewed-by: Li Guifu Thanks,

Re: [PATCH 3/5] staging: erofs: decrease the shrink count in erofs_workgroup_get

Hi Dan, On 2019/1/16 18:45, Dan Carpenter wrote: > On Wed, Jan 16, 2019 at 04:59:54PM +0800, Gao Xiang wrote: >> It is more suitable to update in erofs_workgroup_get since >> it's actually the one matched with erofs_workgroup_put. >> > > This patch is fine. No need to resend. > > Reviewed-by:

Re: [PATCH 3/5] staging: erofs: decrease the shrink count in erofs_workgroup_get

On Wed, Jan 16, 2019 at 04:59:54PM +0800, Gao Xiang wrote: > It is more suitable to update in erofs_workgroup_get since > it's actually the one matched with erofs_workgroup_put. > This patch is fine. No need to resend. Reviewed-by: Dan Carpenter But for future reference, I found the commit

Re: [PATCH 5/5] staging: erofs: drop the extern prefix for function definitions

On 2019/1/16 16:59, Gao Xiang wrote: > Fix all `CHECK: extern prototypes should be avoided in .h files' > reported by checkpatch.pl. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

Re: [PATCH 4/5] staging: erofs: staticize erofs_shrink_count, erofs_shrink_scan

On 2019/1/16 16:59, Gao Xiang wrote: > Move erofs_shrinker_info to utils.c and therefore > no need to globalize erofs_shrink_count and erofs_shrink_scan. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

Re: [PATCH 3/5] staging: erofs: decrease the shrink count in erofs_workgroup_get

On 2019/1/16 16:59, Gao Xiang wrote: > It is more suitable to update in erofs_workgroup_get since > it's actually the one matched with erofs_workgroup_put. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

Re: [PATCH 2/5] staging: erofs: localize erofs_workgroup_get

On 2019/1/16 16:59, Gao Xiang wrote: > Staticize erofs_workgroup_get since no external user > out of utils.c directly calls erofs_workgroup_get. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

Re: [PATCH 1/5] staging: erofs: sunset erofs_workstation_cleanup_all

On 2019/1/16 16:59, Gao Xiang wrote: > There is only one user calling erofs_workstation_cleanup_all, > and it is no likely that more users will use in that way > in the future. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

[PATCH 3/5] staging: erofs: decrease the shrink count in erofs_workgroup_get

It is more suitable to update in erofs_workgroup_get since it's actually the one matched with erofs_workgroup_put. Signed-off-by: Gao Xiang --- drivers/staging/erofs/utils.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/staging/erofs/utils.c

[PATCH 5/5] staging: erofs: drop the extern prefix for function definitions

Fix all `CHECK: extern prototypes should be avoided in .h files' reported by checkpatch.pl. Signed-off-by: Gao Xiang --- drivers/staging/erofs/internal.h | 47 +-- drivers/staging/erofs/unzip_vle.h | 24 ++-- 2 files changed, 33

[PATCH 2/5] staging: erofs: localize erofs_workgroup_get

Staticize erofs_workgroup_get since no external user out of utils.c directly calls erofs_workgroup_get. Signed-off-by: Gao Xiang --- drivers/staging/erofs/internal.h | 21 - drivers/staging/erofs/utils.c| 19 +++ 2 files changed, 19 insertions(+), 21

[PATCH 1/5] staging: erofs: sunset erofs_workstation_cleanup_all

There is only one user calling erofs_workstation_cleanup_all, and it is no likely that more users will use in that way in the future. Signed-off-by: Gao Xiang --- Hi, These 5 patches are all cleanup patches, no logic change. Thanks, Gao Xiang drivers/staging/erofs/internal.h | 5 -

[PATCH 4/5] staging: erofs: staticize erofs_shrink_count, erofs_shrink_scan

Move erofs_shrinker_info to utils.c and therefore no need to globalize erofs_shrink_count and erofs_shrink_scan. Signed-off-by: Gao Xiang --- drivers/staging/erofs/internal.h | 5 + drivers/staging/erofs/super.c| 6 -- drivers/staging/erofs/utils.c| 14 ++ 3 files