[PATCH] staging: erofs: fix parenthesis alignment

2019-03-18 Thread Julian Merida
Fix all checkpatch issues: "CHECK: Alignment should match open parenthesis" Signed-off-by: Julian Merida Reviewed-by: Gao Xiang --- drivers/staging/erofs/inode.c | 13 +++ drivers/staging/erofs/namei.c | 3 +- drivers/staging/erofs/super.c | 25 --

Re: [PATCH] staging: erofs: fix parenthesis alignment

2019-03-18 Thread Julian Merida
Perfect! So I will resend the patch to Greg and the staging mailing list. Again, thank you very much for all your help. Regards, Julian Mérida El lun., 18 de mar. de 2019 a la(s) 04:49, Gao Xiang (gaoxian...@huawei.com) escribió: > > > On 2019/3/18 12:14, Julian Merida wrote: > > Fix all

Re: [PATCH v3] staging: erofs: Add whitespace after declaration

2019-03-18 Thread Bharath Vedartham
On Mon, Mar 18, 2019 at 11:40:35PM +0800, Gao Xiang wrote: > > > On 2019/3/18 23:38, Greg KH wrote: > > On Mon, Mar 18, 2019 at 09:02:24PM +0530, Bharath Vedartham wrote: > >> Add whitespace after declaration. Fixed the checkpatch.pl warning. > >> > >> --- > > > > No signed-off-by? > > > >>

Re: [PATCH v3] staging: erofs: Add whitespace after declaration

2019-03-18 Thread Gao Xiang
On 2019/3/18 23:38, Greg KH wrote: > On Mon, Mar 18, 2019 at 09:02:24PM +0530, Bharath Vedartham wrote: >> Add whitespace after declaration. Fixed the checkpatch.pl warning. >> >> --- > > No signed-off-by? > >> changes since v2 >> - mutt gave me a lot of problems. Hence 3 patches for a

Re: [PATCH v3] staging: erofs: Add whitespace after declaration

2019-03-18 Thread Greg KH
On Mon, Mar 18, 2019 at 09:02:24PM +0530, Bharath Vedartham wrote: > Add whitespace after declaration. Fixed the checkpatch.pl warning. > > --- No signed-off-by? > changes since v2 > - mutt gave me a lot of problems. Hence 3 patches for a really > small problem. > - Fixed

[PATCH v3] staging: erofs: Add whitespace after declaration

2019-03-18 Thread Bharath Vedartham
Add whitespace after declaration. Fixed the checkpatch.pl warning. --- changes since v2 - mutt gave me a lot of problems. Hence 3 patches for a really small problem. - Fixed the extra missing line. Signed-off-by: Bharath Vedartham --- drivers/staging/erofs/inode.c | 2

Re: [PATCH v3 for-4.19] staging: erofs: fix race when the managed cache is enabled

2019-03-18 Thread Greg Kroah-Hartman
On Mon, Mar 18, 2019 at 03:26:34PM +0800, Gao Xiang wrote: > commit 51232df5e4b268936beccde5248f312a316800be upstream. > > When the managed cache is enabled, the last reference count > of a workgroup must be used for its workstation. > > Otherwise, it could lead to incorrect (un)freezes in > the

Re: [PATCH] staging: erofs: fix parenthesis alignment

2019-03-18 Thread Gao Xiang
On 2019/3/18 12:14, Julian Merida wrote: > Fix all checkpatch issues: "CHECK: Alignment should match open parenthesis" > > Signed-off-by: Julian Merida looks good to me personally, you can add: Reviewed-by: Gao Xiang btw, I cc greg and staging mailing list, could you please resend this

[PATCH v3 for-4.19] staging: erofs: fix race when the managed cache is enabled

2019-03-18 Thread Gao Xiang
commit 51232df5e4b268936beccde5248f312a316800be upstream. When the managed cache is enabled, the last reference count of a workgroup must be used for its workstation. Otherwise, it could lead to incorrect (un)freezes in the reclaim path, and it would be harmful. A typical race as follows: