Re: [PATCH] erofs-utils: stop mkfs when access permission denied

2020-11-21 Thread Gao Xiang
Hi Guifu, I'd suggest the following subject... erofs-utils: stop building tree if file fails to open On Sun, Nov 22, 2020 at 12:27:59PM +0800, Li Guifu via Linux-erofs wrote: > It would not has the permission to access one file when mkfs.erofs > was not run in the root mode, eg run without sudo,

Re: [PATCH 1/3] erofs-utils: introduce fuse implementation

2020-11-21 Thread Gao Xiang
On Sun, Nov 22, 2020 at 12:43:31PM +0800, Li GuiFu via Linux-erofs wrote: > Gao Xiang > > It run good, some codes format need to be adjusted > Please re-send to make more readable Thanks for taking time on this, I also think it might be worth adding some testcase coverage for erofsfuse later. Let

Re: [PATCH 1/3] erofs-utils: introduce fuse implementation

2020-11-21 Thread Li GuiFu via Linux-erofs
Gao Xiang It run good, some codes format need to be adjusted Please re-send to make more readable On 2020/11/21 1:41, Gao Xiang via Linux-erofs wrote: > From: Li Guifu > > Let's add a simple erofsfuse approach, and benefits are: > > - images can be supported on various platforms; > - new unp

[PATCH] erofs-utils: stop mkfs when access permission denied

2020-11-21 Thread Li Guifu via Linux-erofs
It would not has the permission to access one file when mkfs.erofs was not run in the root mode, eg run without sudo, So stop and exit immediately Signed-off-by: Li Guifu --- lib/inode.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/inode.c b/lib/inode.c index f

[PATCH v2] lib/lz4: explicitly support in-place decompression

2020-11-21 Thread Gao Xiang
LZ4 final literal copy could be overlapped when doing in-place decompression, so it's unsafe to just use memcpy() on an optimized memcpy approach but memmove() instead. Upstream LZ4 has updated this years ago [1] (and the impact is non-sensible [2] plus only a few bytes remain), this commit just s

[PATCH v2 3/3] erofs-utils: fuse: add compressed file support

2020-11-21 Thread Gao Xiang via Linux-erofs
From: Gao Xiang From: Huang Jianan This patch adds a simple approach (~ 700 LOC) to EROFS fixed-sized output decompression without inplace I/O or decompression inplace so it's easy to be ported everywhere with less constraint. However, the on-disk compressed index parser (aka. zmap) is largely

[PATCH v2 2/3] erofs-utils: fuse: support symlink & special inode

2020-11-21 Thread Gao Xiang via Linux-erofs
From: Gao Xiang From: Huang Jianan This patch adds symlink and special inode (e.g. block dev, char, socket, pipe inode) support. Signed-off-by: Huang Jianan Signed-off-by: Guo Weichao Signed-off-by: Gao Xiang --- fuse/main.c | 10 ++ lib/namei.c | 22 ++ 2 files

[PATCH v2 0/3] erofs-utils: introduce fuse implementation

2020-11-21 Thread Gao Xiang via Linux-erofs
From: Gao Xiang changes since v1: - fix off-by-one error of namebuf in erofs_fill_dentries(); - drop unused "struct erofs_super_block super;" in lib/super.c; - fix clang/32-bit build errors founded by travis CI. Hi all, I've finished cleaning up erofsfuse - a fuse implementation of erofs ju

[PATCH v2 1/3] erofs-utils: introduce fuse implementation

2020-11-21 Thread Gao Xiang via Linux-erofs
From: Gao Xiang From: Li Guifu Let's add a simple erofsfuse approach, and benefits are: - images can be supported on various platforms; - new unpack tool can be developed based on this; - new on-disk features can be iterated, verified effectively. This commit only addresses reading uncompr