Re: [PATCH v2] erofs: fix refcount on the metabuf used for inode lookup

2024-02-21 Thread Chao Yu
On 2024/2/22 5:03, Sandeep Dhavale wrote: In erofs_find_target_block() when erofs_dirnamecmp() returns 0, we do not assign the target metabuf. This causes the caller erofs_namei()'s erofs_put_metabuf() at the end to be not effective leaving the refcount on the page. As the page from metabuf

Re: [PATCH v2] erofs: fix refcount on the metabuf used for inode lookup

2024-02-21 Thread Jingbo Xu
On 2/22/24 5:03 AM, Sandeep Dhavale wrote: > In erofs_find_target_block() when erofs_dirnamecmp() returns 0, > we do not assign the target metabuf. This causes the caller > erofs_namei()'s erofs_put_metabuf() at the end to be not effective > leaving the refcount on the page. > As the page from

Re: [PATCH v2 4/7] erofs-utils: mkfs: optionally print warning in erofs_compressor_init

2024-02-21 Thread Gao Xiang
On 2024/2/20 15:55, Yifan Zhao wrote: In the incoming multi-threaded compression support, compressor may be initialized more than once in different worker threads, resulting in noisy warning output. This patch make sure that each warning message is printed only once by adding a print_warning

Re: [PATCH v2 1/7] erofs-utils: introduce multi-threading framework

2024-02-21 Thread Gao Xiang
On 2024/2/20 15:55, Yifan Zhao wrote: Add a workqueue implementation for multi-threading support inspired by xfsprogs. Signed-off-by: Yifan Zhao Suggested-by: Gao Xiang --- configure.ac | 16 + include/erofs/internal.h | 3 + include/erofs/workqueue.h | 38

Re: [PATCH v2] erofs: fix refcount on the metabuf used for inode lookup

2024-02-21 Thread Gao Xiang
On 2024/2/22 05:03, Sandeep Dhavale wrote: In erofs_find_target_block() when erofs_dirnamecmp() returns 0, we do not assign the target metabuf. This causes the caller erofs_namei()'s erofs_put_metabuf() at the end to be not effective leaving the refcount on the page. As the page from metabuf

[PATCH v2] erofs: fix refcount on the metabuf used for inode lookup

2024-02-21 Thread Sandeep Dhavale via Linux-erofs
In erofs_find_target_block() when erofs_dirnamecmp() returns 0, we do not assign the target metabuf. This causes the caller erofs_namei()'s erofs_put_metabuf() at the end to be not effective leaving the refcount on the page. As the page from metabuf (buf->page) is never put, such page cannot be