Re: [PATCH] erofs-utils: set opaque flag for directories in tarerofs mode

2024-04-01 Thread Jingbo Xu
On 4/2/24 10:58 AM, Gao Xiang wrote: > Opaque dir flag is needed if the tar tree is used immediately for > the upcoming append mode. > > Signed-off-by: Gao Xiang > --- > lib/tar.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/lib/tar.c b/lib/tar.c > index 7c271f6..b45657d

Re: [PATCH 2/2] erofs: rename per CPU buffer to global buffer pool and make it configurable

2024-04-01 Thread Gao Xiang
On 2024/4/1 21:56, Chunhai Guo wrote: It will cost more time if compressed buffers are allocated on demand for low-latency algorithms (like lz4) so EROFS uses per-CPU buffers to keep compressed data if in-place decompression is unfulfilled. While it is kind of wasteful of memory for a device

[PATCH] erofs-utils: set opaque flag for directories in tarerofs mode

2024-04-01 Thread Gao Xiang
Opaque dir flag is needed if the tar tree is used immediately for the upcoming append mode. Signed-off-by: Gao Xiang --- lib/tar.c | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/tar.c b/lib/tar.c index 7c271f6..b45657d 100644 --- a/lib/tar.c +++ b/lib/tar.c @@ -909,6 +909,11 @@

Re: [PATCH 1/2] erofs: rename utils.c to zutil.c

2024-04-01 Thread Gao Xiang
On 2024/4/1 21:55, Chunhai Guo wrote: Currently, utils.c is only useful if CONFIG_EROFS_FS_ZIP is on. So let's rename as zutil.c as well as avoid its inclusion if CONFIG_EROFS_FS_ZIP is explicitly disabled. Signed-off-by: Chunhai Guo Suggested-by: Gao Xiang Looks good to me, Reviewed-by:

Re: [PATCH 26/26] netfs, afs: Use writeback retry to deal with alternate keys

2024-04-01 Thread Simon Horman
On Thu, Mar 28, 2024 at 04:34:18PM +, David Howells wrote: ... > +void afs_issue_write(struct netfs_io_subrequest *subreq) > { > + struct netfs_io_request *wreq = subreq->rreq; > struct afs_operation *op; > - struct afs_wb_key *wbk = NULL; > - loff_t size =

[PATCH 2/2] erofs: rename per CPU buffer to global buffer pool and make it configurable

2024-04-01 Thread Chunhai Guo via Linux-erofs
It will cost more time if compressed buffers are allocated on demand for low-latency algorithms (like lz4) so EROFS uses per-CPU buffers to keep compressed data if in-place decompression is unfulfilled. While it is kind of wasteful of memory for a device with hundreds of CPUs, and only a small

[PATCH 1/2] erofs: rename utils.c to zutil.c

2024-04-01 Thread Chunhai Guo via Linux-erofs
Currently, utils.c is only useful if CONFIG_EROFS_FS_ZIP is on. So let's rename as zutil.c as well as avoid its inclusion if CONFIG_EROFS_FS_ZIP is explicitly disabled. Signed-off-by: Chunhai Guo Suggested-by: Gao Xiang --- fs/erofs/Makefile | 4 ++-- fs/erofs/{utils.c => zutil.c}