Re: [PATCH 1/1] erofs-utils: lib: treat data blocks filled with 0s as a hole

2024-04-04 Thread Sandeep Dhavale via Linux-erofs
On Thu, Apr 4, 2024 at 7:00 AM Gao Xiang wrote: > > Hi Sandeep, > > On 2024/4/4 07:57, Sandeep Dhavale wrote: > > Add optimization to treat data blocks filled with 0s as a hole. > > Even though diskspace savings are comparable to chunk based or dedupe, > > having no block assigned saves us

Re: [PATCH 1/1] erofs-utils: lib: treat data blocks filled with 0s as a hole

2024-04-04 Thread Gao Xiang
Hi Sandeep, On 2024/4/4 07:57, Sandeep Dhavale wrote: Add optimization to treat data blocks filled with 0s as a hole. Even though diskspace savings are comparable to chunk based or dedupe, having no block assigned saves us redundant disk IOs during read. This patch detects if the block is

[xiang-erofs:dev-test] BUILD SUCCESS 89ee5a850ec8b23f4e5d5f3a89b2dc4257434643

2024-04-04 Thread kernel test robot
allnoconfig gcc arc allyesconfig gcc arc defconfig gcc archsdk_defconfig gcc arc randconfig-001-20240404 gcc arc randconfig

Re: [PATCH 21/26] netfs, 9p: Implement helpers for new write code

2024-04-04 Thread David Howells
David Howells wrote: > > + size_t len = subreq->len - subreq->transferred; > > This actually needs to be 'int len' because of the varargs packet formatter. I think the attached change is what's required. David --- diff --git a/net/9p/client.c b/net/9p/client.c index

Re: [PATCH 21/26] netfs, 9p: Implement helpers for new write code

2024-04-04 Thread David Howells
David Howells wrote: > + size_t len = subreq->len - subreq->transferred; This actually needs to be 'int len' because of the varargs packet formatter. David