Re: [PATCH] erofs-utils: add missing block counting

2024-04-23 Thread Gao Xiang
On 2024/4/24 13:33, Noboru Asai wrote: Hi Gao, I think that erofs_balloc() and erofs_bh_baloon() function in erofs_write_tail_end() also alloc a tail block, Is it not true? erofs_prepare_tail_block() is the place to decide the fallback tail block. But due to some dependency, bh can be

Re: [PATCH] erofs-utils: add missing block counting

2024-04-23 Thread Noboru Asai
Hi Gao, I think that erofs_balloc() and erofs_bh_baloon() function in erofs_write_tail_end() also alloc a tail block, Is it not true? 2024年4月24日(水) 13:54 Gao Xiang : > > Hi Noboru, > > On 2024/4/24 12:34, Noboru Asai wrote: > > Add missing block counting when the data to be inlined is not

Re: [PATCH] erofs-utils: add missing block counting

2024-04-23 Thread Gao Xiang
Hi Noboru, On 2024/4/24 12:34, Noboru Asai wrote: Add missing block counting when the data to be inlined is not inlined. Signed-off-by: Noboru Asai Thanks for catching this! Could we fixup this at erofs_prepare_tail_block()? since currently it the place to allocate a tail block for this.

[PATCH] erofs-utils: add missing block counting

2024-04-23 Thread Noboru Asai
Add missing block counting when the data to be inlined is not inlined. Signed-off-by: Noboru Asai --- lib/inode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/inode.c b/lib/inode.c index cf22bbe..727dcee 100644 --- a/lib/inode.c +++ b/lib/inode.c @@ -840,6 +840,7 @@ static int