Re: [PATCH 4/5] erofs: refine z_erofs_transform_plain() for sub-page block support

2023-12-08 Thread Yue Hu
On Fri, 8 Dec 2023 15:44:33 +0800 Gao Xiang wrote: > On 2023/12/8 15:34, Gao Xiang wrote: > > > > > > ... > > >> min_t(unsigned int, ,)? > >> > >> ../include/linux/minmax.h:21:28: error: comparison of distinct pointer > >> types lacks a cast [-Werror] > >> ?0?2?0?2 (!!(sizeof((typeof(x)

Re: [PATCH 4/5] erofs: refine z_erofs_transform_plain() for sub-page block support

2023-12-07 Thread Gao Xiang
On 2023/12/8 15:34, Gao Xiang wrote: ... min_t(unsigned int, ,)? ../include/linux/minmax.h:21:28: error: comparison of distinct pointer types lacks a cast [-Werror]    (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) What compiler version are you using? I didn't find any error and

Re: [PATCH 4/5] erofs: refine z_erofs_transform_plain() for sub-page block support

2023-12-07 Thread Gao Xiang
On 2023/12/8 13:20, Yue Hu wrote: On Wed, 6 Dec 2023 17:10:56 +0800 Gao Xiang wrote: Sub-page block support is still unusable even with previous commits if interlaced PLAIN pclusters exist. Such pclusters can be found if the fragment feature is enabled. This commit tries to handle "the

Re: [PATCH 4/5] erofs: refine z_erofs_transform_plain() for sub-page block support

2023-12-07 Thread Yue Hu
On Wed, 6 Dec 2023 17:10:56 +0800 Gao Xiang wrote: > Sub-page block support is still unusable even with previous commits if > interlaced PLAIN pclusters exist. Such pclusters can be found if the > fragment feature is enabled. > > This commit tries to handle "the head part" of interlaced PLAIN

[PATCH 4/5] erofs: refine z_erofs_transform_plain() for sub-page block support

2023-12-06 Thread Gao Xiang
Sub-page block support is still unusable even with previous commits if interlaced PLAIN pclusters exist. Such pclusters can be found if the fragment feature is enabled. This commit tries to handle "the head part" of interlaced PLAIN pclusters first: it was once explained in commit fdffc091e6f9