Re: [PATCH v1] erofs: fix refcount on the metabuf used for inode lookup

2024-02-20 Thread Sandeep Dhavale via Linux-erofs
> > If it looks good to you, could you resend a formal patch? Thanks! > Hi Gao, This looks better and more readable. I will send a v2. Thanks, Sandeep. > Thanks, > Gao Xiang

Re: [PATCH v1] erofs: fix refcount on the metabuf used for inode lookup

2024-02-20 Thread Gao Xiang
Hi Sandeep, On 2024/2/21 03:11, Sandeep Dhavale wrote: In erofs_find_target_block() when erofs_dirnamecmp() returns 0, we do not assign the target metabuf. This causes the caller erofs_namei()'s erofs_put_metabuf() at the end to be not effective leaving the refcount on the page. As the page

[PATCH v1] erofs: fix refcount on the metabuf used for inode lookup

2024-02-20 Thread Sandeep Dhavale via Linux-erofs
In erofs_find_target_block() when erofs_dirnamecmp() returns 0, we do not assign the target metabuf. This causes the caller erofs_namei()'s erofs_put_metabuf() at the end to be not effective leaving the refcount on the page. As the page from metabuf (buf->page) is never put, such page cannot be