Re: [PATCH v3 7/7] erofs: redundant assignment in __erofs_get_meta_page()

Hi Christoph, On Fri, Aug 30, 2019 at 09:28:12AM -0700, Christoph Hellwig wrote: > > - err = bio_add_page(bio, page, PAGE_SIZE, 0); > > - if (err != PAGE_SIZE) { > > + if (bio_add_page(bio, page, PAGE_SIZE, 0) != PAGE_SIZE) { > > err = -EFAULT; >

Re: [PATCH v3 7/7] erofs: redundant assignment in __erofs_get_meta_page()

> - err = bio_add_page(bio, page, PAGE_SIZE, 0); > - if (err != PAGE_SIZE) { > + if (bio_add_page(bio, page, PAGE_SIZE, 0) != PAGE_SIZE) { > err = -EFAULT; > goto err_out; > } This patch looks like an

Re: [PATCH v3 7/7] erofs: redundant assignment in __erofs_get_meta_page()

On 2019/8/30 11:36, Gao Xiang wrote: > As Joe Perches suggested [1], > err = bio_add_page(bio, page, PAGE_SIZE, 0); > - if (unlikely(err != PAGE_SIZE)) { > + if (err != PAGE_SIZE) { > err = -EFAULT; > goto err_out; >

[PATCH v3 7/7] erofs: redundant assignment in __erofs_get_meta_page()

As Joe Perches suggested [1], err = bio_add_page(bio, page, PAGE_SIZE, 0); - if (unlikely(err != PAGE_SIZE)) { + if (err != PAGE_SIZE) { err = -EFAULT; goto err_out; } The initial