Re: [PREVIEW] [PATCH] staging: erofs: fix race of initializing xattrs of a inode at the same time

2019-02-17 Thread Gao Xiang
Hi Chao, On 2019/2/18 9:43, Chao Yu wrote: > Yes, you're right, I just missed some points... > > Reviewed-by: Chao Yu > Thanks for kindly reviewing, I can send this patch to the staging list later. :) Thanks, Gao Xiang > Thanks,

Re: [PREVIEW] [PATCH] staging: erofs: fix race of initializing xattrs of a inode at the same time

2019-02-15 Thread Gao Xiang
Hi Chao, On 2019/2/15 15:29, Chao Yu wrote: > On 2019/2/14 23:34, Gao Xiang wrote: >> In real scenario, there could be several threads accessing xattrs >> of the same xattr-uninitialized inode, and init_inode_xattrs() >> almost at the same time. > > Yeah, nice catch! > >> >> That's actually an

Re: [PREVIEW] [PATCH] staging: erofs: fix race of initializing xattrs of a inode at the same time

2019-02-14 Thread Chao Yu
On 2019/2/14 23:34, Gao Xiang wrote: > In real scenario, there could be several threads accessing xattrs > of the same xattr-uninitialized inode, and init_inode_xattrs() > almost at the same time. Yeah, nice catch! > > That's actually an unexpected behavior, this patch closes the race. > >

[PREVIEW] [PATCH] staging: erofs: fix race of initializing xattrs of a inode at the same time

2019-02-14 Thread Gao Xiang
In real scenario, there could be several threads accessing xattrs of the same xattr-uninitialized inode, and init_inode_xattrs() almost at the same time. That's actually an unexpected behavior, this patch closes the race. Fixes: b17500a0fdba ("staging: erofs: introduce xattr & acl support") Cc: