Re: [PATCH v1] erofs-utils: mkfs: Implement 'dsunit' alignment on blobdev

2025-08-21 Thread friendy...@sony.com
I will update patch. From: Gao Xiang Sent: Thursday, August 21, 2025 18:03 To: Su, Friendy; linux-erofs@lists.ozlabs.org Cc: Mo, Yuezhang; Palmer, Daniel (SGC) Subject: Re: [PATCH v1] erofs-utils: mkfs: Implement 'dsunit' alignment on blobdev On 2025/8/21 17: 36, Frie

Re: [PATCH v1] erofs-utils: mkfs: Implement 'dsunit' alignment on blobdev

2025-08-21 Thread Gao Xiang
On 2025/8/21 17:36, friendy...@sony.com wrote: Hi, Gao, But if there is some deduplciated chunks in the logical dsunit boundary, don't align it at all since there is no real benefit. Although I'm still not sure what's the default behavior of `dsunit` for chunks. Exactly, if `--chunksize=40

Re: [PATCH v1] erofs-utils: mkfs: Implement 'dsunit' alignment on blobdev

2025-08-21 Thread friendy...@sony.com
__ From: Gao Xiang Sent: Thursday, August 21, 2025 11:39 To: Su, Friendy; linux-erofs@lists.ozlabs.org Cc: Mo, Yuezhang; Palmer, Daniel (SGC) Subject: Re: [PATCH v1] erofs-utils: mkfs: Implement 'dsunit' alignment on blobdev On 2025/8/21 11: 33, Gao Xiang wrote: > Hi

Re: [PATCH v1] erofs-utils: mkfs: Implement 'dsunit' alignment on blobdev

2025-08-20 Thread Gao Xiang
Thanks, Gao Xiang Thanks, Gao Xiang Best Regards Friendy Su From: Gao Xiang Sent: Thursday, August 21, 2025 10:00 To: Su, Friendy; linux-erofs@lists.ozlabs.org Cc: Mo, Yuezhang; Palmer, Daniel (SGC) Subject: Re: [PATCH v1] erofs-utils: mkfs: Implement &

Re: [PATCH v1] erofs-utils: mkfs: Implement 'dsunit' alignment on blobdev

2025-08-20 Thread Gao Xiang
ts.ozlabs.org Cc: Mo, Yuezhang; Palmer, Daniel (SGC) Subject: Re: [PATCH v1] erofs-utils: mkfs: Implement 'dsunit' alignment on blobdev On 2025/8/20 17: 38, Friendy. Su@ sony. com wrote: > Hi, Gao, > >> What's your `--chunksize` ? consider the following: > > chu

Re: [PATCH v1] erofs-utils: mkfs: Implement 'dsunit' alignment on blobdev

2025-08-20 Thread friendy...@sony.com
ser. Best Regards Friendy Su From: Gao Xiang Sent: Thursday, August 21, 2025 10:00 To: Su, Friendy; linux-erofs@lists.ozlabs.org Cc: Mo, Yuezhang; Palmer, Daniel (SGC) Subject: Re: [PATCH v1] erofs-utils: mkfs: Implement 'dsunit' alignment on blobdev On 2025/8/20 17: 38,

Re: [PATCH v1] erofs-utils: mkfs: Implement 'dsunit' alignment on blobdev

2025-08-20 Thread Gao Xiang
On 2025/8/20 17:38, friendy...@sony.com wrote: Hi, Gao, What's your `--chunksize` ? consider the following: chunksize = 4096 dsunit = 512 = 2M and two inodes: inode A (8k)2M, 2M+4k inode B (12k) 4M, 2M, 4M+4k, 4M+8k? Is it possible? what's the expected behavior of th

Re: [PATCH v1] erofs-utils: mkfs: Implement 'dsunit' alignment on blobdev

2025-08-20 Thread friendy...@sony.com
August 20, 2025 17:12 To: Su, Friendy; linux-erofs@lists.ozlabs.org Cc: Mo, Yuezhang; Palmer, Daniel (SGC) Subject: Re: [PATCH v1] erofs-utils: mkfs: Implement 'dsunit' alignment on blobdev Hi, On 2025/8/20 17: 00, Friendy. Su@ sony. com wrote: > Hi, Gao, > > Thanks for your r

Re: [PATCH v1] erofs-utils: mkfs: Implement 'dsunit' alignment on blobdev

2025-08-20 Thread friendy...@sony.com
riendy Su From: Gao Xiang Sent: Wednesday, August 20, 2025 15:44 To: Su, Friendy; linux-erofs@lists.ozlabs.org Cc: Mo, Yuezhang; Palmer, Daniel (SGC) Subject: Re: [PATCH v1] erofs-utils: mkfs: Implement 'dsunit' alignment on blobdev Hi Friendly, On 2025/8/20

Re: [PATCH v1] erofs-utils: mkfs: Implement 'dsunit' alignment on blobdev

2025-08-20 Thread Gao Xiang
Hi, On 2025/8/20 17:00, friendy...@sony.com wrote: Hi, Gao, Thanks for your review ! As for this patch, what if the inode itself is chunk-deduplicated, could we apply this if the inode only has one new chunk instead at least for now? Do you mean inode has 3 chunks, chunk#2 and chunk#3 dupli

Re: [PATCH v1] erofs-utils: mkfs: Implement 'dsunit' alignment on blobdev

2025-08-20 Thread Gao Xiang
Hi Friendly, On 2025/8/20 15:23, Friendy Su wrote: Set proper 'dsunit' to let file body align on huge page on blobdev, where 'dsunit' * 'blocksize' = huge page size (2M). When do mmap() a file mounted with dax=always, aligning on huge page makes kernel map huge page(2M) per page fault exceptio