Re: erofs: Question on unused fields in on-disk structs

2019-08-22 Thread Richard Weinberger
On Thu, Aug 22, 2019 at 12:03 AM Gao Xiang wrote: > > Hi Richard, > > On Wed, Aug 21, 2019 at 11:37:30PM +0200, Richard Weinberger wrote: > > Gao Xiang, > > > > On Mon, Aug 19, 2019 at 10:45 PM Gao Xiang via Linux-erofs > > wrote: > > > > struct erofs_super_block has "checksum" and "features"

Re: erofs: Question on unused fields in on-disk structs

2019-08-22 Thread Gao Xiang
Hi Richard, On Thu, Aug 22, 2019 at 10:33:01AM +0200, Richard Weinberger wrote: > On Thu, Aug 22, 2019 at 12:03 AM Gao Xiang wrote: > > > > Hi Richard, > > > > On Wed, Aug 21, 2019 at 11:37:30PM +0200, Richard Weinberger wrote: > > > Gao Xiang, > > > > > > On Mon, Aug 19, 2019 at 10:45 PM Gao

Re: erofs: Question on unused fields in on-disk structs

2019-08-22 Thread Gao Xiang
On Thu, Aug 22, 2019 at 05:05:41PM +0800, Gao Xiang wrote: [] > > > > But be very sure that existing erofs filesystems actually have this field > > set to 0 or something other which is always the same. > > Otherwise you cannot use the field anymore because it could be anything. > > A common bug

Re: [PATCH v8 00/24] erofs: promote erofs from staging v8

2019-08-22 Thread Gao Xiang
Hi Greg, On Thu, Aug 15, 2019 at 11:06:03AM +0200, Greg Kroah-Hartman wrote: > On Thu, Aug 15, 2019 at 12:41:31PM +0800, Gao Xiang wrote: > > [I strip the previous cover letter, the old one can be found in v6: > > https://lore.kernel.org/r/20190802125347.166018-1-gaoxian...@huawei.com/] > > > >

Re: erofs: Question on unused fields in on-disk structs

2019-08-22 Thread Richard Weinberger
On Thu, Aug 22, 2019 at 4:21 PM Theodore Y. Ts'o wrote: > It might make life easier for other kernel developers if "features" > was named "compat_features" and "requirements" were named > "incompat_features", just because of the long-standing use of that in > ext2, ext3, ext4, ocfs2, etc. But

Re: erofs: Question on unused fields in on-disk structs

2019-08-22 Thread Gao Xiang
Hi Richard, On Thu, Aug 22, 2019 at 04:29:44PM +0200, Richard Weinberger wrote: > On Thu, Aug 22, 2019 at 4:21 PM Theodore Y. Ts'o wrote: > > It might make life easier for other kernel developers if "features" > > was named "compat_features" and "requirements" were named > > "incompat_features",

Re: erofs: Question on unused fields in on-disk structs

2019-08-22 Thread Theodore Y. Ts'o
On Thu, Aug 22, 2019 at 10:33:01AM +0200, Richard Weinberger wrote: > > super block chksum could be a compatible feature right? which means > > new kernel can support it (maybe we can add a warning if such image > > doesn't have a chksum then when mounting) but old kernel doesn't > > care it. > >

[PATCH v2] erofs: move erofs out of staging

2019-08-22 Thread Gao Xiang via Linux-erofs
EROFS filesystem has been merged into linux-staging for a year. EROFS is designed to be a better solution of saving extra storage space with guaranteed end-to-end performance for read-only files with the help of reduced metadata, fixed-sized output compression and decompression inplace