Re: [PATCH v4 45/48] mm: shrinker: make global slab shrink lockless

Hi Dave, On 2023/8/8 10:24, Dave Chinner wrote: On Mon, Aug 07, 2023 at 07:09:33PM +0800, Qi Zheng wrote: diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h index eb342994675a..f06225f18531 100644 --- a/include/linux/shrinker.h +++ b/include/linux/shrinker.h @@ -4,6 +4,8 @@

Re: [PATCH v4 46/48] mm: shrinker: make memcg slab shrink lockless

Hi Dave, On 2023/8/8 10:44, Dave Chinner wrote: On Mon, Aug 07, 2023 at 07:09:34PM +0800, Qi Zheng wrote: Like global slab shrink, this commit also uses refcount+RCU method to make memcg slab shrink lockless. This patch does random code cleanups amongst the actual RCU changes. Can you please

Re: [PATCH v4 44/48] mm: shrinker: add a secondary array for shrinker_info::{map, nr_deferred}

Hi Dave, On 2023/8/8 10:12, Dave Chinner wrote: On Mon, Aug 07, 2023 at 07:09:32PM +0800, Qi Zheng wrote: Currently, we maintain two linear arrays per node per memcg, which are shrinker_info::map and shrinker_info::nr_deferred. And we need to resize them when the shrinker_nr_max is exceeded,

Re: [PATCH v7 01/13] fs: remove silly warning from current_time

On Mon 07-08-23 15:38:32, Jeff Layton wrote: > An inode with no superblock? Unpossible! > > Signed-off-by: Jeff Layton Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/inode.c | 6 -- > 1 file changed,

Re: [PATCH v7 04/13] btrfs: have it use inode_update_timestamps

On Mon 07-08-23 15:38:35, Jeff Layton wrote: > In later patches, we're going to drop the "now" argument from the > update_time operation. Have btrfs_update_time use the new > inode_update_timestamps helper to fetch a new timestamp and update it > properly. > > Signed-off-by: Jeff Layton Nice

Re: [PATCH v7 05/13] fat: make fat_update_time get its own timestamp

On Mon 07-08-23 15:38:36, Jeff Layton wrote: > In later patches, we're going to drop the "now" parameter from the > update_time operation. Fix fat_update_time to fetch its own timestamp. > It turns out that this is easily done by just passing a NULL timestamp > pointer to fat_update_time.

[PATCH v2 1/2] erofs-utils: lib: add a way to request supported algorithms

dump.erofs needs to print supported algorithms instead of available compressors. In addition, clean up erofs_get_compress_algorithm_id() too. Cc: Guo Xuenan Signed-off-by: Gao Xiang --- changes since v1: - fix `available compressors` print. fsck/main.c | 8 ++--

[PATCH v2 2/2] erofs-utils: dump: print more superblock fields

From: Guo Xuenan Let's print compression algorithms and sb_extslots as well as update feature information for dump.erosf The proposed superblock dump is shown as below: Filesystem magic number: 0xE0F5E1E2 Filesystem blocks:4624 Filesystem inode

Re: [PATCH v7 03/13] fs: drop the timespec64 arg from generic_update_time

On Mon 07-08-23 15:38:34, Jeff Layton wrote: > In future patches we're going to change how the ctime is updated > to keep track of when it has been queried. The way that the update_time > operation works (and a lot of its callers) make this difficult, since > they grab a timestamp early and then

Re: [PATCH v7 06/13] ubifs: have ubifs_update_time use inode_update_timestamps

On Mon 07-08-23 15:38:37, Jeff Layton wrote: > In later patches, we're going to drop the "now" parameter from the > update_time operation. Prepare ubifs for this, by having it use the new > inode_update_timestamps helper. > > Signed-off-by: Jeff Layton One comment below: > diff --git

Re: [PATCH v7 09/13] fs: add infrastructure for multigrain timestamps

On Mon 07-08-23 15:38:40, Jeff Layton wrote: > The VFS always uses coarse-grained timestamps when updating the ctime > and mtime after a change. This has the benefit of allowing filesystems > to optimize away a lot metadata updates, down to around 1 per jiffy, > even when a file is under heavy

Re: [PATCH v2 1/2] erofs-utils: lib: add a way to request supported algorithms

Tested-by: Guo Xuenan Thanks Xuenan On 2023/8/8 17:23, Gao Xiang wrote: dump.erofs needs to print supported algorithms instead of available compressors. In addition, clean up erofs_get_compress_algorithm_id() too. Cc: Guo Xuenan Signed-off-by: Gao Xiang --- changes since v1: - fix

Re: [PATCH v7 07/13] xfs: have xfs_vn_update_time gets its own timestamp

On Mon 07-08-23 15:38:38, Jeff Layton wrote: > In later patches we're going to drop the "now" parameter from the > update_time operation. Prepare XFS for this by reworking how it fetches > timestamps and sets them in the inode. Ensure that we update the ctime > even if only S_MTIME is set. > >

Re: [PATCH v7 13/13] btrfs: convert to multigrain timestamps

On Mon 07-08-23 15:38:44, Jeff Layton wrote: > Enable multigrain timestamps, which should ensure that there is an > apparent change to the timestamp whenever it has been written after > being actively observed via getattr. > > Beyond enabling the FS_MGTIME flag, this patch eliminates >

Re: [PATCH v2 1/2] erofs-utils: lib: add a way to request supported algorithms

Tested-by: Guo Xuenan Thanks Xuenan On 2023/8/8 17:23, Gao Xiang wrote: dump.erofs needs to print supported algorithms instead of available compressors. In addition, clean up erofs_get_compress_algorithm_id() too. Cc: Guo Xuenan Signed-off-by: Gao Xiang --- changes since v1: - fix