[PATCH v6 5/5] erofs-utils: mkfs: introduce inner-file multi-threaded compression

2024-03-14 Thread Yifan Zhao
Currently, the creation of EROFS compressed image creation is single-threaded, which suffers from performance issues. This patch attempts to address it by compressing the large file in parallel. Specifically, each input file larger than 16MB is splited into segments, and each worker thread

[PATCH v6 3/5] erofs-utils: mkfs: add --worker=# parameter

2024-03-14 Thread Yifan Zhao
This patch introduces a --worker=# parameter for the incoming multi-threaded compression support. It also introduces a segment size used in multi-threaded compression, which has the default value 16MB and cannot be modified. It also introduces a concept called `segment size` to split large files

[PATCH v6 1/5] erofs-utils: introduce multi-threading framework

2024-03-14 Thread Yifan Zhao
Add a workqueue implementation for multi-threading support inspired by xfsprogs. Signed-off-by: Yifan Zhao Suggested-by: Gao Xiang --- configure.ac | 16 + include/erofs/internal.h | 3 + include/erofs/workqueue.h | 35 +++ lib/Makefile.am | 4 ++

[PATCH v6 2/5] erofs-utils: add a helper to get available processors

2024-03-14 Thread Yifan Zhao
From: Gao Xiang In order to prepare for multi-threaded decompression. Signed-off-by: Gao Xiang --- configure.ac | 1 + include/erofs/config.h | 1 + lib/config.c | 12 3 files changed, 14 insertions(+) diff --git a/configure.ac b/configure.ac index

[PATCH v6 4/5] erofs-utils: lib: introduce atomic operations

2024-03-14 Thread Yifan Zhao
From: Gao Xiang Add some helpers (relaxed semantics) in order to prepare for the upcoming multi-threaded support. For example, compressor may be initialized more than once in different worker threads, resulting in noisy warnings. This patch makes sure that each message will be printed only

[PATCH v6 0/5] erofs-utils: mkfs: introduce multi-threaded compression

2024-03-14 Thread Yifan Zhao
changelog since v5: - use memory buffer instead of tmpfile to store intermediate compressed data - re-strucutre the 5th patch Gao Xiang (2): erofs-utils: add a helper to get available processors erofs-utils: lib: introduce atomic operations Yifan Zhao (3): erofs-utils: introduce

Re: [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-03-14 Thread Alison Schofield
On Fri, Feb 23, 2024 at 12:56:34PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > [ >This is a treewide change. I will likely re-create this patch again in >the second week of the merge window of v6.9 and submit it then. Hoping >to keep the conflicts that it will

Re: [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-03-14 Thread Steven Rostedt
On Thu, 14 Mar 2024 09:57:57 -0700 Alison Schofield wrote: > On Fri, Feb 23, 2024 at 12:56:34PM -0500, Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > > > [ > >This is a treewide change. I will likely re-create this patch again in > >the second week of the merge window of

[PATCH] MAINTAINERS: erofs: add myself as reviewer

2024-03-14 Thread Sandeep Dhavale via Linux-erofs
I have been contributing to erofs for sometime and I would like to help with code reviews as well. Signed-off-by: Sandeep Dhavale --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4f298c4187fb..b130340d71bb 100644 --- a/MAINTAINERS +++

Re: [PATCH] MAINTAINERS: erofs: add myself as reviewer

2024-03-14 Thread Gao Xiang
On 2024/3/15 07:14, Sandeep Dhavale wrote: I have been contributing to erofs for sometime and I would like to help with code reviews as well. Signed-off-by: Sandeep Dhavale Looks good to me, and thanks for taking your time on erofs project: Reviewed-by: Gao Xiang Thanks, Gao Xiang

[PATCH v7 4/5] erofs-utils: lib: introduce atomic operations

2024-03-14 Thread Gao Xiang
Add some helpers (relaxed semantics) in order to prepare for the upcoming multi-threaded support. For example, compressor may be initialized more than once in different worker threads, resulting in noisy warnings. This patch makes sure that each message will be printed only once by adding

[PATCH v7 5/5] erofs-utils: mkfs: introduce inner-file multi-threaded compression

2024-03-14 Thread Gao Xiang
From: Yifan Zhao Currently, the creation of EROFS compressed image creation is single-threaded, which suffers from performance issues. This patch attempts to address it by compressing the large file in parallel. Specifically, each input file larger than 16MB is splited into segments, and each

[PATCH v7 1/5] erofs-utils: introduce multi-threading framework

2024-03-14 Thread Gao Xiang
From: Yifan Zhao Add a workqueue implementation for multi-threading support inspired by xfsprogs. Signed-off-by: Yifan Zhao Suggested-by: Gao Xiang Signed-off-by: Gao Xiang --- configure.ac | 16 + include/erofs/internal.h | 3 + include/erofs/workqueue.h | 34

[PATCH v7 2/5] erofs-utils: add a helper to get available processors

2024-03-14 Thread Gao Xiang
In order to prepare for multi-threaded decompression. Signed-off-by: Yifan Zhao Signed-off-by: Gao Xiang --- configure.ac | 1 + include/erofs/config.h | 1 + lib/config.c | 12 3 files changed, 14 insertions(+) diff --git a/configure.ac b/configure.ac index

[PATCH v7 3/5] erofs-utils: mkfs: add --workers=# parameter

2024-03-14 Thread Gao Xiang
From: Yifan Zhao This patch introduces `--workers=#` parameter for the incoming multi-threaded compression support. It also introduces a concept called `segment size` to split large inodes for multi-threaded compression, which has the fixed value 16MiB and cannot be modified for now.

Re: [PATCH v6 5/5] erofs-utils: mkfs: introduce inner-file multi-threaded compression

2024-03-14 Thread Gao Xiang
On 2024/3/14 20:37, Yifan Zhao wrote: Currently, the creation of EROFS compressed image creation is single-threaded, which suffers from performance issues. This patch attempts to address it by compressing the large file in parallel. Specifically, each input file larger than 16MB is splited

Re: [PATCH] MAINTAINERS: erofs: add myself as reviewer

2024-03-14 Thread Chao Yu
On 2024/3/15 7:14, Sandeep Dhavale via Linux-erofs wrote: I have been contributing to erofs for sometime and I would like to help with code reviews as well. Thank you for the effort and looks good to me. :) Signed-off-by: Sandeep Dhavale Acked-by: Chao Yu Thanks,

Re: [PATCH v7 5/5] erofs-utils: mkfs: introduce inner-file multi-threaded compression

2024-03-14 Thread Gao Xiang
On 2024/3/15 09:10, Gao Xiang wrote: From: Yifan Zhao Currently, the creation of EROFS compressed image creation is single-threaded, which suffers from performance issues. This patch attempts to address it by compressing the large file in parallel. Specifically, each input file larger than

Re: [PATCH v6 5/5] erofs-utils: mkfs: introduce inner-file multi-threaded compression

2024-03-14 Thread Gao Xiang
On 2024/3/15 10:39, Gao Xiang wrote: On 2024/3/14 20:37, Yifan Zhao wrote: Currently, the creation of EROFS compressed image creation is single-threaded, which suffers from performance issues. This patch attempts to address it by compressing the large file in parallel. Specifically, each