Re: [PATCH] erofs: rename per-CPU buffers to global buffer pool and make it configurable

2024-03-22 Thread Chunhai Guo via Linux-erofs
Got it. I will send patch v2 as your suggestion. Thanks, 在 2024/3/22 12:10, Gao Xiang 写道: > > On 2024/3/22 11:47, Chunhai Guo wrote: >> It will cost more time if compressed buffers are allocated on demand for >> low-latency algorithms (like lz4) so EROFS uses per-CPU buffers to keep >>

[PATCH] erofs-utils: tar: all regular inodes should be zeroed in headerball mode

2024-03-22 Thread Gao Xiang
.. Instead of reporting IO errors which implies a corrupted image. Fixes: 6894ca9623e7 ("erofs-utils: mkfs: Support tar source without data") Signed-off-by: Gao Xiang --- include/erofs/blobchunk.h | 1 + lib/blobchunk.c | 41 +++ lib/tar.c

[PATCH v3 1/2] erofs-utils: lib: split function logic in inode.c

2024-03-22 Thread Yifan Zhao
This patch splits part of the logic in function erofs_mkfs_build_tree() and erofs_mkfs_build_tree_from_path() into several new functions. This is in preparation for the upcoming inter-file multi-threaded compression feature. Signed-off-by: Yifan Zhao --- lib/inode.c | 161

[PATCH v3 2/2] erofs-utils: mkfs: introduce inter-file multi-threaded compression

2024-03-22 Thread Yifan Zhao
This patch allows parallelizing the compression process of different files in mkfs. Specifically, a traverser thread traverses the files and issues the compression task, which is handled by the workers. Then, the main thread consumes them and writes the compressed data to the device. To this end,

[PATCH v3 0/2] erofs-utils: mkfs: introduce inter-file multi-threaded compression

2024-03-22 Thread Yifan Zhao
change log since v2: - erofs_queue => erofs_inode_fifo, defined in inode.c Yifan Zhao (2): erofs-utils: lib: split function logic in inode.c erofs-utils: mkfs: introduce inter-file multi-threaded compression include/erofs/compress.h | 16 ++ include/erofs/inode.h| 17 ++

Re: [PATCH v2] erofs: rename per CPU buffer to global buffer pool and make it configurable

2024-03-22 Thread Gao Xiang
Hi Chunhai, On 2024/3/22 19:48, Chunhai Guo wrote: It will cost more time if compressed buffers are allocated on demand for low-latency algorithms (like lz4) so EROFS uses per-CPU buffers to keep compressed data if in-place decompression is unfulfilled. While it is kind of wasteful of memory

Re: [PATCH v3] erofs: rename per CPU buffer to global buffer pool and make it configurable

2024-03-22 Thread Gao Xiang
On 2024/3/22 21:45, Chunhai Guo wrote: It will cost more time if compressed buffers are allocated on demand for low-latency algorithms (like lz4) so EROFS uses per-CPU buffers to keep compressed data if in-place decompression is unfulfilled. While it is kind of wasteful of memory for a

[PATCH v2] erofs: rename per CPU buffer to global buffer pool and make it configurable

2024-03-22 Thread Chunhai Guo via Linux-erofs
It will cost more time if compressed buffers are allocated on demand for low-latency algorithms (like lz4) so EROFS uses per-CPU buffers to keep compressed data if in-place decompression is unfulfilled. While it is kind of wasteful of memory for a device with hundreds of CPUs, and only a small

[PATCH v3] erofs: rename per CPU buffer to global buffer pool and make it configurable

2024-03-22 Thread Chunhai Guo via Linux-erofs
It will cost more time if compressed buffers are allocated on demand for low-latency algorithms (like lz4) so EROFS uses per-CPU buffers to keep compressed data if in-place decompression is unfulfilled. While it is kind of wasteful of memory for a device with hundreds of CPUs, and only a small

Re: [PATCH v3 2/2] erofs-utils: mkfs: introduce inter-file multi-threaded compression

2024-03-22 Thread Huang Jianan
Yifan Zhao 于2024年3月22日周五 18:25写道: > > This patch allows parallelizing the compression process of different > files in mkfs. Specifically, a traverser thread traverses the files and > issues the compression task, which is handled by the workers. Then, the > main thread consumes them and writes the

Re: [PATCH v3 0/2] erofs-utils: mkfs: introduce inter-file multi-threaded compression

2024-03-22 Thread Huang Jianan
Hi, Yifan, I got some warnings and errors via checkpatch.pl on this patchset. You can check and fix them since erofs-utils follows kernel coding style. Thanks, Jianan Yifan Zhao 于2024年3月22日周五 18:24写道: > > change log since v2: > - erofs_queue => erofs_inode_fifo, defined in inode.c > > Yifan

Re: [PATCH v3 2/2] erofs-utils: mkfs: introduce inter-file multi-threaded compression

2024-03-22 Thread Huang Jianan
Huang Jianan 于2024年3月23日周六 11:46写道: > > Yifan Zhao 于2024年3月22日周五 18:25写道: > > > > This patch allows parallelizing the compression process of different > > files in mkfs. Specifically, a traverser thread traverses the files and > > issues the compression task, which is handled by the workers.