Re: [PATCH] erofs-utils: erofs debug utility.

2019-08-21 Thread Gao Xiang
On Thu, Aug 22, 2019 at 04:08:24AM +0800, Gao Xiang via Linux-erofs wrote: > Hi Pratik, > > On Wed, Aug 21, 2019 at 11:45:48PM +0530, Pratik Shinde wrote: > > Thanks Gao, > > > > Let me know when we can work on debug utility OR atleast list out things we > > want to achieve through the utility.

Re: erofs: Question on unused fields in on-disk structs

2019-08-21 Thread Gao Xiang
Hi Richard, On Wed, Aug 21, 2019 at 11:37:30PM +0200, Richard Weinberger wrote: > Gao Xiang, > > On Mon, Aug 19, 2019 at 10:45 PM Gao Xiang via Linux-erofs > wrote: > > > struct erofs_super_block has "checksum" and "features" fields, > > > but they are not used in the source. > > > What is the

Re: erofs: Question on unused fields in on-disk structs

2019-08-21 Thread Richard Weinberger
Gao Xiang, On Mon, Aug 19, 2019 at 10:45 PM Gao Xiang via Linux-erofs wrote: > > struct erofs_super_block has "checksum" and "features" fields, > > but they are not used in the source. > > What is the plan for these? > > Yes, both will be used laterly (features is used for compatible > features,

Re: [PATCH 2/2] staging/erofs: Balanced braces around a few conditional statements.

2019-08-21 Thread Caitlyn Finn
On Wed, Aug 21, 2019 at 11:52 AM Gao Xiang wrote: > > Hi Tobin, > > On Wed, Aug 21, 2019 at 08:13:35AM -0700, Tobin C. Harding wrote: > > On Wed, Aug 21, 2019 at 10:31:22AM +0800, Gao Xiang wrote: > > > On Tue, Aug 20, 2019 at 07:26:46PM -0700, Joe Perches wrote: > > > > On Tue, 2019-08-20 at

Re: [PATCH] erofs-utils: erofs debug utility.

2019-08-21 Thread Pratik Shinde
Thanks Gao, Let me know when we can work on debug utility OR atleast list out things we want to achieve through the utility. Regarding the superblock checksum calculations, Yes I will dedicate sometime this week for it. will start exploring it. --Pratik. On Wed, Aug 21, 2019 at 10:26 PM Gao

Re: [PATCH] erofs-utils: erofs debug utility.

2019-08-21 Thread Gao Xiang via Linux-erofs
Hi Pratik, On Wed, Aug 21, 2019 at 10:08:08PM +0530, Pratik Shinde wrote: > Hello Maintainers, > > After going through the recent mail thread between linux's filesystem folks > on erofs channel, I felt erofs needs an interactive debug utility (like > xfs_db) > which can be used to examine erofs

[PATCH] erofs-utils: erofs debug utility.

2019-08-21 Thread Pratik Shinde
Hello Maintainers, After going through the recent mail thread between linux's filesystem folks on erofs channel, I felt erofs needs an interactive debug utility (like xfs_db) which can be used to examine erofs images & can also be used to inject errors OR fuzzing for testing purpose & dumping

Re: [PATCH 2/2] staging/erofs: Balanced braces around a few conditional statements.

2019-08-21 Thread Gao Xiang
Hi Tobin, On Wed, Aug 21, 2019 at 08:13:35AM -0700, Tobin C. Harding wrote: > On Wed, Aug 21, 2019 at 10:31:22AM +0800, Gao Xiang wrote: > > On Tue, Aug 20, 2019 at 07:26:46PM -0700, Joe Perches wrote: > > > On Tue, 2019-08-20 at 20:18 -0400, Caitlyn wrote: > > > > Balanced braces to fix some

Re: [PATCH 2/2] staging/erofs: Balanced braces around a few conditional statements.

2019-08-21 Thread Tobin C. Harding
On Wed, Aug 21, 2019 at 10:31:22AM +0800, Gao Xiang wrote: > On Tue, Aug 20, 2019 at 07:26:46PM -0700, Joe Perches wrote: > > On Tue, 2019-08-20 at 20:18 -0400, Caitlyn wrote: > > > Balanced braces to fix some checkpath warnings in inode.c and > > > unzip_vle.c > > [] > > > diff --git

Re: [PATCH v2 5/6] staging: erofs: detect potential multiref due to corrupted images

2019-08-21 Thread Chao Yu
On 2019-8-21 22:01, Gao Xiang wrote: > As reported by erofs-utils fuzzer, currently, multiref > (ondisk deduplication) hasn't been supported for now, > we should forbid it properly. > > Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support") > Cc: # 4.19+ > Signed-off-by: Gao

[PATCH v2 5/6] staging: erofs: detect potential multiref due to corrupted images

2019-08-21 Thread Gao Xiang
As reported by erofs-utils fuzzer, currently, multiref (ondisk deduplication) hasn't been supported for now, we should forbid it properly. Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support") Cc: # 4.19+ Signed-off-by: Gao Xiang --- changelog from v1: - change err =

Re: [PATCH v5] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-21 Thread kbuild test robot
Hi Mark, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc5 next-20190820] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v4] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-21 Thread Mark Salyzyn via Linux-erofs
I will redo the manual audit, perhaps I need to not be so scared of allconfig build ;-} (currently my runtime & buildtime test platform is android 4.19 kernel, my bad). I am going through and exploring/changing/testing everything to deal with GregKH/jmorris wanting a single xattr_gs_args

Re: [PATCH v5] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-21 Thread kbuild test robot
Hi Mark, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc5 next-20190820] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v7] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-21 Thread Mark Salyzyn via Linux-erofs
Replace arguments for get and set xattr methods, and __vfs_getxattr and __vfs_setaxtr functions with a reference to the following now common argument structure: struct xattr_gs_args { struct dentry *dentry; struct inode *inode; const char *name; union {

[PATCH v6] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-21 Thread Mark Salyzyn via Linux-erofs
Replace arguments for get and set xattr methods, and __vfs_getxattr and __vfs_setaxtr functions with a reference to the following now common argument structure: struct xattr_gs_args { struct dentry *dentry; struct inode *inode; const char *name; union {

[PATCH v5] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-21 Thread Mark Salyzyn via Linux-erofs
Replace arguments for get and set xattr methods, and __vfs_getxattr and __vfs_setaxtr functions with a reference to the following argument structure: struct xattr_gs_args { struct dentry *dentry; struct inode *inode; const char *name; union { void