Re: [PATCH 6/8] erofs: get rid of fe->backmost for cache decompression

2023-08-17 Thread Yue Hu
On Thu, 17 Aug 2023 16:28:11 +0800 Gao Xiang wrote: > EROFS_MAP_FULL_MAPPED is more accurate to decide if caching the last > incomplete pcluster for later read or not. > > Signed-off-by: Gao Xiang > --- > fs/erofs/zdata.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > >

Re: [PATCH] mm: Change calling convention for ->huge_fault

2023-08-17 Thread kernel test robot
Hi Matthew, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Wilcox-Oracle/mm-Change-calling-convention-for-huge_fault/20230818-040348 base:

Re: [PATCH] mm: Change calling convention for ->huge_fault

2023-08-17 Thread kernel test robot
Hi Matthew, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Wilcox-Oracle/mm-Change-calling-convention-for-huge_fault/20230818-040348 base:

Re: [PATCH 5/8] erofs: drop z_erofs_page_mark_eio()

2023-08-17 Thread Yue Hu
On Thu, 17 Aug 2023 16:28:10 +0800 Gao Xiang wrote: > It can be folded into z_erofs_onlinepage_endio() to simplify the code. > > Signed-off-by: Gao Xiang Reviewed-by: Yue Hu

Re: [PATCH 4/8] erofs: tidy up z_erofs_do_read_page()

2023-08-17 Thread Yue Hu
On Thu, 17 Aug 2023 16:28:09 +0800 Gao Xiang wrote: > - Fix a typo: spiltted => split; > > - Move !EROFS_MAP_MAPPED and EROFS_MAP_FRAGMENT upwards; > > - Increase `split` in advance to avoid unnecessary repeat. > > Signed-off-by: Gao Xiang Reviewed-by: Yue Hu

Re: [PATCH 3/8] erofs: move preparation logic into z_erofs_pcluster_begin()

2023-08-17 Thread Yue Hu
On Thu, 17 Aug 2023 16:28:08 +0800 Gao Xiang wrote: > Some preparation logic should be part of z_erofs_pcluster_begin() > instead of z_erofs_do_read_page(). Let's move now. > > Signed-off-by: Gao Xiang Reviewed-by: Yue Hu

Re: [PATCH 2/8] erofs: avoid obsolete {collector,collection} terms

2023-08-17 Thread Yue Hu
On Thu, 17 Aug 2023 16:28:07 +0800 Gao Xiang wrote: > {collector,collection} were once reserved in order to indicate different > runtime logical extent instance of multi-reference pclusters. > > However, de-duplicated decompression has been landed in a more flexable > way, thus `struct

Re: [PATCH 1/8] erofs: simplify z_erofs_read_fragment()

2023-08-17 Thread Yue Hu
On Thu, 17 Aug 2023 16:28:06 +0800 Gao Xiang wrote: > A trivial cleanup to make the fragment handling logic more clear. > > Signed-off-by: Gao Xiang Reviewed-by: Yue Hu

[xiang-erofs:dev-test] BUILD SUCCESS 80b45c60a9e7e5531caff1ad34c6ddca2b001ed0

2023-08-17 Thread kernel test robot
randconfig-r034-20230817 gcc arc randconfig-r043-20230817 gcc arm allmodconfig gcc arm allyesconfig gcc arm defconfig gcc armdove_defconfig

[PATCH] mm: Change calling convention for ->huge_fault

2023-08-17 Thread Matthew Wilcox (Oracle)
Remove the unnecessary encoding of page order into an enum and allow ->huge_fault to be called with the vma lock held instead of the mmap_lock. These two changes are intentionally bundled together to give people a reasonable chance of noticing that Something Has Changed and they should audit their

Re: [PATCH 1/1] fs/erofs: avoid noisy messages

2023-08-17 Thread Gao Xiang
Hi Heinrich, On 2023/8/17 15:01, Heinrich Schuchardt wrote: The erofs file system creates noisy messages when it is not used: => host bind 0 disk.img => part list host 0 cannot find valid erofs superblock cannot find valid erofs superblock Partition Map for HOST

[PATCH v2 8/8] erofs: adapt folios for z_erofs_read_folio()

2023-08-17 Thread Gao Xiang
It's a straight-forward conversion and no logic changes (except that it renames the corresponding tracepoint.) Signed-off-by: Gao Xiang --- changes since v1: - folio->index is still indexed in the page unit, so PAGE_SHIFT is needed. fs/erofs/zdata.c | 9 -

[PATCH 8/8] erofs: adapt folios for z_erofs_read_folio()

2023-08-17 Thread Gao Xiang
It's a straight-forward conversion and no logic changes (except that it renames the corresponding tracepoint.) Signed-off-by: Gao Xiang --- erofs stress test passes. fs/erofs/zdata.c | 9 - include/trace/events/erofs.h | 16 2 files changed, 12

[PATCH 7/8] erofs: adapt folios for z_erofs_readahead()

2023-08-17 Thread Gao Xiang
It's a straight-forward conversion except that readahead_folio() will do folio_put() in advance but it doesn't matter since folios are still locked. As before, since file-backed folios (pages for now) are locked, so we could temporarily use folio->private as an internal counter to indicate split

[PATCH 5/8] erofs: drop z_erofs_page_mark_eio()

2023-08-17 Thread Gao Xiang
It can be folded into z_erofs_onlinepage_endio() to simplify the code. Signed-off-by: Gao Xiang --- fs/erofs/zdata.c | 29 + 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c index a200e99f7d4f..4009283944ca 100644 ---

[PATCH 6/8] erofs: get rid of fe->backmost for cache decompression

2023-08-17 Thread Gao Xiang
EROFS_MAP_FULL_MAPPED is more accurate to decide if caching the last incomplete pcluster for later read or not. Signed-off-by: Gao Xiang --- fs/erofs/zdata.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c index

[PATCH 4/8] erofs: tidy up z_erofs_do_read_page()

2023-08-17 Thread Gao Xiang
- Fix a typo: spiltted => split; - Move !EROFS_MAP_MAPPED and EROFS_MAP_FRAGMENT upwards; - Increase `split` in advance to avoid unnecessary repeat. Signed-off-by: Gao Xiang --- fs/erofs/zdata.c | 53 ++-- 1 file changed, 24 insertions(+), 29

[PATCH 3/8] erofs: move preparation logic into z_erofs_pcluster_begin()

2023-08-17 Thread Gao Xiang
Some preparation logic should be part of z_erofs_pcluster_begin() instead of z_erofs_do_read_page(). Let's move now. Signed-off-by: Gao Xiang --- fs/erofs/zdata.c | 59 +--- 1 file changed, 26 insertions(+), 33 deletions(-) diff --git

[PATCH 2/8] erofs: avoid obsolete {collector,collection} terms

2023-08-17 Thread Gao Xiang
{collector,collection} were once reserved in order to indicate different runtime logical extent instance of multi-reference pclusters. However, de-duplicated decompression has been landed in a more flexable way, thus `struct z_erofs_collection` was formally removed in commit 87ca34a7065d ("erofs:

[PATCH 1/8] erofs: simplify z_erofs_read_fragment()

2023-08-17 Thread Gao Xiang
A trivial cleanup to make the fragment handling logic more clear. Signed-off-by: Gao Xiang --- fs/erofs/zdata.c | 39 +-- 1 file changed, 13 insertions(+), 26 deletions(-) diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c index 53820271e538..dc104add0a99

[PATCH v3 3/3] erofs-utils: support long xattr name prefixes for erofsfuse

2023-08-17 Thread Jingbo Xu
Make erofs_listxattr() and erofs_getxattr() routine support long xattr name prefixes. Although the on-disk format allows long xattr name prefixes to be placed in the meta inode or packed inode, currently mkfs.erofs will place them in packed inode by default. Thus let's also read long xattr name

[PATCH v3 2/3] erofs-utils: add erofs_read_metadata() helper

2023-08-17 Thread Jingbo Xu
Add erofs_read_metadata() helper reading variable-sized metadata from inode specified by @nid. Read from meta inode if @nid is 0. Signed-off-by: Jingbo Xu --- include/erofs/internal.h | 2 + lib/data.c | 84 2 files changed, 86

[PATCH v3 0/3] erofs-utils: support long xattr name prefixes

2023-08-17 Thread Jingbo Xu
v3: - patch 3: rename to erofs_read_metadata_bdi() and erofs_read_metadata_nid() v2: - add patch 3 to introduce erofs_read_metadata() helper, so that the long xattr name prefixes could also be read from meta inode v1:

[PATCH v3 1/3] erofs-utils: lib: add match_base_prefix() helper

2023-08-17 Thread Jingbo Xu
Since the introduction of long xattr name prefix, match_prefix() will search among the long xattr name prefixes first and return the matched prefix, while erofs_getxattr() expects a base prefix even when the queried xattr name matches a long prefix. Thus introduce match_base_prefix() helper to do

[PATCH 1/1] fs/erofs: avoid noisy messages

2023-08-17 Thread Heinrich Schuchardt
The erofs file system creates noisy messages when it is not used: => host bind 0 disk.img => part list host 0 cannot find valid erofs superblock cannot find valid erofs superblock Partition Map for HOST device 0 -- Partition Type: EFI If there is not erofs file system,