Re: [PATCH 2/3] mm: remove cleancache.c

2019-05-27 Thread David Sterba
btrfs part: > fs/btrfs/extent_io.c | 9 -- > fs/btrfs/super.c | 2 - Acked-by: David Sterba

Re: [PATCH v6 01/24] erofs: add on-disk layout

2019-09-02 Thread David Sterba
On Mon, Sep 02, 2019 at 10:43:03AM +0200, Pavel Machek wrote: > > > > Rather than they didn't run "gdb" or "pahole" and change it by mistake. > > > > > > I think Christoph is not right here. > > > > > > Using external tools for validation is extra work > > > when necessary for understanding the

Re: [PATCH v8 11/24] erofs: introduce xattr & posixacl support

2019-09-02 Thread David Sterba
On Mon, Sep 02, 2019 at 05:57:11AM -0700, Christoph Hellwig wrote: > > +config EROFS_FS_XATTR > > + bool "EROFS extended attributes" > > + depends on EROFS_FS > > + default y > > + help > > + Extended attributes are name:value pairs associated with inodes by > > + the kernel or by

Re: [PATCH v8 11/24] erofs: introduce xattr & posixacl support

2019-09-02 Thread David Sterba
On Mon, Sep 02, 2019 at 09:51:59PM +0800, Chao Yu wrote: > On 2019-9-2 21:06, David Sterba wrote: > > On Mon, Sep 02, 2019 at 05:57:11AM -0700, Christoph Hellwig wrote: > >>> +config EROFS_FS_XATTR > >>> + bool "EROFS extended attributes" > >>&g

Re: [PATCH v6 05/24] erofs: add inode operations

2019-09-02 Thread David Sterba
On Sun, Sep 01, 2019 at 05:34:00PM +0800, Gao Xiang wrote: > > > +static int read_inode(struct inode *inode, void *data) > > > +{ > > > + struct erofs_vnode *vi = EROFS_V(inode); > > > + struct erofs_inode_v1 *v1 = data; > > > + const unsigned int advise = le16_to_cpu(v1->i_advise); > > > +

Re: [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-27 Thread David Sterba
-t...@android.com > Cc: linux-security-mod...@vger.kernel.org > Cc: sta...@vger.kernel.org # 4.4, 4.9, 4.14 & 4.19 > --- > v8: > - Documentation reported 'struct xattr_gs_flags' rather than > 'struct xattr_gs_flags *args' as argument to get and set methods. For btrfs > fs/btrfs/xattr.c | 36 +- Acked-by: David Sterba

Re: [PATCH v3 23/24] erofs: introduce cached decompression

2019-07-23 Thread David Sterba
On Mon, Jul 22, 2019 at 06:58:59PM +0800, Gao Xiang wrote: > On 2019/7/22 6:18, David Sterba wrote: > > On Mon, Jul 22, 2019 at 10:50:42AM +0800, Gao Xiang wrote: > >> +choice > >> + prompt "EROFS Data Decompression mode" > >&

Re: [PATCH v3 23/24] erofs: introduce cached decompression

2019-07-22 Thread David Sterba
On Mon, Jul 22, 2019 at 10:50:42AM +0800, Gao Xiang wrote: > +choice > + prompt "EROFS Data Decompression mode" > + depends on EROFS_FS_ZIP > + default EROFS_FS_ZIP_CACHE_READAROUND > + help > + EROFS supports three options for decompression. > + "In-place I/O Only"

Re: [RFC] errno.h: Provide EFSCORRUPTED for everybody

2019-11-05 Thread David Sterba
On Sat, Nov 02, 2019 at 08:38:23AM +1100, Dave Chinner wrote: > On Fri, Nov 01, 2019 at 09:57:31PM +0100, Geert Uytterhoeven wrote: > > Hi Valdis, > > > > On Thu, Oct 31, 2019 at 2:11 AM Valdis Kletnieks > > wrote: > > > Three questions: (a) ACK/NAK on this patch, (b) should it be all in one > >

Re: [PATCH v8 17/25] btrfs: Convert from readpages to readahead

2020-02-28 Thread David Sterba
On Wed, Feb 26, 2020 at 09:05:07AM -0800, Christoph Hellwig wrote: > On Tue, Feb 25, 2020 at 01:48:30PM -0800, Matthew Wilcox wrote: > > From: "Matthew Wilcox (Oracle)" > > > > Implement the new readahead method in btrfs. Add a readahead_page_batch() > > to optimise fetching a batch of pages at

Re: [PATCH v7 00/23] Change readahead API

2020-02-20 Thread David Sterba
On Wed, Feb 19, 2020 at 01:00:39PM -0800, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > This series adds a readahead address_space operation to eventually > replace the readpages operation. The key difference is that > pages are added to the page cache as they are allocated (and >

Re: [PATCH v7 00/23] Change readahead API

2020-02-21 Thread David Sterba
On Thu, Feb 20, 2020 at 02:39:09PM -0800, Matthew Wilcox wrote: > > > - Now passes an xfstests run on ext4! > > > > On btrfs it still chokes on the first test btrfs/001, with the following > > warning, the test is stuck there. > > Thanks. The warning actually wasn't the problem, but it did

Re: [PATCH v10 17/25] btrfs: Convert from readpages to readahead

2020-03-26 Thread David Sterba
ucharski Sorry for late reply, Reviewed-by: David Sterba

Re: [PATCH v7] iomap: make inline data support more flexible

2021-07-27 Thread David Sterba
On Mon, Jul 26, 2021 at 02:17:02PM +0200, Christoph Hellwig wrote: > > Subject: iomap: Support tail packing > > I can't say I like this "tail packing" language here when we have the > perfectly fine inline wording. Same for various comments in the actual > code. Yes please, don't call it

Re: [PATCH v7] iomap: make inline data support more flexible

2021-07-27 Thread David Sterba
On Tue, Jul 27, 2021 at 02:35:46PM +0100, Matthew Wilcox wrote: > On Tue, Jul 27, 2021 at 10:20:42AM +0200, David Sterba wrote: > > On Mon, Jul 26, 2021 at 02:17:02PM +0200, Christoph Hellwig wrote: > > > > Subject: iomap: Support tail packing > > > > > >

Re: [PATCH 3/5] btrfs: add manual PSI accounting for compressed reads

2022-09-12 Thread David Sterba
for > now. > > Signed-off-by: Christoph Hellwig With some small fixups, Acked-by: David Sterba > fs/btrfs/compression.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c > index e

Re: improve pagecache PSI annotations v2

2022-09-15 Thread David Sterba
On Thu, Sep 15, 2022 at 10:41:55AM +0100, Christoph Hellwig wrote: > > - spell a comment in the weird way preferred by btrfs maintainers What? A comment is a standalone sentence or a full paragraph, so it's formatted as such. I hope it's not weird to expect literacy either in the language of

Re: [PATCH RFC v3 for-6.8/block 09/17] btrfs: use bdev apis

2024-04-10 Thread David Sterba
On Thu, Jan 04, 2024 at 12:49:58PM +0100, Jan Kara wrote: > On Sat 23-12-23 17:31:55, Matthew Wilcox wrote: > > On Thu, Dec 21, 2023 at 04:57:04PM +0800, Yu Kuai wrote: > > > @@ -3674,16 +3670,17 @@ struct btrfs_super_block > > > *btrfs_read_dev_one_super(struct block_device *bdev, > > >