hem from this
> week.
No rush :) I can also take some part of backport work.
Besides, some paper work are in queue as well...
Let's finish them and then release v2 patchset to the linux mailing list.
Thanks,
Gao Xiang
Hi Chao,
On 2018/6/30 7:45, Chao Yu wrote:
> On 2018/6/27 22:20, Gao Xiang wrote:
>> Signed-off-by: Gao Xiang
>> ---
>>
>> The patch is temporarily based on
>> [RFC PATCH RESEND 12/12] erofs: introduce VLE decompression support
>> (experimental)
>>
handle return value of
erofs_init_page_bundle() correctly"
and then apply the new patchset just as you said,
or
2) Introduce a new 'dev-test' branch as Jaegeuk Kim's branch.
Boths for me are ok. :)
Thanks,
Gao Xiang
Hi Chao,
On 2018/7/2 11:36, Chao Yu wrote:
> We can do both of them, let's treat erofs branch as master branch, and we can
> split erofs-dev branch (dev-test will not be so obvious to indicate that
> branch
> is belong to erofs, so let's use erofs-dev) from erofs branch for further
>
Signed-off-by: Gao Xiang
---
The patch is temporarily based on
[RFC PATCH RESEND 12/12] erofs: introduce VLE decompression support
(experimental)
STILL BUGGY, NOT FOR DAILY USE!
fs/erofs/Makefile|7 +-
fs/erofs/data.c | 189 +--
fs/erofs/inode.c |2
le makes automatic testing confused, I could use alternative way
to replace it in the next version.
Thanks for your caring and report. :)
Thanks,
Gao Xiang
> julia
>
> On Tue, 3 Jul 2018, kbuild test robot wrote:
>
>>
>> tree: https://git.kern
Hi Julia,
On 2018/7/3 15:13, Julia Lawall wrote:
>
> On Tue, 3 Jul 2018, Gao Xiang wrote:
>
>> Hi Julia,
>>
>> On 2018/7/3 13:27, Julia Lawall wrote:
>>> Hello,
>>>
>>> There is not actually a bug here, but I wonder if the backwards goto in
Signed-off-by: Gao Xiang
---
fs/erofs/internal.h | 3 +++
fs/erofs/utils.c| 31 +++
2 files changed, 34 insertions(+)
create mode 100644 fs/erofs/utils.c
diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
index d327de2..6d9a927 100644
--- a/fs/erofs
Signed-off-by: Gao Xiang
---
change log v0.3:
- separate to several small patches, maybe more in the future patchset
change log v0.2:
- use the recent introduced tagptr_t type to manage tagged pointers.
- bugfix
Todo list:
- spilt into more understandable patches
- add missing functions
Signed-off-by: Gao Xiang
---
fs/erofs/unzip_pagevec.h | 172 +++
1 file changed, 172 insertions(+)
create mode 100644 fs/erofs/unzip_pagevec.h
diff --git a/fs/erofs/unzip_pagevec.h b/fs/erofs/unzip_pagevec.h
new file mode 100644
index 000
Signed-off-by: Gao Xiang
---
fs/erofs/Kconfig | 8 ++
fs/erofs/Makefile| 1 +
fs/erofs/internal.h | 4 +
fs/erofs/unzip_vle.c | 231 +++
4 files changed, 244 insertions(+)
create mode 100644 fs/erofs/unzip_vle.c
diff --git a/fs
Signed-off-by: Gao Xiang
---
fs/erofs/data.c | 41 +
fs/erofs/internal.h | 41 +
2 files changed, 50 insertions(+), 32 deletions(-)
diff --git a/fs/erofs/data.c b/fs/erofs/data.c
index 9b30095..45ad829 100644
Signed-off-by: Gao Xiang
---
change log v0.2:
- use the recent introduced tagptr_t type to manage tagged pointers.
- bugfix
TODO:
- spilt into more understandable patches
- add missing functions and bugfix
The patchset is temporarily based on
[RFC PATCH RESEND 11/12] erofs: introduce
allocation.
Refer to:
https://en.wikipedia.org/wiki/Tagged_pointer
Signed-off-by: Gao Xiang
---
fs/file.c | 24 ++-
include/linux/file.h | 15 ---
include/linux/tagptr.h | 110 +
3 files changed, 133 insertions(+), 16
Signed-off-by: Gao Xiang
---
fs/erofs/Kconfig | 15 +
fs/erofs/Makefile| 2 +-
fs/erofs/internal.h | 5 ++
fs/erofs/unzip_vle.h | 34 +++
fs/erofs/unzip_vle_lz4.c | 145 +++
5 files changed, 200 insertions
Signed-off-by: Gao Xiang
---
fs/erofs/Makefile | 2 +-
fs/erofs/internal.h | 3 +++
fs/erofs/staging.h | 4
fs/erofs/utils.c| 31 +++
4 files changed, 39 insertions(+), 1 deletion(-)
create mode 100644 fs/erofs/utils.c
diff --git a/fs/erofs/Makefile b
Signed-off-by: Gao Xiang
---
fs/erofs/data.c | 41 +
fs/erofs/internal.h | 41 +
2 files changed, 50 insertions(+), 32 deletions(-)
diff --git a/fs/erofs/data.c b/fs/erofs/data.c
index 9b30095..45ad829 100644
Signed-off-by: Gao Xiang
---
fs/erofs/inode.c | 6 +-
fs/erofs/internal.h | 24 ++
fs/erofs/staging.h | 38 +++
fs/erofs/super.c | 36 +-
fs/erofs/unzip_vle.c | 947 ++-
fs/erofs/unzip_vle.h | 202 +++
6 files changed, 1248
On 2018/7/3 21:52, Chao Yu wrote:
> Hi Xiang,
>
> On 2018/7/3 17:44, Gao Xiang wrote:
>> Hi Chao,
>>
>> On 2018/6/22 10:01, Chao Yu wrote:
>>> Add tracepoints for ->readpage{,s}, ->lookup.
>>>
>>> Signed-off-by: Chao Yu
Signed-off-by: Chao Yu
Signed-off-by: Gao Xiang
---
fs/erofs/internal.h | 300
1 file changed, 300 insertions(+)
create mode 100644 fs/erofs/internal.h
diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
new file mode 100644
index 000
e released as
soon as
the internal process ends.
4) VLE decompression code still needs to do more optimization and cleanup.
Thanks,
Gao Xiang (12):
erofs: add on-disk layout
erofs: add erofs in-memory stuffs
erofs: add super block operations
erofs: add raw address_space operations
-by: Gao Xiang
---
fs/erofs/erofs_fs.h | 258
1 file changed, 258 insertions(+)
create mode 100644 fs/erofs/erofs_fs.h
diff --git a/fs/erofs/erofs_fs.h b/fs/erofs/erofs_fs.h
new file mode 100644
index 000..c08d982
--- /dev/null
+++ b/fs/erofs
will be used instead.
Signed-off-by: Miao Xie
Signed-off-by: Chao Yu
Signed-off-by: Gao Xiang
---
fs/erofs/Kconfig| 37 +++
fs/erofs/Makefile | 1 +
fs/erofs/inode.c| 61 +
fs/erofs/internal.h | 20 ++
fs/erofs/namei.c| 7 +
fs/erofs/super.c| 29 +++
fs/erofs/xattr.c
://groups.google.com/forum/#!topic/lz4c/_3kkz5N6n00
Therefore, I hacked the LZ4 decompression logic by hand,
probably NOT the fastest approach, and hope for better
implementation.
Signed-off-by: Gao Xiang
---
fs/erofs/lz4defs.h | 227 +++
fs/ero
This commit adds Makefile and Kconfig for erofs, and
updates Makefile and Kconfig files in the fs directory.
Signed-off-by: Miao Xie
Signed-off-by: Chao Yu
Signed-off-by: Gao Xiang
---
fs/Kconfig| 1 +
fs/Makefile | 1 +
fs/erofs/Kconfig | 34
(percpu buffer, memcpy) and
slow path(vmap, no memcpy), but we observed some issues from
the bad parts too.
In brief, some parts of this patch will be refactored
in the near future.
Signed-off-by: Miao Xie
Signed-off-by: Chao Yu
Signed-off-by: Gao Xiang
---
fs/erofs/Kconfig | 17 +
fs
This adds core functions to get, read an inode.
Signed-off-by: Miao Xie
Signed-off-by: Chao Yu
Signed-off-by: Gao Xiang
---
fs/erofs/inode.c | 222 +++
1 file changed, 222 insertions(+)
create mode 100644 fs/erofs/inode.c
diff --git a/fs
This adds functions for directory, mainly readdir.
Signed-off-by: Miao Xie
Signed-off-by: Chao Yu
Signed-off-by: Gao Xiang
---
fs/erofs/dir.c | 143 +
1 file changed, 143 insertions(+)
create mode 100644 fs/erofs/dir.c
diff --git a/fs
for test only
--
Linux-erofs mailing list
Linux-erofs@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linux-erofs
--
Linux-erofs mailing list
Linux-erofs@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linux-erofs
This fixes compiling errors built with:
config: parisc-allmodconfig (attached as .config)
compiler: hppa-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
Reported-by: kbuild test robot
Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Signed-off-by: Chao Yu
---
fs/erofs/data.c | 1 +
fs/erofs/unzip.c | 1
configuration test 3
--
Linux-erofs mailing list
Linux-erofs@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linux-erofs
--
Linux-erofs mailing list
Linux-erofs@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linux-erofs
--
Linux-erofs mailing list
Linux-erofs@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linux-erofs
test ok.
On 2018/6/22 13:40, Gao Xiang wrote:
--
Linux-erofs mailing list
Linux-erofs@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linux-erofs
On 2018/7/28 15:25, Greg Kroah-Hartman wrote:
> Thanks for submitting this, the filesystem looks very interesting. I've
> queued it all up now in the staging-next tree.
Thanks for applying, we are continuously optimizing further and hope to attract
more fs guys :)
Thanks,
Gao Xiang
There is a type mismatch in the definition of
Z_EROFS_VLE_VMAP_ONSTACK_PAGES, let's fix it.
Link: https://lists.01.org/pipermail/kbuild-all/2018-July/050707.html
Reported-by: kbuild test robot
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/unzip_vle.h | 2 +-
1 file changed, 1 insertion
Hi Greg,
On 2018/8/3 1:33, Greg KH wrote:
> Sorry, I already took the first version in my tree. Don't worry about
> it for now you can fix this up after 4.19-rc1 is out when we enable the
> filesystem again.
>
OK, We will fix it and enable erofs after 4.19-rc1 is out. :)
Thank
Hi Matthew,
On 2018/7/30 21:19, Matthew Wilcox wrote:
>
> This review looks pretty external now ...
>
:-'( Internal means currently in the linux-erofs mailing list for preview.
I haven't sent to the linux-kernel mailing list yet..
> On Mon, Jul 30, 2018 at 05:18:30PM +0800, Gao
Hi Chao,
On 2018/7/30 10:07, Chao Yu wrote:
> On 2018/7/29 13:34, Gao Xiang via Linux-erofs wrote:
>> This patch fixes incorrect code snippets due to spilt code
>> into small patches by mistake.
>>
>> Link: https://lists.01.org/pipermail/kbuild-all/2018-July/050747.htm
From: Gao Xiang
This patch also fixes out-of-date code snippets due to spilt code
into small patches by mistake.
Signed-off-by: Gao Xiang
---
RESEND:
- spilt into two patches according to Chao's suggestion
drivers/staging/erofs/internal.h | 4 ++--
drivers/staging/erofs/super.c | 2
From: Gao Xiang
This patch actually fixes incorrect code snippets due to spilt code
into small patches by mistake, which can cause a compile error without
built-in decompression support and potential abnormal runtime shrinking.
Link: https://lists.01.org/pipermail/kbuild-all/2018-July/050747
This patch introduces an iterable L2P mapping
operation 'erofs_map_blocks_iter'.
Compared with 'erofs_map_blocks', it avoids
a number of redundant 'release and regrab'
processes if they request the same meta page.
Signed-off-by: Gao Xiang
---
v2 RESEND:
- fix undefined reference to `__udivmoddi4
pleted.
Link: https://groups.google.com/forum/#!topic/lz4c/_3kkz5N6n00
Therefore, I hacked the LZ4 decompression logic by hand,
probably NOT the fastest approach, and hope for better
implementation.
Signed-off-by: Miao Xie
Signed-off-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/ero
-by: Gao Xiang
---
drivers/staging/erofs/erofs_fs.h | 266 +++
1 file changed, 266 insertions(+)
create mode 100644 drivers/staging/erofs/erofs_fs.h
diff --git a/drivers/staging/erofs/erofs_fs.h b/drivers/staging/erofs/erofs_fs.h
new file mode 100644
index 000
ure
staging: erofs: support tracepoint
Gao Xiang (22):
staging: erofs: add on-disk layout
staging: erofs: add erofs in-memory stuffs
staging: erofs: add super block operations
staging: erofs: add raw address_space operations
staging: erofs: add inode operations
staging: erofs: add direct
In order to introducing shrinker solution for erofs,
let's manage all mounted erofs instances at first.
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/internal.h | 6 ++
drivers/staging/erofs/super.c| 4
drivers/staging/erofs/utils.c| 17 +
3 files changed
The unzip subsystem also uses these functions,
let's export them to internal.h.
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/data.c | 34 +-
drivers/staging/erofs/internal.h | 33 +
2 files changed, 42 insertions(+), 25
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/internal.h | 7
drivers/staging/erofs/super.c| 15 +++
drivers/staging/erofs/utils.c| 85 +---
3 files changed, 101 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/erofs/intern
sed independently, which ensures
random read number for all use cases.
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/inode.c |5 +
drivers/staging/erofs/internal.h |6 +
drivers/staging/erofs/super.c | 25 +
drivers/staging/erofs/unzip_vle.c | 1119
will be used instead.
Signed-off-by: Miao Xie
Signed-off-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/Kconfig| 37 +++
drivers/staging/erofs/Makefile | 1 +
drivers/staging/erofs/inode.c| 33 ++-
drivers/staging/erofs/internal.h | 22 ++
drivers/staging/erofs
From: Chao Yu
This patch adds to support special inode, such as block dev, char,
socket, pipe inode.
Reviewed-by: Gao Xiang
Signed-off-by: Chao Yu
---
drivers/staging/erofs/inode.c| 36 ++--
drivers/staging/erofs/internal.h | 1 +
2 files changed, 35
This patch adds an optional choice which can be
enabled by users in order to cache both incomplete
ends of compressed clusters as a complement to
the in-place decompression in order to boost random
read, but it costs more memory than the in-place
decompression only.
Signed-off-by: Gao Xiang
This patch introduces an iterable L2P mapping
operation 'erofs_map_blocks_iter'.
Compared with 'erofs_map_blocks', it avoids
a number of redundant 'release and regrab'
processes if they request the same meta page.
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/Kconfig | 10 ++
drivers
allocation.
Link: https://en.wikipedia.org/wiki/Tagged_pointer
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/include/linux/tagptr.h | 110 +++
1 file changed, 110 insertions(+)
create mode 100644 drivers/staging/erofs/include/linux/tagptr.h
diff --git a/drivers
From: Chao Yu
Add basic tracepoints for ->readpage{,s}, ->lookup,
->destroy_inode, fill_inode and map_blocks.
Reviewed-by: Gao Xiang
Signed-off-by: Chao Yu
---
drivers/staging/erofs/data.c | 13 +-
drivers/staging/erofs/include/trace/events/erof
-by: Gao Xiang
Signed-off-by: Chao Yu
---
drivers/staging/erofs/Kconfig| 6 +
drivers/staging/erofs/inode.c| 3 ++-
drivers/staging/erofs/internal.h | 57
drivers/staging/erofs/super.c| 38 +++
4 files changed, 103
This commit adds Makefile and Kconfig for erofs, and
updates Makefile and Kconfig files in the fs directory.
Signed-off-by: Miao Xie
Signed-off-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/Kconfig| 2 ++
drivers/staging/Makefile | 1 +
drivers/staging/erofs/Kconfig
This commit adds functions for meta and raw data, and also
provides address_space_operations for raw data access.
Signed-off-by: Miao Xie
Signed-off-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/data.c | 362 +++
1 file changed, 362
This commit adds erofs super block operations, including (u)mount,
remount_fs, show_options, statfs, in addition to some private
icache management functions.
Signed-off-by: Miao Xie
Signed-off-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/super.c | 415
Signed-off-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/internal.h | 281 +++
1 file changed, 281 insertions(+)
create mode 100644 drivers/staging/erofs/internal.h
diff --git a/drivers/staging/erofs/internal.h b/drivers/staging/erofs/internal.h
This commit adds functions that transfer names to inodes.
Signed-off-by: Miao Xie
Signed-off-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/namei.c | 243 ++
1 file changed, 243 insertions(+)
create mode 100644 drivers/staging/erofs
This adds functions for directory, mainly readdir.
Signed-off-by: Miao Xie
Signed-off-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/dir.c | 145
1 file changed, 145 insertions(+)
create mode 100644 drivers/staging/erofs/dir.c
This adds core functions to get, read an inode.
Signed-off-by: Miao Xie
Signed-off-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/inode.c | 210 ++
1 file changed, 210 insertions(+)
create mode 100644 drivers/staging/erofs/inode.c
diff
Currently, this patch only simply implements LZ4
decompressor due to its development priority.
In the future, erofs will support more compression
algorithm and format other than LZ4, thus a generic
decompressor interface will be needed.
Signed-off-by: Gao Xiang
---
drivers/staging/erofs
-off-by: Gao Xiang
---
drivers/staging/erofs/internal.h | 93
drivers/staging/erofs/super.c| 9
drivers/staging/erofs/utils.c| 81 --
3 files changed, 180 insertions(+), 3 deletions(-)
diff --git a/drivers/staging
pleted.
Link: https://groups.google.com/forum/#!topic/lz4c/_3kkz5N6n00
Therefore, I hacked the LZ4 decompression logic by hand,
probably NOT the fastest approach, and hope for better
implementation.
Signed-off-by: Miao Xie
Signed-off-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/ero
for booting the whole array itself up will be needed.
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/unzip_pagevec.h | 172 ++
1 file changed, 172 insertions(+)
create mode 100644 drivers/staging/erofs/unzip_pagevec.h
diff --git a/drivers/staging/erofs
this patch renames prepare_bio to erofs_grab_bio, and
adds a nofail option in order to retry in the bio allocator.
Reported-by: Stephen Rothwell
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/data.c | 12 ++--
drivers/staging/erofs/internal.h | 35
There is no need to '#if CONFIG_EROFS_FS_XATTR' in xattr.c,
let's remove it.
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/xattr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/erofs/xattr.c b/drivers/staging/erofs/xattr.c
index b74b314..6b9685f 100644
--- a/drivers
This patch enhances the missing error handling code for
xattr submodule, which improves the stability for the rare cases.
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/xattr.c | 114 --
1 file changed, 77 insertions(+), 37 deletions(-)
diff --git
This patch seperates 'erofs_get_meta_page' into 'erofs_get_meta_page'
and 'erofs_get_meta_page_nofail'. The second one ensures it should not
fail due to memory pressure.
It also adds const variables in order to fulfill 80 character limit.
Signed-off-by: Gao Xiang
---
drivers/staging/erofs
This patch adds a missing break after adding the default case.
Reviewed-by: Chao Yu
Signed-off-by: Gao Xiang
---
Hi Greg,
There are two erofs bugfix & cleanup patches ready for staging-next upstream.
The original preview thread:
https://lists.ozlabs.org/pipermail/linux-erofs/2018-July/00
There is no need to '#if CONFIG_EROFS_FS_XATTR' in xattr.c,
let's remove it.
Reviewed-by: Chao Yu
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/xattr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/erofs/xattr.c b/drivers/staging/erofs/xattr.c
index b74b314..6b9685f
There is an extra semicolon in z_erofs_vle_unzip_all, remove it.
Reported-by: Julia Lawall
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/unzip_vle.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/erofs/unzip_vle.c
b/drivers/staging/erofs/unzip_vle.c
This patch adds a missing break after adding the default case.
Reviewed-by: Chao Yu
Signed-off-by: Gao Xiang
---
As pointed out by Dan Carpenter:
- fix the wrong place of fallthrough comments
drivers/staging/erofs/unzip_vle.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers
vers/staging/erofs/super.c?h=erofs-dev
https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git/tree/drivers/staging/erofs/inode.c?h=erofs-dev
It will be of great help...Thank you..
Thanks,
Gao Xiang
> Thanks,
>
> On 2018/7/30 17:18, Gao Xiang wrote:
>> This patch updates .
no code changes,
but the following patches will be upstreamed as we disscussed this morning...)
And could you review '[PATCH] staging: erofs: use the wrapped PTR_ERR_OR_ZERO
instead of open code'
I just sent in the morning?
Thanks,
Gao Xiang
After commit 0a43a939c77e ("vfs: Suppress MS_* flag defs within
the kernel unless explicitly enabled"), there is no MS_RDONLY
and MS_NOATIME at all.
Reported-by: Stephen Rothwell
Signed-off-by: Gao Xiang
---
- Tested with images generated by mkfs.erofs:
1) mount and unmount opera
Signed-off-by: Gao Xiang
---
- Tested with images generated by mkfs.erofs:
1) mount and unmount operations
2) md5sum `find . -type f`
drivers/staging/erofs/utils.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/erofs/utils.c b/drive
This patch adds a missing break after adding the default case.
Signed-off-by: Gao Xiang
---
- Tested with images generated by mkfs.erofs:
1) mount and unmount operations
2) md5sum `find . -type f`
drivers/staging/erofs/unzip_vle.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions
This patch updates .mount and .remount_sb after
commit 286c6b145729 ("vfs: Require specification
of size of mount data for internal mounts").
Reported-by: Stephen Rothwell
Signed-off-by: Gao Xiang
---
- Tested with images generated by mkfs.erofs:
1) mount and unmount operations
Hi Chao,
On 2018/8/6 9:58, Chao Yu wrote:
> Hi Xiang,
>
> On 2018/8/6 9:27, Gao Xiang wrote:
>> Hi Jiang,
>>
>> On 2018/8/5 21:57, zhong jiang wrote:
>>> That semicolons are unneeded, JUst remove them.
>>>
>>> Signed-off-by: zhong jian
On 2018/8/6 10:11, zhong jiang wrote:
> On 2018/8/6 9:27, Gao Xiang wrote:
>> Hi Jiang,
>>
>> On 2018/8/5 21:57, zhong jiang wrote:
>>> That semicolons are unneeded, JUst remove them.
>>>
>>> Signed-off-by: zhong jiang
>> Thanks for yo
There is an extra semicolon in z_erofs_vle_unzip_all, remove it.
Reported-by: Julia Lawall
Signed-off-by: zhong jiang
Signed-off-by: Gao Xiang
---
changelog v2:
- zhong jiang also submits this fix, add
'Signed-off-by: zhong jiang '
drivers/staging/erofs/unzip_vle.c | 2 +-
1 file changed
This patch fixes a missing endian conversion in
vle_get_logical_extent_head.
Signed-off-by: Gao Xiang
---
change log v3:
- spilt into small patches at Chao's suggestion.
drivers/staging/erofs/unzip_vle.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers
This patch adds error handing code, and fixes a missing
endian conversion in vle_decompressed_index_clusterofs.
Signed-off-by: Gao Xiang
---
change log v2:
- change the commit message;
- I personally think this patch is clear enough, therefore I don't
spilt into more small patches
Logical address of EOF LTP mapping should start at
`inode->i_size' rather than `inode->i_size - 1' to
`m_la(in) + 1 - inode->i_size', fix it.
Signed-off-by: Gao Xiang
---
change log v3:
- spilt into small patches at Chao's suggestion.
drivers/staging/erofs/unzip_vle.c | 2 +-
1 fil
This patch completes error handing code of z_erofs_do_read_page.
PG_error will be set when some read error happens, therefore
z_erofs_onlinepage_endio will unlock this page without setting
PG_uptodate.
Signed-off-by: Gao Xiang
---
change log v2:
- spilt into small patches at Chao's suggestion
in erofs compression ondisk format.
Signed-off-by: Gao Xiang
---
change log v3:
- spilt into small patches at Chao's suggestion.
drivers/staging/erofs/unzip_vle.c | 139 +-
1 file changed, 77 insertions(+), 62 deletions(-)
diff --git a/drivers/staging/erofs
to cache the last compressed pack.
caching strategy should work properly after appling this patch.
Signed-off-by: Gao Xiang
---
change log v2:
- spilt into small patches at Chao's suggestion.
drivers/staging/erofs/unzip_vle.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This patch completes error handing of z_erofs_map_blocks_iter
and vle_get_logical_extent_head, including no memory and
io error cases.
Signed-off-by: Gao Xiang
---
change log v3:
- spilt into small patches at Chao's suggestion.
drivers/staging/erofs/unzip_vle.c | 35
This patch enhances the missing error handling code for
xattr submodule, which improves the stability for the rare cases.
Signed-off-by: Gao Xiang
---
change log v3:
- avoid all nofail usage according to Chao's suggestion;
- remove all 'unlikely' hints together with IS_ERR.
drivers/staging
This patch cleanups z_erofs_map_blocks_iter and
vle_get_logical_extent_head, including adding
error handing code and missing endian conversions.
Signed-off-by: Gao Xiang
---
change log v2:
- fix lcn overflow issue on 32-bit platforms
drivers/staging/erofs/unzip_vle.c | 146
When the managed cache is enabled, the last reference count
of a workgroup should be used for its workstation.
Otherwise, (un)freeze in the reclaim path will work improperly.
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/utils.c | 57 +--
1 file
in z_erofs_vle_unzip should be dropped.
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/unzip_vle.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/erofs/unzip_vle.c
b/drivers/staging/erofs/unzip_vle.c
index 1d0ffa6..6e5c24d 100644
--- a/drivers/staging/erofs/unzip_vle.c
+++ b/drivers
Since the reference count of an erofs_workgroup is a signed atomic
integer, fix a refcount assertion in erofs_register_workgroup.
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/erofs/utils.c b
This patch introduces 'struct z_erofs_vle_work_finder' to clean up
arguments of z_erofs_vle_work_lookup and z_erofs_vle_work_register.
Reviewed-by: Chao Yu
Signed-off-by: Gao Xiang
---
RESEND:
- add `Reviewed-by: Chao Yu '
- no logic change
drivers/staging/erofs/unzip_vle.c | 89
Hi Chao,
Could you please review again these `[PREVIEW]' patches are OK...
And could help send to staging mailing list and LKML when you are free...
Thanks in advance...
Thanks,
Gao Xiang
Hi Chao,
(sorry about the email client...)
Could you please review again these `[PREVIEW]' patches are OK...
And could help send to staging mailing list and LKML when you are free...
Thanks in advance...
Thanks,
Gao Xiang
1 - 100 of 3499 matches
Mail list logo
