On Thu, Aug 31, 2023 at 07:29:53PM +0800, Gao Xiang wrote:
> commit e4c1cf523d820730a86cae2c6d55924833b6f7ac upstream.
>
> This was accidentally fixed up in commit e4c1cf523d82 but we can't
> take the full change due to other dependancy issues, so here is just
> the actual bugfix that is needed.
On Fri, Jul 21, 2023 at 10:22:21AM +0800, Gao Xiang wrote:
> commit 001b8ccd0650727e54ec16ef72bf1b8eeab7168e upstream.
>
> In compact 4B, two adjacent lclusters are packed together as a unit to
> form on-disk indexes for effective random access, as below:
>
> (amortized = 4, vcnt = 2)
>
From: David Howells
[ Upstream commit 6c77676645ad42993e0a8bdb8dafa517851a352a ]
The maths at the end of iter_xarray_get_pages() to calculate the actual
size doesn't work under some circumstances, such as when it's been asked to
extract a partial single page. Various terms of the equation
From: David Howells
[ Upstream commit 6c77676645ad42993e0a8bdb8dafa517851a352a ]
The maths at the end of iter_xarray_get_pages() to calculate the actual
size doesn't work under some circumstances, such as when it's been asked to
extract a partial single page. Various terms of the equation
From: David Howells
[ Upstream commit 6c77676645ad42993e0a8bdb8dafa517851a352a ]
The maths at the end of iter_xarray_get_pages() to calculate the actual
size doesn't work under some circumstances, such as when it's been asked to
extract a partial single page. Various terms of the equation
On Tue, Nov 16, 2021 at 09:08:18AM +0800, Gao Xiang wrote:
> From: Yue Hu
>
> commit 7dea3de7d384f4c8156e8bd93112ba6db1eb276c upstream.
>
> No any behavior to variable occupied in z_erofs_attach_page() which
> is only caller to z_erofs_pagevec_enqueue().
>
> Link:
On Mon, Apr 26, 2021 at 04:29:33PM +0800, Gao Xiang wrote:
> commit 0dcd3c94e02438f4a571690e26f4ee997524102a upstream.
>
> Each ondisk inode should be aligned with inode slot boundary
> (32-byte alignment) because of nid calculation formula, so all
> compact inodes (32 byte) cannot across page
On Tue, Apr 14, 2020 at 11:38:20PM +0800, Gao Xiang wrote:
> From: Gao Xiang
>
> commit 9d5a09c6f3b5fb85af20e3a34827b5d27d152b34 upstream.
>
> The remaining count should not include successful
> shrink attempts.
>
> Fixes: e7e9a307be9d ("staging: erofs: introduce workstation for
>
dly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take
On Mon, Aug 19, 2019 at 10:57:42PM +0800, Chao Yu wrote:
> On 2019-8-19 18:34, Gao Xiang wrote:
> > As reported by erofs-utils fuzzer, currently, multiref
> > (ondisk deduplication) hasn't been supported for now,
> > we should forbid it properly.
> >
> > Fixes: 3883a79abd02 ("staging: erofs:
On Sun, Aug 18, 2019 at 11:03:53AM +0200, Richard Weinberger wrote:
> - Ursprüngliche Mail -
> > I agree with you, but what can we do now is trying our best to fuzz
> > all the fields.
> >
> > So, what is your opinion about EROFS?
>
> All I'm saying is that you should not blindly trust
On Thu, Aug 15, 2019 at 12:41:31PM +0800, Gao Xiang wrote:
> [I strip the previous cover letter, the old one can be found in v6:
> https://lore.kernel.org/r/20190802125347.166018-1-gaoxian...@huawei.com/]
>
> We'd like to submit a formal moving patch applied to staging tree
> for 5.4, before
On Mon, Jul 29, 2019 at 02:51:38PM +0800, Gao Xiang wrote:
> - Use the correct style for all SPDX License Identifiers;
> - Get rid of the unnecessary license boilerplate;
> - Use "GPL-2.0-only" instead of "GPL-2.0" suggested-by Stephen.
Note, either tag works just fine, they are identical. I'll
On Mon, Jul 22, 2019 at 01:26:16PM +1000, Stephen Rothwell wrote:
> Hi Gao,
>
> On Mon, 22 Jul 2019 10:50:20 +0800 Gao Xiang wrote:
> >
> > diff --git a/fs/erofs/erofs_fs.h b/fs/erofs/erofs_fs.h
> > new file mode 100644
> > index ..e418725abfd6
> > --- /dev/null
> > +++
On Thu, Jul 04, 2019 at 10:00:53PM +0800, Gao Xiang wrote:
> Hi Greg,
>
> On 2019/7/4 21:50, Greg Kroah-Hartman wrote:
> > On Thu, Jul 04, 2019 at 09:34:13PM +0800, Gao Xiang wrote:
> >> EROFS file system has been in Linux-staging for about a year.
> >> It ha
On Thu, Jul 04, 2019 at 09:34:13PM +0800, Gao Xiang wrote:
> EROFS file system has been in Linux-staging for about a year.
> It has been proved to be stable enough to move out of staging
> by 10+ millions of HUAWEI Android mobile phones on the market
> from EMUI 9.0.1, and it was promoted as one
On Tue, Jun 18, 2019 at 02:18:00PM +0800, Gao Xiang wrote:
>
>
> On 2019/6/18 13:47, Greg Kroah-Hartman wrote:
> > On Tue, Jun 18, 2019 at 09:47:08AM +0800, Gao Xiang wrote:
> >>
> >>
> >> On 2019/6/18 4:36, Greg Kroah-Hartman wrote:
> >>&g
On Tue, Jun 18, 2019 at 09:47:08AM +0800, Gao Xiang wrote:
>
>
> On 2019/6/18 4:36, Greg Kroah-Hartman wrote:
> > On Sat, Jun 15, 2019 at 02:16:11AM +0800, Gao Xiang wrote:
> >> At last, this is RFC patch v1, which means it is not suitable for
> >>
On Sat, Jun 15, 2019 at 02:16:11AM +0800, Gao Xiang wrote:
> At last, this is RFC patch v1, which means it is not suitable for
> merging soon... I'm still working on it, testing its stability
> these days and hope these patches get merged for 5.3 LTS
> (if 5.3 is a LTS version).
Why would 5.3 be
On Mon, Apr 01, 2019 at 02:53:08PM +0800, Gao Xiang wrote:
> commit b6391ac73400eff38377a4a7364bd3df5efb5178 upstream.
>
> Complete read error handling paths for all three kinds of
> compressed pages:
>
> 1) For cache-managed pages, PG_uptodate will be checked since
> read_endio will unlock
On Mon, Mar 18, 2019 at 03:26:34PM +0800, Gao Xiang wrote:
> commit 51232df5e4b268936beccde5248f312a316800be upstream.
>
> When the managed cache is enabled, the last reference count
> of a workgroup must be used for its workstation.
>
> Otherwise, it could lead to incorrect (un)freezes in
> the
On Mon, Mar 11, 2019 at 02:08:54PM +0800, Gao Xiang wrote:
> commit cadf1ccf1b0021d0b7a9347e102ac5258f9f98c8 upstream.
>
> This patch enhances the missing error handling code for
> xattr submodule, which improves the stability for the rare cases.
>
> Reviewed-by: Chao Yu
> Signed-off-by: Chao
On Mon, Mar 11, 2019 at 10:29:32AM +0800, Gao Xiang wrote:
> commit af692e117cb8cd9d3d844d413095775abc1217f9 upstream.
>
> This patch resolves the following page use-after-free issue,
> z_erofs_vle_unzip:
> ...
> for (i = 0; i < nr_pages; ++i) {
> ...
>
On Mon, Mar 11, 2019 at 10:29:31AM +0800, Gao Xiang wrote:
> commit 419d6efc50e94bcf5d6b35cd8c71f79edadec564 upstream.
>
> As Al pointed out, "
> ... and while we are at it, what happens to
> unsigned int nameoff = le16_to_cpu(de[mid].nameoff);
> unsigned int matched = min(startprfx,
On Mon, Mar 11, 2019 at 10:40:23AM +0800, Gao Xiang wrote:
> commit 419d6efc50e94bcf5d6b35cd8c71f79edadec564 upstream.
>
> As Al pointed out, "
> ... and while we are at it, what happens to
> unsigned int nameoff = le16_to_cpu(de[mid].nameoff);
> unsigned int matched = min(startprfx,
On Mon, Feb 25, 2019 at 07:25:48AM -0800, Matthew Wilcox wrote:
> On Mon, Feb 25, 2019 at 04:04:49PM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Feb 20, 2019 at 05:18:48PM +0800, Gao Xiang wrote:
> > > commit 51232df5e4b268936beccde5248f312a316800be upstream.
> > > Upd
On Mon, Feb 25, 2019 at 11:07:19PM +0800, Gao Xiang wrote:
>
>
> On 2019/2/25 23:04, Greg Kroah-Hartman wrote:
> > On Wed, Feb 20, 2019 at 05:18:48PM +0800, Gao Xiang wrote:
> >> commit 51232df5e4b268936beccde5248f312a316800be upstream.
> >>
> >> W
On Wed, Feb 20, 2019 at 05:18:42PM +0800, Gao Xiang wrote:
> This series backports bugfixes already merged in linux upstream
> which we found these issues in our commerical products, which
> are serious and should be fixed immediately.
>
> Note that it also includes some xarray modification since
On Fri, Feb 22, 2019 at 11:46:30PM +0800, Gao Xiang wrote:
> This series backports bugfixes already merged in linux upstream
> which we found these issues in our commercial products, which
> are serious and should be fixed immediately.
>
> Note that it also includes some xarray modification since
freeze constraint.
>
> Reviewed-by: Chao Yu
> Signed-off-by: Gao Xiang
> Signed-off-by: Greg Kroah-Hartman
> Signed-off-by: Gao Xiang
>
> Conflicts:
> drivers/staging/erofs/utils.c
> Updates:
> include/linux/xarray.h:
> add xa_un
dio will unlock this page without setting
> PG_uptodate.
>
> Reviewed-by: Chao Yu
> Signed-off-by: Gao Xiang
> Signed-off-by: Greg Kroah-Hartman
>
> Conflicts:
> drivers/staging/erofs/unzip_vle.c
These types of lines are not needed in backports, they just are clutter.
I'll go fix it up...
greg k-h
On Wed, Feb 20, 2019 at 05:18:42PM +0800, Gao Xiang wrote:
> This series backports bugfixes already merged in linux upstream
> which we found these issues in our commerical products, which
> are serious and should be fixed immediately.
>
> Note that it also includes some xarray modification since
On Wed, Feb 20, 2019 at 10:38:53AM +0800, Gao Xiang wrote:
> Hi Greg,
>
> Could you consider take some time on these two patches for linux-5.1-rc1?
> 1) staging: erofs: fix race of initializing xattrs of a inode at the same
> time
> 2) staging: erofs: remove rcu_read_lock() in
On Mon, Jan 07, 2019 at 06:25:14PM +, Jeremy Sowden wrote:
> Fixes for -Wmissing-prototype warnings in the erofs driver. One group of
> functions have been made static; for the second, prototypes have been moved
> to a
> head
>
> Jeremy Sowden (2):
> staging: erofs: fixed
On Thu, Nov 22, 2018 at 09:01:31PM +0800, Gao Xiang wrote:
> Hi Greg,
>
> On 2018/11/22 20:00, Gao Xiang wrote:
> > Hi Greg,
> >
> > On 2018/11/22 19:26, Greg Kroah-Hartman wrote:
> >> Don't make people rebuild your code with different options for
&
On Thu, Nov 22, 2018 at 08:41:15PM +0800, Gao Xiang wrote:
> Hi Greg,
>
> On 2018/11/22 20:26, Greg Kroah-Hartman wrote:
> > Ugh, every page? Ok, nevermind, I take back my objections. You all are
> > crazy and need to do crazy things like this :)
>
> ...Do you have
On Thu, Nov 22, 2018 at 07:43:50PM +0800, Gao Xiang wrote:
> Hi Greg,
>
> On 2018/11/22 19:06, Greg Kroah-Hartman wrote:
> > On Thu, Nov 22, 2018 at 06:42:52PM +0800, Gao Xiang wrote:
> >> Hi Greg,
> >>
> >> On 2018/11/22 18:17, Greg Kroah-Hartma
On Thu, Nov 22, 2018 at 07:11:08PM +0800, Gao Xiang wrote:
> Hi Greg,
>
> On 2018/11/22 19:05, Greg Kroah-Hartman wrote:
> > On Thu, Nov 22, 2018 at 06:34:10PM +0800, Gao Xiang wrote:
> >> Hi Greg,
> >>
> >> On 2018/11/22 18:23, Greg Kroah-Hartman wrot
On Thu, Nov 22, 2018 at 06:42:52PM +0800, Gao Xiang wrote:
> Hi Greg,
>
> On 2018/11/22 18:17, Greg Kroah-Hartman wrote:
> > Any specific reason why you are not using the refcount.h api instead of
> > "doing it yourself" with atomic_inc/dec()?
> >
>
On Thu, Nov 22, 2018 at 06:29:34PM +0800, Gao Xiang wrote:
> Hi Greg,
>
> On 2018/11/22 18:21, Greg Kroah-Hartman wrote:
> > On Tue, Nov 20, 2018 at 10:34:19PM +0800, Gao Xiang wrote:
> >> There are two minor issues in the current freeze interface:
> >>
On Thu, Nov 22, 2018 at 06:34:10PM +0800, Gao Xiang wrote:
> Hi Greg,
>
> On 2018/11/22 18:23, Greg Kroah-Hartman wrote:
> >> +
> >> + DBG_BUGON(work->nr_pages);
> >> + DBG_BUGON(work->vcnt);
> > How can these ever be triggered? I understand the
On Thu, Nov 22, 2018 at 06:29:34PM +0800, Gao Xiang wrote:
> Hi Greg,
>
> On 2018/11/22 18:21, Greg Kroah-Hartman wrote:
> > On Tue, Nov 20, 2018 at 10:34:19PM +0800, Gao Xiang wrote:
> >> There are two minor issues in the current freeze interface:
> >>
On Thu, Nov 22, 2018 at 06:49:53PM +0800, Gao Xiang wrote:
> Hi Greg,
>
> On 2018/11/22 18:19, Greg Kroah-Hartman wrote:
> > On Tue, Nov 20, 2018 at 10:34:16PM +0800, Gao Xiang wrote:
> >> `trace_erofs_readpage' should be placed in .readpage()
> >
On Tue, Nov 20, 2018 at 10:34:23PM +0800, Gao Xiang wrote:
> Let's make sure that the one registering a workgroup will also
> take the primary work lock at first for two reasons:
> 1) There's no need to introduce such a race window (and consequently
> overhead) between registering and
On Tue, Nov 20, 2018 at 10:34:22PM +0800, Gao Xiang wrote:
> `z_erofs_vle_workgroup' is heavily generated in the decompression,
> for example, it resets 32 bytes redundantly for 64-bit platforms
> even through Z_EROFS_VLE_INLINE_PAGEVECS + Z_EROFS_CLUSTER_MAX_PAGES,
> default 4, pages are stored
On Tue, Nov 20, 2018 at 10:34:19PM +0800, Gao Xiang wrote:
> There are two minor issues in the current freeze interface:
>
>1) Freeze interfaces have not related with CONFIG_DEBUG_SPINLOCK,
> therefore fix the incorrect conditions;
>
>2) For SMP platforms, it should also disable
On Tue, Nov 20, 2018 at 10:34:18PM +0800, Gao Xiang wrote:
> It's better to use atomic_cond_read_relaxed, which is implemented
> in hardware instructions to monitor a variable changes currently
> for ARM64, instead of open-coded busy waiting.
>
> Reviewed-by: Chao Yu
> Signed-off-by: Gao Xiang
On Tue, Nov 20, 2018 at 10:34:16PM +0800, Gao Xiang wrote:
> `trace_erofs_readpage' should be placed in .readpage()
> rather than in the internal `z_erofs_do_read_page'.
Why? What happens with the code today?
>
> Fixes: 284db12cfda3 ("staging: erofs: add trace points for reading zipped
>
On Tue, Nov 20, 2018 at 10:34:17PM +0800, Gao Xiang wrote:
> When the managed cache is enabled, the last reference count
> of a workgroup must be used for its workstation.
>
> Otherwise, it could lead to incorrect (un)freezes in
> the reclaim path, and it would be harmful.
>
> A typical race as
On Tue, Nov 20, 2018 at 10:34:17PM +0800, Gao Xiang wrote:
> When the managed cache is enabled, the last reference count
> of a workgroup must be used for its workstation.
>
> Otherwise, it could lead to incorrect (un)freezes in
> the reclaim path, and it would be harmful.
>
> A typical race as
On Tue, Nov 13, 2018 at 12:31:58AM +0100, Cristian Sicilia wrote:
> On Mon, Nov 12, 2018 at 11:46 PM Greg Kroah-Hartman <
> gre...@linuxfoundation.org> wrote:
>
> > On Mon, Nov 12, 2018 at 09:43:57PM +0100, Cristian Sicilia wrote:
> > > Replace equal to
On Mon, Nov 12, 2018 at 09:43:57PM +0100, Cristian Sicilia wrote:
> Replace equal to NULL with logic unary operator,
> and removing not equal to NULL comparison.
>
> Signed-off-by: Cristian Sicilia
> ---
> drivers/staging/erofs/unzip_vle.c | 86
> +++
> 1
On Mon, Nov 05, 2018 at 12:35:03PM +, Bhagyashri P. Dighole wrote:
> Fix coding style alignment issues detected by checkpatch.pl
> Use ! for NULL test rather than explicitly comparing to NULL.
>
> Signed-off-by: Bhagyashri P. Dighole
> ---
> drivers/staging/erofs/data.c | 14 +++---
On Mon, Oct 08, 2018 at 10:36:39PM +0800, Gao Xiang wrote:
> Hi Greg,
>
> On 2018/10/8 22:22, Greg Kroah-Hartman wrote:
> > Why delete that line?
> >
> > But wait, why do we even have this file at all? What's wrong with the
> > lib/lz4/ code that we have in the
On Mon, Oct 08, 2018 at 04:14:09PM +0200, Loic Tourlonias wrote:
> Add SPDX identifier to simplify header and remove whole license text
>
> v1 -> v2:
>
> Move SPDX identifier to first line and change comment delimiter
The "changes" need to go below the --- line.
>
> Signed-off-by: Loic
On Tue, Sep 18, 2018 at 08:02:30PM +0800, Gao Xiang wrote:
> Hi Greg,
>
> On 2018/9/18 19:19, Greg Kroah-Hartman wrote:
> > On Fri, Sep 14, 2018 at 10:40:22PM +0800, Gao Xiang wrote:
> >> In order to avoid conflicts with cleanup patches, Chao and I think
> >> it i
On Sun, Sep 02, 2018 at 03:45:01PM +0530, Nitin Gupta wrote:
> Hi Greg
>
> i am working on some project which is having huge changes and working
> on kernel-2.6.32-131.696
> it will be very difficult to back port them into 4.8 .
Why 4.8? That too is a totally unsupported kernel version.
On Fri, Aug 31, 2018 at 11:22:06PM +0530, Nitin Gupta wrote:
> Hi Greg
>
> Thanks for your comments but somehow i cant use the latest kernel .
Why not? What is not working properly for you? It will be easier to
fix that than to work with a crazy half-backported mess that you will be
the sole
zip_vle_lz4.c | 72
> ++-
> 1 file changed, 37 insertions(+), 35 deletions(-)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
wri
On Tue, Aug 28, 2018 at 04:56:43PM +0800, Chao Yu wrote:
> Hi Greg,
>
> On 2018/8/28 14:28, Gao Xiang wrote:
> > Hi Greg,
> >
> > On 2018/8/28 13:44, Greg Kroah-Hartman wrote:
> >> On Tue, Aug 28, 2018 at 11:39:48AM +0800, Gao Xi
On Tue, Aug 28, 2018 at 11:39:48AM +0800, Gao Xiang wrote:
> This reverts commit 156c3df8d4db4e693c062978186f44079413d74d.
>
> Since XArray and the new mount apis aren't merged in 4.19-rc1
> merge window, the BROKEN mark can be reverted directly without
> any problems.
>
> Fixes: 156c3df8d4db
61 matches
Mail list logo
