Re: [PATCH v11 06/25] mm: Use readahead_control to pass arguments

2020-04-15 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn 


Re: [PATCH v11 08/25] mm: rename readahead loop variable to 'i'

2020-04-15 Thread Johannes Thumshirn
Looks good,
Reviewed-by: Johannes Thumshirn 


Re: [PATCH v11 04/25] mm: Move readahead nr_pages check into read_pages

2020-04-15 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn 


Re: [PATCH v11 03/25] mm: Ignore return value of ->readpages

2020-04-15 Thread Johannes Thumshirn
Looks good,
Reviewed-by: Johannes Thumshirn 


Re: [PATCH v11 01/25] mm: Move readahead prototypes from mm.h

2020-04-15 Thread Johannes Thumshirn
Looks good,
Reviewed-by: Johannes Thumshirn 


Re: [PATCH v7 14/24] btrfs: Convert from readpages to readahead

2020-02-20 Thread Johannes Thumshirn
On 19/02/2020 22:03, Matthew Wilcox wrote:
> From: "Matthew Wilcox (Oracle)" 
> 
> Use the new readahead operation in btrfs.  Add a
> readahead_for_each_batch() iterator to optimise the loop in the XArray.


OK I must admit I haven't followed this series closely, but what 
happened to said readahead_for_each_batch()?

As far as I can see it's now:

[...]
> + while ((nr = readahead_page_batch(rac, pagepool))) {




Re: [PATCH v5 01/13] mm: Fix the return type of __do_page_cache_readahead

2020-02-11 Thread Johannes Thumshirn
On 11/02/2020 02:05, Matthew Wilcox wrote:
> even though I'm pretty sure we're not going to readahead more than 2^32
> pages ever.

And 640K is more memory than anyone will ever need on a computer *scnr*