Re: [PATCH] erofs: fix erofs_get_meta_page locking by a cleanup

2019-09-22 Thread Gao Xiang
Hi, On Sun, Sep 22, 2019 at 04:32:05PM +0800, kbuild test robot wrote: > > All warnings (new ones prefixed by >>): > >fs//erofs/data.c: In function 'erofs_get_meta_page': > >> fs//erofs/data.c:43:10: warning: return makes pointer from integer without > >> a cast [-Wint-conversion] >

Re: [PATCH] erofs: fix erofs_get_meta_page locking by a cleanup

2019-09-22 Thread kbuild test robot
Hi Gao, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.3 next-20190920] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the

[PATCH] erofs: fix erofs_get_meta_page locking by a cleanup

2019-09-21 Thread Gao Xiang
After doing more drop_caches stress test on our products, I found the mistake introduced by a very recent cleanup [1]. The current rule is that "erofs_get_meta_page" should be returned with page locked (although it's mostly unnecessary for read-only fs after pages are PG_Uptodate), but a fix