Re: [PATCH 1/7] block: add queue_logical_block_mask() and bdev_logical_block_mask()

2023-06-28 Thread Christoph Hellwig
What is the value add of this series?

Re: [PATCH 1/7] block: add queue_logical_block_mask() and bdev_logical_block_mask()

2023-06-28 Thread Darrick J. Wong
On Thu, Jun 29, 2023 at 11:44:35AM +0800, Yangtao Li wrote: > On 2023/6/29 0:46, Matthew Wilcox wrote: > > > On Wed, Jun 28, 2023 at 05:34:54PM +0800, Yangtao Li wrote: > > > Introduce queue_logical_block_mask() and bdev_logical_block_mask() > > > to simplify code, which replace

Re: [PATCH 1/7] block: add queue_logical_block_mask() and bdev_logical_block_mask()

2023-06-28 Thread Yangtao Li
On 2023/6/29 0:46, Matthew Wilcox wrote: On Wed, Jun 28, 2023 at 05:34:54PM +0800, Yangtao Li wrote: Introduce queue_logical_block_mask() and bdev_logical_block_mask() to simplify code, which replace (queue_logical_block_size(q) - 1) and (bdev_logical_block_size(bdev) - 1). The thing is that

Re: [PATCH 1/7] block: add queue_logical_block_mask() and bdev_logical_block_mask()

2023-06-28 Thread Matthew Wilcox
On Wed, Jun 28, 2023 at 05:34:54PM +0800, Yangtao Li wrote: > Introduce queue_logical_block_mask() and bdev_logical_block_mask() > to simplify code, which replace (queue_logical_block_size(q) - 1) > and (bdev_logical_block_size(bdev) - 1). The thing is that I know what queue_logical_block_size -

Re: [PATCH 1/7] block: add queue_logical_block_mask() and bdev_logical_block_mask()

2023-06-28 Thread Bill O'Donnell
On Wed, Jun 28, 2023 at 05:34:54PM +0800, Yangtao Li wrote: > Introduce queue_logical_block_mask() and bdev_logical_block_mask() > to simplify code, which replace (queue_logical_block_size(q) - 1) > and (bdev_logical_block_size(bdev) - 1). > > Signed-off-by: Yangtao Li Looks fine. Reviewed-by:

[PATCH 1/7] block: add queue_logical_block_mask() and bdev_logical_block_mask()

2023-06-28 Thread Yangtao Li
Introduce queue_logical_block_mask() and bdev_logical_block_mask() to simplify code, which replace (queue_logical_block_size(q) - 1) and (bdev_logical_block_size(bdev) - 1). Signed-off-by: Yangtao Li --- include/linux/blkdev.h | 10 ++ 1 file changed, 10 insertions(+) diff --git