Re: [PATCH v11 24/25] fuse: Convert from readpages to readahead

2020-04-20 Thread Miklos Szeredi
On Tue, Apr 14, 2020 at 5:08 PM Matthew Wilcox wrote: > > From: "Matthew Wilcox (Oracle)" > > Implement the new readahead operation in fuse by using __readahead_batch() > to fill the array of pages in fuse_args_pages directly. This lets us > inline fuse_readpages_fill() into fuse_readahead(). >

Re: [PATCH v11 24/25] fuse: Convert from readpages to readahead

2020-04-20 Thread Miklos Szeredi
On Mon, Apr 20, 2020 at 1:43 PM Matthew Wilcox wrote: > > On Mon, Apr 20, 2020 at 01:14:17PM +0200, Miklos Szeredi wrote: > > > + for (;;) { > > > + struct fuse_io_args *ia; > > > + struct fuse_args_pages *ap; >

Re: [PATCH v10 24/25] fuse: Convert from readpages to readahead

2020-03-25 Thread Miklos Szeredi
On Wed, Mar 25, 2020 at 1:02 PM Matthew Wilcox wrote: > > On Wed, Mar 25, 2020 at 10:42:56AM +0100, Miklos Szeredi wrote: > > > + while ((page = readahead_page(rac))) { > > > + if (fuse_readpages_fill(, page) != 0) > > > > Shouldn't this u

Re: [PATCH v10 24/25] fuse: Convert from readpages to readahead

2020-03-25 Thread Miklos Szeredi
On Wed, Mar 25, 2020 at 4:32 PM Matthew Wilcox wrote: > > On Wed, Mar 25, 2020 at 03:43:02PM +0100, Miklos Szeredi wrote: > > > > > > - while ((page = readahead_page(rac))) { > > > - if (fuse_readpages_fill(, page) != 0) > > > +

Re: [PATCH v10 24/25] fuse: Convert from readpages to readahead

2020-03-25 Thread Miklos Szeredi
On Mon, Mar 23, 2020 at 9:23 PM Matthew Wilcox wrote: > > From: "Matthew Wilcox (Oracle)" > > Use the new readahead operation in fuse. Switching away from the > read_cache_pages() helper gets rid of an implicit call to put_page(), > so we can get rid of the get_page() call in

Re: [PATCH v3] ovl: fix null pointer when filesystemdoesn'tsupportdirect IO

2021-09-28 Thread Miklos Szeredi
On Tue, 28 Sept 2021 at 09:01, Huang Jianan wrote: > > 在 2021/9/27 17:38, Miklos Szeredi 写道: > > On Wed, Sep 22, 2021 at 04:00:47PM +0200, Miklos Szeredi wrote: > > > >> First let's fix the oops: ovl_read_iter()/ovl_write_iter() must check > >> real file

Re: [PATCH v3] ovl: fix null pointer when filesystemdoesn'tsupportdirect IO

2021-09-22 Thread Miklos Szeredi
On Wed, 22 Sept 2021 at 15:21, Chengguang Xu wrote: > > 在 2021/9/22 16:24, Huang Jianan 写道: > > > > > > 在 2021/9/22 16:06, Chengguang Xu 写道: > >> 在 2021/9/22 15:23, Huang Jianan 写道: > >>> From: Huang Jianan > >>> > >>> At present, overlayfs provides overlayfs inode to users. Overlayfs > >>>

Re: [PATCH v3] ovl: fix null pointer when filesystemdoesn'tsupportdirect IO

2021-09-27 Thread Miklos Szeredi
On Wed, Sep 22, 2021 at 04:00:47PM +0200, Miklos Szeredi wrote: > First let's fix the oops: ovl_read_iter()/ovl_write_iter() must check > real file's ->direct_IO if IOCB_DIRECT is set in iocb->ki_flags and > return -EINVAL if not. And here's that fix. Please test. Thanks, M