Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers

2006-09-13 Thread Andrew Morton
On Wed, 13 Sep 2006 15:25:19 -0500 Dave Kleikamp <[EMAIL PROTECTED]> wrote: > > +void journal_do_submit_data(struct buffer_head **wbuf, int bufs) > > Is there any reason this couldn't be static? Nope. > > +{ > > + int i; > > + > > + for (i = 0; i < bufs; i++) { > > + w

Re: rfc: [patch] change attribute for ext3

2006-09-13 Thread J. Bruce Fields
On Wed, Sep 13, 2006 at 01:31:30PM -0600, Andreas Dilger wrote: > On Sep 13, 2006 18:42 +0200, Alexandre Ratchov wrote: > > The patch also adds a new ``st_change_attribute'' field in the stat > > structure, and modifies the stat(2) syscall accordingly. Currently the > > change is only visible on i

Re: rfc: [patch] change attribute for ext3

2006-09-13 Thread Randy.Dunlap
On Wed, 13 Sep 2006 15:06:02 -0400 Trond Myklebust wrote: > On Wed, 2006-09-13 at 20:30 +0200, Alexandre Ratchov wrote: > > On Wed, Sep 13, 2006 at 02:11:11PM -0400, Trond Myklebust wrote: > > > On Wed, 2006-09-13 at 18:42 +0200, Alexandre Ratchov wrote: > > > > hello, > > > > > > > > here is a

Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers

2006-09-13 Thread Dave Kleikamp
On Fri, 2006-09-08 at 00:30 +0200, Jan Kara wrote: > diff -rupX /home/jack/.kerndiffexclude > linux-2.6.18-rc6/fs/jbd/commit.c > linux-2.6.18-rc6-1-orderedwrite/fs/jbd/commit.c > --- linux-2.6.18-rc6/fs/jbd/commit.c2006-09-06 18:20:48.0 > +0200 > +++ linux-2.6.18-rc6-1-orderedwrite/fs/j

Re: rfc: [patch] change attribute for ext3

2006-09-13 Thread Andreas Dilger
On Sep 13, 2006 18:42 +0200, Alexandre Ratchov wrote: > the change attribute is a simple counter that is reset to zero on > inode creation and that is incremented every time the inode data is > modified (similarly to the "ctime" time-stamp). To start, I'm supportive of this concept, my comments a

Re: rfc: [patch] change attribute for ext3

2006-09-13 Thread Trond Myklebust
On Wed, 2006-09-13 at 20:30 +0200, Alexandre Ratchov wrote: > On Wed, Sep 13, 2006 at 02:11:11PM -0400, Trond Myklebust wrote: > > On Wed, 2006-09-13 at 18:42 +0200, Alexandre Ratchov wrote: > > > hello, > > > > > > here is a small patch that adds the "change attribute" for ext3 > > > file-system

Re: rfc: [patch] change attribute for ext3

2006-09-13 Thread Alexandre Ratchov
On Wed, Sep 13, 2006 at 02:11:11PM -0400, Trond Myklebust wrote: > On Wed, 2006-09-13 at 18:42 +0200, Alexandre Ratchov wrote: > > hello, > > > > here is a small patch that adds the "change attribute" for ext3 > > file-systems; > > > > the change attribute is a simple counter that is reset to ze

Re: rfc: [patch] change attribute for ext3

2006-09-13 Thread Trond Myklebust
On Wed, 2006-09-13 at 18:42 +0200, Alexandre Ratchov wrote: > hello, > > here is a small patch that adds the "change attribute" for ext3 > file-systems; > > the change attribute is a simple counter that is reset to zero on > inode creation and that is incremented every time the inode data is > m

rfc: [patch] change attribute for ext3

2006-09-13 Thread Alexandre Ratchov
ble on i386 and x86_64 archs. In order to test the patch, there's a trivial utility that displays the value of the change attribute: http://www.bullopensource.org/ext4/20060913/chinfo.tar.gz Comments? cheers, -- Alexandre Signed-off-by: Celine Bourd