Re: [RFC] Ext3 online defrag

2006-10-26 Thread David Chinner
On Wed, Oct 25, 2006 at 11:33:16PM -0400, Theodore Tso wrote: On Thu, Oct 26, 2006 at 11:40:20AM +1000, David Chinner wrote: We don't need to expose anything filesystem specific to userspace to implement this. Online data movement (i.e. the defrag mechanism) becomes something like:

Re: [RFC] Ext3 online defrag

2006-10-26 Thread Andreas Dilger
On Oct 25, 2006 16:54 +0200, Jan Kara wrote: I've just not yet decided how to handle indirect blocks in case of relocation in the middle of the file. Should they be relocated or shouldn't they? Probably they should be relocated at least in case they are fully contained in relocated interval

Re: ext3: bogus i_mode errors with 2.6.18.1

2006-10-26 Thread Andreas Dilger
On Oct 25, 2006 11:44 +0200, Andre Noll wrote: Are you saying that ext3_set_bit() should simply be called with ret_block as its first argument? If yes, that is what the revised patch below does. You might need to call ext3_set_bit_atomic() (as claim_block() does, not sure. @@ -1372,12

Re: [RFC] Ext3 online defrag

2006-10-26 Thread Jan Kara
On Wed, Oct 25, 2006 at 01:00:52PM -0400, Jeff Garzik wrote: On Wed, Oct 25, 2006 at 06:11:37PM +1000, David Chinner wrote: On Wed, Oct 25, 2006 at 02:01:42AM -0400, Jeff Garzik wrote: So how do you then get the generic interface to allocate blocks specified by userspace race free?

Re: [RFC] Ext3 online defrag

2006-10-26 Thread Theodore Tso
On Thu, Oct 26, 2006 at 04:36:48PM +1000, David Chinner wrote: Remember, I'm not just talking about defrag - I'm talking about an interface that is actually useful to apps that might care about how data is laid out on disk but the applications writers don't know anyhting about how

Re: [RFC] Ext3 online defrag

2006-10-26 Thread Dave Kleikamp
On Thu, 2006-10-26 at 09:37 -0400, Theodore Tso wrote: On Thu, Oct 26, 2006 at 04:36:48PM +1000, David Chinner wrote: Remember, I'm not just talking about defrag - I'm talking about an interface that is actually useful to apps that might care about how data is laid out on disk but the

Re: [RFC] Ext3 online defrag

2006-10-26 Thread Jörn Engel
On Wed, 25 October 2006 14:41:18 -0400, Jeff Garzik wrote: On Wed, Oct 25, 2006 at 08:36:56PM +0200, Jan Kara wrote: Yes, but there's a question of the interface to this operation. How to specify which indirect block I mean? Obviously we could introduce separate call for remapping

Re: [RFC] Ext3 online defrag

2006-10-26 Thread David Chinner
On Thu, Oct 26, 2006 at 01:37:22PM +0200, Jan Kara wrote: On Wed, Oct 25, 2006 at 01:00:52PM -0400, Jeff Garzik wrote: We don't need to expose anything filesystem specific to userspace to implement this. Online data movement (i.e. the defrag mechanism) becomes something like: do