Re: [RFC][Patch 1/2] Persistent preallocation in ext4

2006-12-19 Thread Amit K. Arora
On Tue, Dec 19, 2006 at 02:12:06PM -0700, Andreas Dilger wrote: > Minor edits (not worth a resubmit by itself): Thanks, Andreas ! I will take care of these comments in the next submission. Regards, Amit Arora > > On Dec 19, 2006 16:35 +0530, Amit K. Arora wrote: > > + /* ext4_can_exte

Re: [RFC] [PATCH] Fix kmalloc flags used in ext3 with an active journal handle

2006-12-19 Thread Suzuki
Andrew Morton wrote: On Tue, 19 Dec 2006 17:58:12 -0800 Suzuki <[EMAIL PROTECTED]> wrote: * Fix the kmalloc flags used from within ext3, when we have an active journal handle If we do a kmalloc with GFP_KERNEL on system running low on memory, with an active journal handle, we might

Re: [RFC] [PATCH] Fix kmalloc flags used in ext3 with an active journal handle

2006-12-19 Thread Andrew Morton
On Tue, 19 Dec 2006 17:58:12 -0800 Suzuki <[EMAIL PROTECTED]> wrote: > * Fix the kmalloc flags used from within ext3, when we have an active journal > handle > > If we do a kmalloc with GFP_KERNEL on system running low on memory, > with an active journal handle, we might end up in cleanin

[RFC] [PATCH] Fix kmalloc flags used in ext3 with an active journal handle

2006-12-19 Thread Suzuki
Hi, The attached patch converts the GFP mask for kmallocs within ext3 to GFP_NOFS whenever they are called with an active journal handle. More description in the patch. Comments ? Thanks, Suzuki Linux Technology Center IBM Systems & Technology Labs. * Fix the kmalloc flags used from within

Re: [RFC][Patch 2/2] Persistent preallocation in ext4

2006-12-19 Thread Eric Sandeen
Andreas Dilger wrote: > On Dec 19, 2006 17:12 +0530, Amit K. Arora wrote: >> I wrote a simple tool to test these patches. The tool takes four >> arguments: >> >> * command: It may have either of the two values - "prealloc" or "write" >> * filename: This is the filename with relative path >> * offs

Re: [RFC][Patch 2/2] Persistent preallocation in ext4

2006-12-19 Thread Andreas Dilger
On Dec 19, 2006 17:12 +0530, Amit K. Arora wrote: > I wrote a simple tool to test these patches. The tool takes four > arguments: > > * command: It may have either of the two values - "prealloc" or "write" > * filename: This is the filename with relative path > * offset: The offset within the fil

Re: [RFC][Patch 2/2] Persistent preallocation in ext4

2006-12-19 Thread Amit K. Arora
On Tue, Dec 19, 2006 at 05:12:51PM +0530, Amit K. Arora wrote: > I also tried some random preallocation and write operations. They seem > to work fine. There is a patch also ready for e2fsprogs utils to > recognize uninitialized extents, which I used to verify the results of > the above testcases.

Re: [RFC][Patch 2/2] Persistent preallocation in ext4

2006-12-19 Thread Amit K. Arora
I wrote a simple tool to test these patches. The tool takes four arguments: * command: It may have either of the two values - "prealloc" or "write" * filename: This is the filename with relative path * offset: The offset within the file from where the preallocation, or the write sh

Re: [RFC][Patch 1/2] Persistent preallocation in ext4

2006-12-19 Thread Amit K. Arora
On Fri, Dec 15, 2006 at 06:05:28PM +0530, Amit K. Arora wrote: > --- linux-2.6.19.prealloc.orig/fs/ext4/ioctl.c2006-12-15 > 16:44:35.0 +0530 > +++ linux-2.6.19.prealloc/fs/ext4/ioctl.c 2006-12-15 17:47:00.0 > +0530 : : > + handle=ext4_journal_start(inode, >