Re: delayed allocatiou result in Oops

2007-06-14 Thread Alex Tomas
looks like an error in error handling path (notice -28 (ENOSPC) before) thanks for the report, Alex Dmitriy Monakhov wrote: ) Simple test failed on ext4 when delayed allocation was used. #mkfs.ext3 -b4096 /dev/vzvg/test2 #mount -text4dev /dev/vzvg/test2 /mnt/test -odelalloc #fsstress -d /mnt/

Re: ext4 patch queue updated

2007-06-14 Thread Alex Tomas
OK Mingming Cao wrote: Run checkpatch.pl http://lwn.net/Articles/237451/ I fixed coding style issues for most patches by hand except the delayed allocation patch ext4-delayed-allocation.patch. That need a bit more work and requires someone family with the code better. Alex, can you help on this

Re: iov_iter_fault_in_readable fix

2007-06-14 Thread Christoph Hellwig
On Fri, Jun 15, 2007 at 08:21:09AM +1000, David Chinner wrote: > Yeah, it can run a subset of the tests on NFS and UDF filesystems as well and > there are some specific UDF-only tests in it too. I think the NFS test group > is mostly generic tests that don't use or test specific XFS features. Act

Re: [PATCH 4/6] add noversion mount option

2007-06-14 Thread Mingming Cao
On Fri, 2007-06-15 at 03:22 +0530, Kalpak Shah wrote: > On Thu, 2007-06-14 at 13:50 -0700, Mingming Cao wrote: > > On Thu, 2007-06-14 at 21:26 +0530, Kalpak Shah wrote: > > > This patch adds a "noversion" mount option to disable inode version > > > updates. > > > > Can you explain a bit more why w

Re: iov_iter_fault_in_readable fix

2007-06-14 Thread David Chinner
On Thu, Jun 14, 2007 at 06:31:53PM +0100, Christoph Hellwig wrote: > On Wed, Jun 13, 2007 at 05:57:59PM +0400, Dmitriy Monakhov wrote: > > Function prerform check for signgle region, with out respect to > > segment nature of iovec, For example writev no longer works :) > > Btw, could someo

Re: [PATCH 4/6] add noversion mount option

2007-06-14 Thread Kalpak Shah
On Thu, 2007-06-14 at 13:50 -0700, Mingming Cao wrote: > On Thu, 2007-06-14 at 21:26 +0530, Kalpak Shah wrote: > > This patch adds a "noversion" mount option to disable inode version > > updates. > > Can you explain a bit more why we need this mount option? Is it because > of performance concern?

Re: [PATCH 4/6] add noversion mount option

2007-06-14 Thread Andreas Dilger
On Jun 14, 2007 13:50 -0700, Mingming Cao wrote: > On Thu, 2007-06-14 at 21:26 +0530, Kalpak Shah wrote: > > This patch adds a "noversion" mount option to disable inode version > > updates. > > Can you explain a bit more why we need this mount option? Is it because > of performance concern? Thi

Re: [PATCH 1/6] Separated 64-bit i_version patch

2007-06-14 Thread Andreas Dilger
On Jun 14, 2007 13:58 -0700, Mingming Cao wrote: > On Thu, 2007-06-14 at 21:26 +0530, Kalpak Shah wrote: > > This patch converts the 32-bit i_version in the generic inode to a 64- > > bit i_version field. > > > > Signed-off-by: Jean Noel Cordenner <[EMAIL PROTECTED]> > > Signed-off-by: Kalpak Sha

Re: [PATCH 1/6] Separated 64-bit i_version patch

2007-06-14 Thread Mingming Cao
On Thu, 2007-06-14 at 21:26 +0530, Kalpak Shah wrote: > This patch converts the 32-bit i_version in the generic inode to a 64- > bit > i_version field. > > Signed-off-by: Jean Noel Cordenner <[EMAIL PROTECTED]> > Signed-off-by: Kalpak Shah <[EMAIL PROTECTED]> > > Index: linux-2.6.21/include/linux

Re: [PATCH 4/6] add noversion mount option

2007-06-14 Thread Mingming Cao
On Thu, 2007-06-14 at 21:26 +0530, Kalpak Shah wrote: > This patch adds a "noversion" mount option to disable inode version > updates. Can you explain a bit more why we need this mount option? Is it because of performance concern? Mingming - To unsubscribe from this list: send the line "unsubsc

Re: [PATCH 0/6] inode version updated patches

2007-06-14 Thread Mingming Cao
On Thu, 2007-06-14 at 21:26 +0530, Kalpak Shah wrote: > Hi, > > I have updated the inode version patches and below are the details: > > 64-bit-i_version.patch which only replaces the 32-bit i_version field in > the generic inode with a 64-bit i_version field. The VFS-level updates > of the inode

Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc

2007-06-14 Thread Andreas Dilger
On Jun 14, 2007 22:04 +1000, David Chinner wrote: > On Thu, Jun 14, 2007 at 03:14:58AM -0600, Andreas Dilger wrote: > > > B FA_DEALLOCATE > > > removes the underlying disk space with the given range. The disk space > > > shall be removed regardless of it's contents so both allocated space > > > fr

Re: Couple of queries related to htree directory

2007-06-14 Thread Theodore Tso
On Thu, Jun 14, 2007 at 06:52:01PM +0530, Tejas Sumant wrote: > > Any idea, how to search a directory on given ext3 file system, which > is having htree structure? The same way you search any other Linux/Unix system. I.e., using opendir()/readir() from a C program, or /bin/ls from a shell progra

Re: iov_iter_fault_in_readable fix

2007-06-14 Thread Christoph Hellwig
On Wed, Jun 13, 2007 at 05:57:59PM +0400, Dmitriy Monakhov wrote: > Function prerform check for signgle region, with out respect to > segment nature of iovec, For example writev no longer works :) Btw, could someone please start to collect all sniplets like this in a nice simple regres

Re: inode version updates

2007-06-14 Thread Mingming Cao
Andreas Dilger wrote: Mingming Cao <[EMAIL PROTECTED]> writes: I took out the i_version code from Kalpak's ext4_expand_inode_extra_isize.patch. http://repo.or.cz/w/ext4-patch-queue.git?a=blob;f=ext4_i_version_hi_2.patch;h=4519dd6540a78cadd235dad68248456d59c3384c;hb=8b956b5c5ccc3731f23fbce8d0

[PATCH 6/6] Updated series file

2007-06-14 Thread Kalpak Shah
The updated series file. # Rebased the patches to 2.6.22-rc4 # Add mount option to turn off extents ext4_noextent_mount_opt.patch # Mounted ext4dev fs with extents by default for testing purpose, # for Ext4 product release, extents mount option # will be turn on only if the fs has EXTENTS featur

[PATCH 5/6] VFS updates to i_version

2007-06-14 Thread Kalpak Shah
The VFS-level updates of the inode version. These may not be necessary since the i_version is being updated in ext4_mark_iloc_dirty(). Signed-off-by: Jean Noel Cordenner <[EMAIL PROTECTED]> --- binfmt_misc.c |1 + libfs.c |9 + pipe.c|1 + 3 files changed, 11 in

[PATCH 4/6] add noversion mount option

2007-06-14 Thread Kalpak Shah
This patch adds a "noversion" mount option to disable inode version updates. Signed-off-by: Andreas Dilger <[EMAIL PROTECTED]> Signed-off-by: Kalpak Shah <[EMAIL PROTECTED]> --- fs/ext4/inode.c |4 +++- fs/ext4/super.c |6 +- include/linux/ext4_fs.h |1 + 3 files c

[PATCH 4/6] add noversion mount option

2007-06-14 Thread Kalpak Shah
This patch adds a "noversion" mount option to disable inode version updates. Signed-off-by: Andreas Dilger <[EMAIL PROTECTED]> Signed-off-by: Kalpak Shah <[EMAIL PROTECTED]> --- fs/ext4/inode.c |4 +++- fs/ext4/super.c |6 +- include/linux/ext4_fs.h |1 + 3 files c

[PATCH 3/6] Changes for 64-bit i_version

2007-06-14 Thread Kalpak Shah
ext4_i_version_hi_2.patch was still using ei->i_fs_version instead of inode->i_version. I have corrected it. Signed-off-by: Kalpak Shah <[EMAIL PROTECTED]> Signed-off-by: Mingming Cao <[EMAIL PROTECTED]> --- fs/ext4/inode.c | 15 ++- include/linux/ext4_fs.h |4 +++- 2 fil

[PATCH 1/6] Separated 64-bit i_version patch

2007-06-14 Thread Kalpak Shah
64-bit-i_version.patch which only replaces the 32-bit i_version field in the generic inode with a 64-bit i_version field. Signed-off-by: Jean Noel Cordenner <[EMAIL PROTECTED]> Signed-off-by: Kalpak Shah <[EMAIL PROTECTED]> --- fs.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) P.S.

[PATCH 2/6] add i_version_hi to ext4_inode

2007-06-14 Thread Kalpak Shah
There were whitespace problems in i_version_hi.patch. I am attaching the corrected patch. Signed-off-by: Andreas Dilger <[EMAIL PROTECTED]> Signed-off-by: Kalpak Shah <[EMAIL PROTECTED]> --- ext4_fs.h |1 + 1 file changed, 1 insertion(+) This patch adds a 32-bit i_version_hi field to ext4_in

[PATCH 0/6] inode version updated patches

2007-06-14 Thread Kalpak Shah
Hi, I have updated the inode version patches and below are the details: 64-bit-i_version.patch which only replaces the 32-bit i_version field in the generic inode with a 64-bit i_version field. The VFS-level updates of the inode version are still in the i_version_update_vfs.patch and this patch h

[PATCH] ext4:fix unexpected error from ext4_reserve_global

2007-06-14 Thread Dmitriy Monakhov
I just cant belive my eyes then i saw this at the first time... simple test: strace dd if=/dev/zero of=/mnt/file open("/dev/zero", O_RDONLY) = 0 close(1)= 0 open("/mnt/test/file", O_WRONLY|O_CREAT|O_TRUNC, 0666) = 1 read(0, "\0\0\0\0\0\0\0\0\0"..., 512)

Couple of queries related to htree directory

2007-06-14 Thread Tejas Sumant
Hi All, Any idea, how to search a directory on given ext3 file system, which is having htree structure? Also is there any way to create a htree indexed directory explicitly? using some command or tool? Thanks -- Tejas Sumant - To unsubscribe from this list: send the line "unsubscribe linux-ext4"

Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc

2007-06-14 Thread David Chinner
On Thu, Jun 14, 2007 at 03:14:58AM -0600, Andreas Dilger wrote: > On Jun 14, 2007 09:52 +1000, David Chinner wrote: > > B FA_PREALLOCATE > > provides the same functionality as > > B FA_ALLOCATE > > except it does not ever change the file size. This allows allocation > > of zero blocks beyond the e

Re: + fs-introduce-write_begin-write_end-and-perform_write-aops.patch added to -mm tree

2007-06-14 Thread Nick Piggin
On Thu, Jun 14, 2007 at 11:52:49AM +0200, Jan Kara wrote: > > On Wed, 2007-06-13 at 13:43 +0200, Nick Piggin wrote: > > .. > > > > > > > 5) ext3_write_end: > > > > Before write_begin/write_end patch set we have folowing locking > > > > order: > > > > stop_journal(

Re: inode version updates

2007-06-14 Thread Andreas Dilger
Mingming Cao <[EMAIL PROTECTED]> writes: > I took out the i_version code from Kalpak's > ext4_expand_inode_extra_isize.patch. > > http://repo.or.cz/w/ext4-patch-queue.git?a=blob;f=ext4_i_version_hi_2.patch;h=4519dd6540a78cadd235dad68248456d59c3384c;hb=8b956b5c5ccc3731f23fbce8d036b21f378fbdec > > A

Re: + fs-introduce-write_begin-write_end-and-perform_write-aops.patch added to -mm tree

2007-06-14 Thread Jan Kara
> On Wed, 2007-06-13 at 13:43 +0200, Nick Piggin wrote: > .. > > > > > 5) ext3_write_end: > > > Before write_begin/write_end patch set we have folowing locking > > > order: > > > stop_journal(handle); > > > unlock_page(page); > > > But now order is oposite: > > >

Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc

2007-06-14 Thread Andreas Dilger
On Jun 14, 2007 09:52 +1000, David Chinner wrote: > B FA_PREALLOCATE > provides the same functionality as > B FA_ALLOCATE > except it does not ever change the file size. This allows allocation > of zero blocks beyond the end of file and is useful for optimising > append workloads. > TP > B FA_DEAL

delayed allocatiou result in Oops

2007-06-14 Thread Dmitriy Monakhov
Simple test failed on ext4 when delayed allocation was used. #mkfs.ext3 -b4096 /dev/vzvg/test2 #mount -text4dev /dev/vzvg/test2 /mnt/test -odelalloc #fsstress -d /mnt/test/ -l100 -n10 -p20 -f dwrite=0 EXT4-fs: writeback error = -28 .. EXT4-fs: writeback error = -28 Unable to handle ker