Re: [patch] new aop loop fix

2007-06-13 Thread Hugh Dickins
On Wed, 13 Jun 2007, Dmitriy Monakhov wrote: > Btw: Nick's patches broke LO_CRYPT_XOR mode, It would help him if you could describe how. > but it is ok because > this feature was absolete and not used by anyone, am i right here? I know nothing of this; but so long as its code remains in the dri

Re: [patch] new aop loop fix

2007-06-13 Thread Hugh Dickins
On Wed, 13 Jun 2007, Dmitriy Monakhov wrote: > loop.c code itself is not perfect. In fact before Nick's patch > partial write was't possible. Assumption what write chunks are > always page aligned is realy weird ( see "index++" line). > > Signed-off-by: Dmitriy Monakhov <[EMAIL

[PATCH] fix umask when noACL kernel meets extN tuned for ACLs

2007-01-22 Thread Hugh Dickins
se of more ifdefs). Likewise don't set the XATTR_USER flag when built without XATTR support. Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> --- fs/ext2/super.c |4 fs/ext3/super.c |4 fs/ext4/super.c |4 3 files changed, 12 insertions(+) --- 2.6.20-rc5/fs/

Re: umask ignored in mkdir(2)?

2007-01-15 Thread Hugh Dickins
efault mode on symlinks (always 0777) assumed VFS applies umask: which it does, unless the mount is marked for ACLs; but ext[234] set MS_POSIXACL in s_flags according to s_mount_opt set according to def_mount_opts. We could revert to the 2.6.10 ext[234]_init_acl (adding an S_ISLNK test); but other files

Re: + ext3-balloc-fix-_with_rsv-freeze.patch added to -mm tree

2006-11-29 Thread Hugh Dickins
xt to find > out what to do about this > > -- > Subject: ext3 balloc: fix _with_rsv freeze > From: Hugh Dickins <[EMAIL PROTECTED]> > > After several days of testing ext3 with reservations, it got caught inside > e

Re: [PATCH 1/12] ext3 balloc: reset windowsz when full

2006-11-28 Thread Hugh Dickins
On Tue, 28 Nov 2006, Mingming Cao wrote: > Port a series ext2 balloc patches from Hugh to ext3/4. The first 6 > patches are against ext3, and the rest are aginst ext4. Thanks for all that, Mingming: whichever is appropriate, all twelve Acked-by: Hugh Dickins <[EMAIL PROTECTED]> or S

Re: Boot failure with ext2 and initrds

2006-11-28 Thread Hugh Dickins
On Tue, 21 Nov 2006, Mingming Cao wrote: > On Mon, 2006-11-20 at 16:19 +0000, Hugh Dickins wrote: > > After four days of running, the EM64T has at last reproduced the same > > hang as it did in an hour before: stuck in > > ext2_try_to_allocate_with_rsv, > > rep

Re: [PATCH 1/6] ext2 balloc: fix _with_rsv freeze

2006-11-28 Thread Hugh Dickins
On Tue, 28 Nov 2006, Mingming Cao wrote: > On Tue, 2006-11-28 at 17:40 +0000, Hugh Dickins wrote: > > After several days of testing ext2 with reservations, it got caught inside > > ext2_try_to_allocate_with_rsv: alloc_new_reservation repeatedly succeeding > > on th

[PATCH 4/6] ext2 balloc: fix off-by-one against grp_goal

2006-11-28 Thread Hugh Dickins
grp_goal 0 is a genuine goal (unlike -1), so ext2_try_to_allocate_with_rsv should treat it as such. Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> --- fs/ext2/balloc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- 2.6.19-rc6-mm2/fs/ext2/balloc.c 2006-11-24

[PATCH 5/6] ext2 balloc: say rb_entry not list_entry

2006-11-28 Thread Hugh Dickins
The reservations tree is an rb_tree not a list, so it's less confusing to use rb_entry() than list_entry() - though they're both just container_of(). Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> --- fs/ext2/balloc.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletion

[PATCH 1/6] ext2 balloc: fix _with_rsv freeze

2006-11-28 Thread Hugh Dickins
found 00). Is this a problem for mainline ext2? No, because the "size" in its memscan is always EXT2_BLOCKS_PER_GROUP(sb), which mkfs.ext2 requires to be a multiple of 8. Is this a problem for ext3 or ext4? No, because they have an additional extN_test_allocatable test which rescues t

[PATCH 3/6] ext2 balloc: fix off-by-one against rsv_end

2006-11-28 Thread Hugh Dickins
rsv_end is the last block within the reservation, so alloc_new_reservation should accept start_block == rsv_end as success. Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> --- fs/ext2/balloc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- 2.6.19-rc6-mm2/fs/ext2/balloc.c

[PATCH 6/6] ext2 balloc: use io_error label

2006-11-28 Thread Hugh Dickins
ext2_new_blocks has a nice io_error label for setting -EIO, so goto that in the one place that doesn't already use it. Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> --- fs/ext2/balloc.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) --- 2.6.19-rc6-mm2/fs/ex

[PATCH 2/6] ext2 balloc: reset windowsz when full

2006-11-28 Thread Hugh Dickins
ext2_new_blocks should reset the reservation window size to 0 when squeezing the last blocks out of an almost full filesystem, so the retry doesn't skip any groups with less than half that free, reporting ENOSPC too soon. Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> --- fs/ex

Re: Boot failure with ext2 and initrds

2006-11-16 Thread Hugh Dickins
On Thu, 16 Nov 2006, Andrew Morton wrote: > On Thu, 16 Nov 2006 00:49:20 -0800 > Mingming Cao <[EMAIL PROTECTED]> wrote: > > > That does not explain the repeated reservation window add and remove > > behavior Huge has reported. > > I spent quite some time comparing with ext3. I'm a bit stumped