Re: [PATCH] clear extents flag on inodes created in ext4_mknod

2008-02-19 Thread Eric Sandeen
Aneesh Kumar K.V wrote: >> How about enabling it only for directory and regular files rather than >> enabling it globally and then disabling the flag for symlink and device >> files ? >> > > how about something like below. There are two reason for not inheriting > the i_flag from directory. Loo

Re: [PATCH] clear extents flag on inodes created in ext4_mknod

2008-02-19 Thread Aneesh Kumar K.V
On Tue, Feb 19, 2008 at 10:19:44PM +0530, Aneesh Kumar K.V wrote: > On Tue, Feb 19, 2008 at 10:39:52AM -0600, Eric Sandeen wrote: > > Eric Sandeen wrote: > > > e2fsck doesn't expect to find char, block, fifo, or socket > > > files with the extent flag set, so clear that in ext4_mknod. > > > > > >

Re: [PATCH] clear extents flag on inodes created in ext4_mknod

2008-02-19 Thread Eric Sandeen
Aneesh Kumar K.V wrote: > On Tue, Feb 19, 2008 at 10:39:52AM -0600, Eric Sandeen wrote: >> Eric Sandeen wrote: >>> e2fsck doesn't expect to find char, block, fifo, or socket >>> files with the extent flag set, so clear that in ext4_mknod. >>> >>> Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]> >>>

Re: [PATCH] clear extents flag on inodes created in ext4_mknod

2008-02-19 Thread Aneesh Kumar K.V
On Tue, Feb 19, 2008 at 10:39:52AM -0600, Eric Sandeen wrote: > Eric Sandeen wrote: > > e2fsck doesn't expect to find char, block, fifo, or socket > > files with the extent flag set, so clear that in ext4_mknod. > > > > Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]> > > --- > > > > Index: linux-

Re: [PATCH] clear extents flag on inodes created in ext4_mknod

2008-02-19 Thread Eric Sandeen
Eric Sandeen wrote: > e2fsck doesn't expect to find char, block, fifo, or socket > files with the extent flag set, so clear that in ext4_mknod. > > Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]> > --- > > Index: linux-2.6.24/fs/ext4/namei.c > =

Re: [PATCH] clear extents flag on inodes created in ext4_mknod

2008-02-18 Thread Mingming Cao
Acked and added to the patch queue. On Mon, 2008-02-18 at 15:00 -0600, Eric Sandeen wrote: > e2fsck doesn't expect to find char, block, fifo, or socket > files with the extent flag set, so clear that in ext4_mknod. > > Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]> > --- > > Index: linux-2.6.24/

[PATCH] clear extents flag on inodes created in ext4_mknod

2008-02-18 Thread Eric Sandeen
e2fsck doesn't expect to find char, block, fifo, or socket files with the extent flag set, so clear that in ext4_mknod. Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]> --- Index: linux-2.6.24/fs/ext4/namei.c === --- linux-2.6.24.orig