Re: [PATCH] e2fsprogs: Offsets of EAs in inode need not be sorted

2007-05-07 Thread Theodore Tso
On Thu, Apr 19, 2007 at 05:35:36PM +0530, Kalpak Shah wrote: This patch removes a code snippet from check_ea_in_inode() in pass1 which checks if the EA values in the inode are sorted or not. The comments in fs/ext*/xattr.c state that the EA values in the external EA block are sorted but those

Re: [PATCH] e2fsprogs: Offsets of EAs in inode need not be sorted

2007-04-20 Thread Kalpak Shah
On Fri, 2007-04-20 at 08:38 -0400, Theodore Tso wrote: On Thu, Apr 19, 2007 at 05:35:36PM +0530, Kalpak Shah wrote: Hi, This patch removes a code snippet from check_ea_in_inode() in pass1 which checks if the EA values in the inode are sorted or not. The comments in fs/ext*/xattr.c

Re: [PATCH] e2fsprogs: Offsets of EAs in inode need not be sorted

2007-04-20 Thread Theodore Tso
On Thu, Apr 19, 2007 at 05:35:36PM +0530, Kalpak Shah wrote: Hi, This patch removes a code snippet from check_ea_in_inode() in pass1 which checks if the EA values in the inode are sorted or not. The comments in fs/ext*/xattr.c state that the EA values in the external EA block are sorted but

Re: [PATCH] e2fsprogs: Offsets of EAs in inode need not be sorted

2007-04-20 Thread Kalpak Shah
On Fri, 2007-04-20 at 10:10 -0400, Theodore Tso wrote: On Fri, Apr 20, 2007 at 06:35:41PM +0530, Kalpak Shah wrote: I saw this problem when I was running a script which created a random number of EAs for a file of random sizes. If you mount the image I have given, all the EAs are

[PATCH] e2fsprogs: Offsets of EAs in inode need not be sorted

2007-04-19 Thread Kalpak Shah
Hi, This patch removes a code snippet from check_ea_in_inode() in pass1 which checks if the EA values in the inode are sorted or not. The comments in fs/ext*/xattr.c state that the EA values in the external EA block are sorted but those in the inode need not be sorted. I have also attached a