Re: [PATCH 3/3] e2fsprogs: Support for large inode migration.

2007-07-27 Thread Aneesh Kumar K.V
Theodore Tso wrote: On Fri, Jul 27, 2007 at 08:29:31AM +0530, Aneesh Kumar K.V wrote: What are the issues you see with PATCH 1 and PATCH 2 which implement Undo I/O Manager and undoe2fs other than it is not hooked into any of the existing tools. I will try to add it to mke2fs as you suggested.

Re: [PATCH 3/3] e2fsprogs: Support for large inode migration.

2007-07-27 Thread Theodore Tso
On Fri, Jul 27, 2007 at 08:29:31AM +0530, Aneesh Kumar K.V wrote: > What are the issues you see with PATCH 1 and PATCH 2 which implement > Undo I/O Manager and undoe2fs other than it is not hooked into any of > the existing tools. I will try to add it to mke2fs as you suggested. But > should that

Re: [PATCH 3/3] e2fsprogs: Support for large inode migration.

2007-07-26 Thread Aneesh Kumar K.V
Theodore Tso wrote: On Thu, Jul 26, 2007 at 05:15:30PM +0530, Aneesh Kumar K.V wrote: Let me guess, you're testing with a filesystem with two block groups, right? And to date you've tested *only* by doubling the size of the inode. I tested this with multiple ( 1 and 7 ) groups. But yes all t

Re: [PATCH 3/3] e2fsprogs: Support for large inode migration.

2007-07-26 Thread Theodore Tso
On Thu, Jul 26, 2007 at 05:15:30PM +0530, Aneesh Kumar K.V wrote: > >Let me guess, you're testing with a filesystem with two block groups, > >right? And to date you've tested *only* by doubling the size of the > >inode. > > I tested this with multiple ( 1 and 7 ) groups. But yes all the > testing

Re: [PATCH 3/3] e2fsprogs: Support for large inode migration.

2007-07-26 Thread Theodore Tso
On Wed, Jul 25, 2007 at 01:46:25PM -0600, Andreas Dilger wrote: > I was just going to write the same things. However, it should be noted > that we DO in fact use only the start of each inode table block in > normal cases. We did a survey of this across some hundreds of filesystems > and because a

Re: [PATCH 3/3] e2fsprogs: Support for large inode migration.

2007-07-26 Thread Aneesh Kumar K.V
Theodore Tso wrote: On Wed, Jul 25, 2007 at 11:06:28AM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V <[EMAIL PROTECTED]> Add new option -I to tune2fs. This is used to change the inode size. The size need to be multiple of 2 and we don't allow to decrease the inode size. As a part of

Re: [PATCH 3/3] e2fsprogs: Support for large inode migration.

2007-07-25 Thread Andreas Dilger
On Jul 25, 2007 11:06 +0530, Aneesh Kumar K.V wrote: > This helps in reverting the changes if end results > are not correct.The environment variable TUNE2FS_SCRATCH_DIR > is used to indicate the directory within which the tdb > file need to be created. The file will be named tune2fs-XX > @@

Re: [PATCH 3/3] e2fsprogs: Support for large inode migration.

2007-07-25 Thread Andreas Dilger
On Jul 25, 2007 10:32 -0400, Theodore Tso wrote: > The problem with your patch is: > > * By shrinking the number of inodes, it can constrain the > ability of the filesystem to create new files in the future. > > * It ruins the inode and block placement algorithms where we >

Re: [PATCH 3/3] e2fsprogs: Support for large inode migration.

2007-07-25 Thread Theodore Tso
On Wed, Jul 25, 2007 at 11:06:28AM +0530, Aneesh Kumar K.V wrote: > From: Aneesh Kumar K.V <[EMAIL PROTECTED]> > > Add new option -I to tune2fs. > This is used to change the inode size. The size > need to be multiple of 2 and we don't allow to > decrease the inode size. > > As a part of increasi

[PATCH 3/3] e2fsprogs: Support for large inode migration.

2007-07-24 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V <[EMAIL PROTECTED]> Add new option -I to tune2fs. This is used to change the inode size. The size need to be multiple of 2 and we don't allow to decrease the inode size. As a part of increasing the inode size we throw away the free inodes in the last block group. If we can