Re: [RFC][PATCH] sys_fallocate() system call

2007-03-21 Thread Chris Wedgwood
I hate to comment at this late stage, especially on something that I think is really a great idea (I did similar more complex, sys_blkalloc with even more arguments time ago --- I'm glad given how complex this thread has become I didn't post them now). In the past there wasn't that much incentive

Re: [RFC][PATCH] sys_fallocate() system call

2007-03-21 Thread Amit K. Arora
On Sat, Mar 17, 2007 at 05:10:37AM -0600, Matthew Wilcox wrote: > How about: > > asmlinkage long sys_fallocate(int fd, int mode, u32 off_low, u32 off_high, > u32 len_low, u32 len_high); > > That way we all suffer equally ... As suggested by you and Russel, I have ma

Re: [RFC][PATCH] sys_fallocate() system call

2007-03-19 Thread Heiko Carstens
On Mon, Mar 19, 2007 at 02:54:04PM +0530, Amit K. Arora wrote: > On Fri, Mar 16, 2007 at 04:21:03PM +0100, Heiko Carstens wrote: > > On Fri, Mar 16, 2007 at 08:01:01PM +0530, Amit K. Arora wrote: > > > asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t > > > len) > > > > > > C

Re: [RFC][PATCH] sys_fallocate() system call

2007-03-19 Thread Amit K. Arora
On Sat, Mar 17, 2007 at 04:33:50PM +1100, Stephen Rothwell wrote: > On Fri, 16 Mar 2007 20:01:01 +0530 "Amit K. Arora" <[EMAIL PROTECTED]> wrote: > > > > > +asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len); > > > > --- linux-2.6.20.1.orig/include/asm-powerpc/systbl.h > >

Re: [RFC][PATCH] sys_fallocate() system call

2007-03-19 Thread Amit K. Arora
On Fri, Mar 16, 2007 at 04:21:03PM +0100, Heiko Carstens wrote: > On Fri, Mar 16, 2007 at 08:01:01PM +0530, Amit K. Arora wrote: > > First of all, thanks for the overwhelming response! > > > > Based on the suggestions received, I have added a new parameter to the > > sys_fallocate() system call -

Re: [RFC][PATCH] sys_fallocate() system call

2007-03-17 Thread Russell King
On Fri, Mar 16, 2007 at 08:01:01PM +0530, Amit K. Arora wrote: > Attached below is the patch which implements this system call. It has > been currently implemented and tested on i386, ppc64 and x86_64 > architectures. I am facing some problems while trying to implement this > on s390, and thus the

Re: [RFC][PATCH] sys_fallocate() system call

2007-03-17 Thread Stephen Rothwell
On Sun, 18 Mar 2007 01:38:38 +1100 Stephen Rothwell <[EMAIL PROTECTED]> wrote: > > On Sat, 17 Mar 2007 15:30:43 +0100 Heiko Carstens <[EMAIL PROTECTED]> wrote: > > > > sys_sync_file_range(int fd, loff_t offset, loff_t nbytes, unsigned int > > flags) > > > > But from what I read, it's currently not

Re: [RFC][PATCH] sys_fallocate() system call

2007-03-17 Thread Stephen Rothwell
On Sat, 17 Mar 2007 15:30:43 +0100 Heiko Carstens <[EMAIL PROTECTED]> wrote: > > sys_sync_file_range(int fd, loff_t offset, loff_t nbytes, unsigned int flags) > > But from what I read, it's currently not possible for 32-bit powerpc to > wire up the already present sync_file_range system call. 32bi

Re: [RFC][PATCH] sys_fallocate() system call

2007-03-17 Thread Heiko Carstens
On Sat, Mar 17, 2007 at 05:07:06AM -0600, Matthew Wilcox wrote: > On Sat, Mar 17, 2007 at 08:59:05PM +1100, Paul Mackerras wrote: > > ... but wouldn't work on 32-bit powerpc. :( We would end up with a > > pad argument between fd and offset, giving 7 arguments in all > > (counting the loff_t's as 2

Re: [RFC][PATCH] sys_fallocate() system call

2007-03-17 Thread Matthew Wilcox
On Fri, Mar 16, 2007 at 05:17:04PM +0100, Heiko Carstens wrote: > > +asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len) > > e.g. > > asmlinkage long sys_fallocate(int fd, loff_t offset, loff_t len, int mode) > > would work even on s390 ;) How about: asmlinkage long sys_

Re: [RFC][PATCH] sys_fallocate() system call

2007-03-17 Thread Matthew Wilcox
On Sat, Mar 17, 2007 at 08:59:05PM +1100, Paul Mackerras wrote: > ... but wouldn't work on 32-bit powerpc. :( We would end up with a > pad argument between fd and offset, giving 7 arguments in all > (counting the loff_t's as 2), but we only support 6. Ditto mips and parisc. - To unsubscribe from

Re: [RFC][PATCH] sys_fallocate() system call

2007-03-17 Thread Paul Mackerras
Heiko Carstens writes: > So you either rearrange the parameters or convert the loff_t's to pointers. > > e.g. > > asmlinkage long sys_fallocate(int fd, loff_t offset, loff_t len, int mode) > > would work even on s390 ;) ... but wouldn't work on 32-bit powerpc. :( We would end up with a pad ar

Re: [RFC][PATCH] sys_fallocate() system call

2007-03-16 Thread Stephen Rothwell
On Fri, 16 Mar 2007 20:01:01 +0530 "Amit K. Arora" <[EMAIL PROTECTED]> wrote: > > +asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len); > > --- linux-2.6.20.1.orig/include/asm-powerpc/systbl.h > +++ linux-2.6.20.1/include/asm-powerpc/systbl.h > @@ -305,3 +305,4 @@ SYSCALL_SP

Re: [RFC][PATCH] sys_fallocate() system call

2007-03-16 Thread Heiko Carstens
> on s390, and thus the delay. While I try to get it right on s390(x), we > thought of posting this patch, so that we can save some time. Parallely > we will work on getting the patch work on s390, and probably it will > come as a separate patch. > > +asmlinkage long sys_fallocate(int fd, int mode

Re: [RFC][PATCH] sys_fallocate() system call

2007-03-16 Thread Heiko Carstens
On Fri, Mar 16, 2007 at 08:01:01PM +0530, Amit K. Arora wrote: > First of all, thanks for the overwhelming response! > > Based on the suggestions received, I have added a new parameter to the > sys_fallocate() system call - an interger called "mode", just after the > "fd". Now the system call look

[RFC][PATCH] sys_fallocate() system call

2007-03-16 Thread Amit K. Arora
First of all, thanks for the overwhelming response! Based on the suggestions received, I have added a new parameter to the sys_fallocate() system call - an interger called "mode", just after the "fd". Now the system call looks like this: asmlinkage long sys_fallocate(int fd, int mode, loff_t off