Re: Initial results of FLEX_BG feature.

2007-07-16 Thread Andreas Dilger
On Jul 12, 2007 10:09 -0500, Jose R. Santos wrote: @@ -1271,6 +1271,9 @@ static int ext4_check_descriptors (struc ext4_debug (Checking group descriptors); + if (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_FLEX_BG)) + return 1; + for (i = 0; i

[patch 003/268] jbd2 commit: fix transaction dropping

2007-07-16 Thread akpm
From: Jan Kara [EMAIL PROTECTED] We have to check that also the second checkpoint list is non-empty before dropping the transaction. Signed-off-by: Jan Kara [EMAIL PROTECTED] Cc: Chuck Ebbert [EMAIL PROTECTED] Cc: Kirill Korotaev [EMAIL PROTECTED] Cc: linux-ext4@vger.kernel.org Cc: [EMAIL

[patch 002/268] jbd commit: fix transaction dropping

2007-07-16 Thread akpm
From: Jan Kara [EMAIL PROTECTED] We have to check that also the second checkpoint list is non-empty before dropping the transaction. Signed-off-by: Jan Kara [EMAIL PROTECTED] Cc: Chuck Ebbert [EMAIL PROTECTED] Cc: Kirill Korotaev [EMAIL PROTECTED] Cc: linux-ext4@vger.kernel.org Cc: [EMAIL

[patch 243/268] ext4: fix error handling in ext4_create_journal

2007-07-16 Thread akpm
From: Borislav Petkov [EMAIL PROTECTED] Fix error handling in ext4_create_journal according to kernel conventions. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] Cc: linux-ext4@vger.kernel.org Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- fs/ext4/super.c |7 +-- 1 file changed,

[patch 195/268] ext3: fix deadlock in ext3_remount() and orphan list handling

2007-07-16 Thread akpm
From: Jan Kara [EMAIL PROTECTED] ext3_orphan_add() and ext3_orphan_del() functions lock sb-s_lock with a transaction started with ext3_mark_recovery_complete() waits for a transaction holding sb-s_lock, thus leading to a possible deadlock. At the moment we call ext3_mark_recovery_complete() from

[patch 196/268] ext4: fix deadlock in ext4_remount() and orphan list handling

2007-07-16 Thread akpm
From: Jan Kara [EMAIL PROTECTED] ext4_orphan_add() and ext4_orphan_del() functions lock sb-s_lock with a transaction started with ext4_mark_recovery_complete() waits for a transaction holding sb-s_lock, thus leading to a possible deadlock. At the moment we call ext4_mark_recovery_complete() from

[PATCH 1/1] ext4: JBD-JBD2 naming cleanups

2007-07-16 Thread Mingming Cao
On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote: Index: linux-2.6.22-rc4/include/linux/jbd2.h === --- linux-2.6.22-rc4.orig/include/linux/jbd2.h 2007-06-11 16:16:18.0 -0700 +++

Re: [EXT4 set 2][PATCH 2/5] cleanups: Add extent sanity checks

2007-07-16 Thread Mingming Cao
On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote: On Sun, 01 Jul 2007 03:36:22 -0400 Mingming Cao [EMAIL PROTECTED] wrote: with the patch all headers are checked. the code should become more resistant to on-disk corruptions. needless BUG_ON() have been removed. please, review for

Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs

2007-07-16 Thread Mingming Cao
On Tue, 2007-07-10 at 19:31 -0700, Andrew Morton wrote: On Sun, 01 Jul 2007 03:38:10 -0400 Mingming Cao [EMAIL PROTECTED] wrote: [PATCH] jbd2 stats through procfs The patch below updates the jbd stats patch to 2.6.20/jbd2. The initial patch was posted by Alex Tomas in December 2005

Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs

2007-07-16 Thread Mingming Cao
On Tue, 2007-07-10 at 21:42 -0700, Andrew Morton wrote: On Tue, 10 Jul 2007 23:21:49 -0400 Cédric Augonnet [EMAIL PROTECTED] wrote: 2007/7/10, Andrew Morton [EMAIL PROTECTED]: Hi all, + size = sizeof(struct transaction_stats_s); + s-stats = kmalloc(size, GFP_KERNEL);

Coverity testing freely available

2007-07-16 Thread Andreas Dilger
Hi, I've recently found scan.coverity.com, which allows OSS-licensed projects to be run under Coverity to find defects available in the code. I think that e2fsprogs should be included there, even if some people run e2fsprogs under Coverity separately. This allows the e2fsprogs developers to find

Re: Initial results of FLEX_BG feature.

2007-07-16 Thread Jose R. Santos
On Mon, 16 Jul 2007 00:34:57 -0600 Andreas Dilger [EMAIL PROTECTED] wrote: On Jul 12, 2007 10:09 -0500, Jose R. Santos wrote: @@ -1271,6 +1271,9 @@ static int ext4_check_descriptors (struc ext4_debug (Checking group descriptors); + if (EXT4_HAS_INCOMPAT_FEATURE(sb,

[PATCH] Update series file

2007-07-16 Thread Aneesh Kumar K.V
I think the series file got updated wrongly -aneesh diff --git a/series b/series index 183d72e..bf34353 100644 --- a/series +++ b/series @@ -2,14 +2,10 @@ # fallocate() syscall patches and ext4 fallocate() implementation # Missing manpages -ext4-fallocate-1-syscall_i386_amd64_ppc

- ext4-fix-error-handling-in-ext4_create_journal.patch removed from -mm tree

2007-07-16 Thread akpm
The patch titled ext4: fix error handling in ext4_create_journal has been removed from the -mm tree. Its filename was ext4-fix-error-handling-in-ext4_create_journal.patch This patch was dropped because it was merged into mainline or a subsystem tree

- ext3-remove-extra-is_rdonly-check.patch removed from -mm tree

2007-07-16 Thread akpm
The patch titled ext3: remove extra IS_RDONLY() check has been removed from the -mm tree. Its filename was ext3-remove-extra-is_rdonly-check.patch This patch was dropped because it was merged into mainline or a subsystem tree --

- ext3-fix-deadlock-in-ext3_remount-and-orphan-list-handling.patch removed from -mm tree

2007-07-16 Thread akpm
The patch titled ext3: fix deadlock in ext3_remount() and orphan list handling has been removed from the -mm tree. Its filename was ext3-fix-deadlock-in-ext3_remount-and-orphan-list-handling.patch This patch was dropped because it was merged into mainline or a subsystem tree

Re: [EXT4 set 5][PATCH 1/1] expand inode i_extra_isize to support features in larger inode

2007-07-16 Thread Mingming Cao
On Fri, 2007-07-13 at 02:05 -0700, Andrew Morton wrote: On Tue, 10 Jul 2007 16:32:47 -0700 Andrew Morton [EMAIL PROTECTED] wrote: + brelse(bh); + up_write(EXT4_I(inode)-xattr_sem); + return error; +} + We're doing GFP_KERNEL memory allocations while holding xattr_sem. This

Re: [EXT4 set 5][PATCH 1/1] expand inode i_extra_isize to support features in larger inode

2007-07-16 Thread Mingming Cao
On Mon, 2007-07-16 at 18:06 -0600, Andreas Dilger wrote: On Jul 16, 2007 16:52 -0700, Mingming Cao wrote: I am not sure why we need GFP_KERNEL flag here. I think we should use GFP_NOFS instead. The following patch use the GFP_NOFS flag, as well as fixing memory leak issue introduced by the

Re: [EXT4 set 3][PATCH 1/1] ext4 nanosecond timestamp

2007-07-16 Thread Mingming Cao
On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote: On Sun, 01 Jul 2007 03:36:56 -0400 Mingming Cao [EMAIL PROTECTED] wrote: This patch is a spinoff of the old nanosecond patches. I don't know what the old nanosecond patches are. A link to a suitable changlog for those patches would