] lock_release_holdtime+0x27/0x49
[81056480] __lock_acquire+0x4e7/0xc4d
[81053c91] lock_release_holdtime+0x27/0x49
[810a8de7] sys_fallocate+0xe4/0x10d
[8100c043] tracesys+0xd5/0xda
Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED]
---
fs/ext4/extents.c | 26
On Sat, Jan 12, 2008 at 11:44:00PM +0530, Aneesh Kumar K.V wrote:
fs/ext4/extents.c | 26 ++
1 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 81bce98..4269cc6 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4
On Mon, Jan 14, 2008 at 12:49:27PM -0800, Mingming Cao wrote:
Hi Guys,
Could you check the checkpatch.pl warnings and see if it make sense to fix
them? Thanks!
[EMAIL PROTECTED]:~/fs/ext4/stylecheck$ grep has style problems *
linux-2.6.24-rc7-48-bit-i_blocks.patch.out:Your patch has
in ext4_mb_normalize_request
From: Aneesh Kumar K.V [EMAIL PROTECTED]
kernel BUG at fs/ext4/mballoc.c:3148!
The BUG_ON is:
BUG_ON(size = 0 || size = EXT4_BLOCKS_PER_GROUP(ac-ac_sb));
where the value of size is 4293920768.
This is due to the overflow of the variable start in the
ext4_mb_normalize_request() function
On Thu, Jan 17, 2008 at 10:43:40AM +0100, Valerie Clement wrote:
Aneesh Kumar K.V wrote:
What about this ? I guess we will overflow start = start bsbits;
Hi Aneesh,
your patch below doesn't fix the issue, because as start_off is also
loff_t, start_off = ac-ac_o_ex.fe_logical bsbits
On Thu, Jan 17, 2008 at 10:43:40AM +0100, Valerie Clement wrote:
Aneesh Kumar K.V wrote:
What about this ? I guess we will overflow start = start bsbits;
Hi Aneesh,
your patch below doesn't fix the issue, because as start_off is also
loff_t, start_off = ac-ac_o_ex.fe_logical bsbits
On Thu, Jan 17, 2008 at 02:09:41PM +0100, Valerie Clement wrote:
Aneesh Kumar K.V wrote:
On Thu, Jan 17, 2008 at 10:43:40AM +0100, Valerie Clement wrote:
Aneesh Kumar K.V wrote:
What about this ? I guess we will overflow start = start bsbits;
Hi Aneesh,
your patch below doesn't fix
70d4ca32604e0935a8b9a49c5ac8b9c64c810693
Author: Aneesh Kumar K.V [EMAIL PROTECTED]
Date: Thu Jan 24 10:50:24 2008 +0530
Add buffer head related helper functions
Add buffer head related helper function bh_uptodate_or_lock and
bh_submit_read which can be used by file system
Signed-off
-by: Aneesh Kumar K.V [EMAIL PROTECTED]
Signed-off-by: Eric Sandeen [EMAIL PROTECTED]
Signed-off-by: Theodore Ts'o [EMAIL PROTECTED]
...
+#if BITS_PER_LONG == 64
+#define mb_correct_addr_and_bit(bit, addr) \
+{ \
+ bit
updated patch. Waiting for the test results.
I am only attaching the diff. Mballoc patch is really large.
-aneesh
diff --git a/Documentation/filesystems/ext4.txt
b/Documentation/filesystems/ext4.txt
index 4f329af..ec7d349 100644
--- a/Documentation/filesystems/ext4.txt
+++
I have updated patches based on the review feedback from Andrew.
I have tested this on
128(64p) ppc64 sles
4(2p)ppc64 debian
4(2p)x86_64 ubuntu-gutsy
Updated patches are at
http://www.radian.org/~kvaneesh/ext4/jan-24-2008/
http://www.radian.org/~kvaneesh/ext4/jan-24-2008/patches.tar
On Thu, Jan 24, 2008 at 01:26:14PM +0530, Aneesh Kumar K.V wrote:
+/* find most significant bit */
+static int fmsb(unsigned short word)
+{
+ int order;
+
+ if (word 255) {
+ order = 7;
+ word = 8;
+ } else {
+ order = -1
Hi,
I looked at the GFP flag usage in mballoc. I think the below change
make sense with respect to mballoc.
First hunk is memory allocation during ext4_mb_init which is called
during mount time. I guess it is ok to convert that to GFP_KERNEL.
Second hunk is during ext4_mb_free_metadata. I
On Fri, Jan 25, 2008 at 11:15:00PM -0500, Theodore Tso wrote:
On Thu, Jan 24, 2008 at 11:25:32AM +0530, Aneesh Kumar K.V wrote:
+static int free_ext_idx(handle_t *handle, struct inode *inode,
+ struct ext4_extent_idx *ix)
+{
+ int i, retval = 0
On Sun, Feb 03, 2008 at 01:39:02PM +0100, Geert Uytterhoeven wrote:
On Sun, 3 Feb 2008, Heiko Carstens wrote:
On Fri, Feb 01, 2008 at 10:04:04PM +0100, Bastian Blank wrote:
On Fri, Feb 01, 2008 at 12:22:57PM -0800, Andrew Morton wrote:
On Fri, 1 Feb 2008 21:02:08 +0100
Bastian Blank
On Thu, Jan 31, 2008 at 04:42:07PM +0100, Eric Sesterhenn wrote:
* Eric Sesterhenn ([EMAIL PROTECTED]) wrote:
hi,
while running a modified version of fsfuzzer i triggered the BUG() in
ext4_mb_release_inode_pa(). Sadly I am not able to reproduce this using
the generated image, but
);
...
Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED]
---
fs/ext4/mballoc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 76e5fed..06d1f52 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -3069,7 +3069,7 @@ static int
On Mon, Feb 04, 2008 at 10:24:36AM +0100, Heiko Carstens wrote:
| fs/ext4/mballoc.c: In function 'ext4_mb_generate_buddy':
| fs/ext4/mballoc.c:954: error: implicit declaration of function
'generic_find_next_le_bit'
The s390 specific bitops uses parts of the generic
can add the below diff to the same. The change was
suggested by Girish. Before journal checksum changes sync_dirty_buffer
did the get_bh.
Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED]
diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c
index da8d0eb..2b88ab0 100644
--- a/fs/jbd2/commit.c
+++ b/fs
Hi,
This is with the new ext3 - ext4 migrate code added. The recently added
lockdep for jbd2 helped to find this out. We want to hold the i_data_sem
on the ext3 inode during migration to prevent walking the ext3 inode
when it is being converted to ext4 format. Also we want to avoid
file
On Mon, Feb 04, 2008 at 05:31:56PM +0100, Jan Kara wrote:
Hi,
On Mon 04-02-08 15:42:28, Aneesh Kumar K.V wrote:
This is with the new ext3 - ext4 migrate code added. The recently added
lockdep for jbd2 helped to find this out. We want to hold the i_data_sem
on the ext3 inode during
With journal checksum patch we added asyn commit of journal commit headers.
During the conversion we missed to take a reference on buffer head. Before
the change sync_dirty_buffer did the get_bh(). The associative put_bh is
done by journal_wait_on_commit_record()
Signed-off-by: Aneesh Kumar K.V
On Mon, Feb 04, 2008 at 10:23:16AM -0500, Josef Bacik wrote:
On Monday 04 February 2008 5:12:28 am Aneesh Kumar K.V wrote:
Hi,
This is with the new ext3 - ext4 migrate code added. The recently added
lockdep for jbd2 helped to find this out. We want to hold the i_data_sem
on the ext3
On Mon, Feb 04, 2008 at 05:31:56PM +0100, Jan Kara wrote:
Hi,
On Mon 04-02-08 15:42:28, Aneesh Kumar K.V wrote:
This is with the new ext3 - ext4 migrate code added. The recently added
lockdep for jbd2 helped to find this out. We want to hold the i_data_sem
on the ext3 inode during
On Tue, Feb 05, 2008 at 02:42:28PM +0100, Jan Kara wrote:
On Tue 05-02-08 17:53:42, Aneesh Kumar K.V wrote:
How about the patch below. I did the below testing
a) migrate a file
b) run fs_inode fsstres fsx_linux.
The intention was to find out whether the new locking is breaking any
On Tue, Feb 05, 2008 at 05:34:04PM +0100, Jan Kara wrote:
On Tue 05-02-08 21:57:03, Aneesh Kumar K.V wrote:
I have a FIXME at migrate.c:524 documenting exactly that. The
difficult question was by how much we should extent the journal. ? But
in reality we might have accumulated enough
[c01e200c] ext4_unlink+0x6e/0x1a4
[c017449e] vfs_unlink+0x49/0x89
[c0175f02] do_unlinkat+0x96/0x12c
[c0175fa8] sys_unlink+0x10/0x12
[c0104f8a] sysenter_past_esp+0x5f/0xa5
Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED]
---
fs/ext4/migrate.c | 117
other issues.
Eric ,
can you run the test with below patch and see if this makes any
difference ?. I know we are not fixing any bugs in the below patch.
ext4: Don't panic in case of corrupt bitmap
From: Aneesh Kumar K.V [EMAIL PROTECTED]
Multiblock allocator was calling BUG_ON in many case
On Sun, Feb 10, 2008 at 11:19:12PM -0500, Theodore Tso wrote:
On Sat, Feb 02, 2008 at 12:59:43AM -0700, Andreas Dilger wrote:
The following series of emails will contain the large part of the
e2fsprogs patch series that is used for Lustre. It will not contain
the regression tests for
On Mon, Feb 11, 2008 at 05:00:18PM +0530, Aneesh Kumar K.V wrote:
In ext4_mb_complex_scan_group, if the extent length of the newly
found extentet is greater than than the total free blocks counted
in group info, break without claiming the block.
Document different ext4_error usage
. Clear? yes
Inode 1120 is a zero-length directory. Clear? yes
Inode 1121 is a zero-length directory. Clear? yes
Fix the same by dropping the inode link count using drop_nlink
Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED]
---
fs/ext4/namei.c |2 +-
1 files changed, 1 insertions(+), 1
Steps:
[root]# more /root/largedir
i=65000
mkdir /mnt/tmp/test/
cd /mnt/tmp/test/
while [ $i -gt 0 ]
do
mkdir $i
i=$(expr $i - 1)
done
# /root/largedir
# cd /mnt/tmp/test
# rm -rf *
# cd ..
# ls -al
drwxr-xr-x 1 root root 1380352 Feb 12 07:15 test
# e2fsck -fv /dev/sda7
# ls
The path variable returned via ext4_ext_find_extent is a kmalloc variable
and need to be freeded. It also contain refrences to buffer_head which need
to be dropped.
Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED]
---
fs/ext4/extents.c |6 +++---
fs/ext4/migrate.c
In ext4_ext_convert_to_initialized before we need to request for journal
write access before we even modify the extent length.
Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED]
---
fs/ext4/extents.c | 11 ---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/fs/ext4
fallocate blocks are considered as sparse area and read from them should
return zero. ext4_ext_get_blocks should return zero for read request.
Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED]
---
fs/ext4/extents.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git
On Sat, Feb 16, 2008 at 08:53:34AM +0530, Aneesh Kumar K.V wrote:
On Fri, Feb 15, 2008 at 11:43:04AM -0800, Mingming Cao wrote:
On Fri, 2008-02-15 at 23:46 +0530, Aneesh Kumar K.V wrote:
fallocate blocks are considered as sparse area and read from them should
return zero
and
that would result in data loss.
Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED]
---
fs/ext4/file.c | 19 ++-
fs/ext4/inode.c |6 ++
include/linux/ext4_fs.h |1 +
3 files changed, 25 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/file.c b/fs
IF we fail fallocate don't call ext4_error. Also don't hide errors
from ext4_get_blocks_wrap
Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED]
---
fs/ext4/extents.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 5b22f71
On Mon, Feb 18, 2008 at 04:14:34PM -0800, Mingming Cao wrote:
On Sat, 2008-02-16 at 08:53 +0530, Aneesh Kumar K.V wrote:
How about the following patch?
Regards,
Mingming
ext4: ext4_get_blocks_wrap fix for writing to preallocated
From: Mingming Cao [EMAIL PROTECTED]
This patch fixed
and
that would result in data loss. The changes are also needed to handle ENOSPC
when writing to an mmap section of files with holes.
Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED]
---
fs/ext4/file.c | 19 ++-
fs/ext4/inode.c |6 ++
include/linux/ext4_fs.h
changes attached.
ext4: Convert list_for_each_rcu() to list_for_each_entry_rcu()
From: Aneesh Kumar K.V [EMAIL PROTECTED]
The list_for_each_entry_rcu() primitive should be used instead of
list_for_each_rcu(), as the former is easier to use and provides
better type safety.
http://groups.google.com
Hi all,
I am seeing the below error in the console. But the tests are reported
as success.
EXT4-fs: mballoc enabled
EXT4-fs error (device sda7): ext4_ext_find_extent: bad header in inode
#204044: invalid magic - magic 0, entries 0, max 0(0), depth 0(0)
EXT4-fs error (device sda7):
On Tue, Feb 19, 2008 at 10:19:44PM +0530, Aneesh Kumar K.V wrote:
On Tue, Feb 19, 2008 at 10:39:52AM -0600, Eric Sandeen wrote:
Eric Sandeen wrote:
e2fsck doesn't expect to find char, block, fifo, or socket
files with the extent flag set, so clear that in ext4_mknod.
Signed-off
On Tue, Feb 19, 2008 at 06:15:01PM +0100, Valerie Clement wrote:
Aneesh Kumar K.V wrote:
Hi all,
I am seeing the below error in the console. But the tests are reported
as success.
EXT4-fs: mballoc enabled
EXT4-fs error (device sda7): ext4_ext_find_extent: bad header in inode
#204044
On Tue, Feb 19, 2008 at 06:15:01PM +0100, Valerie Clement wrote:
Aneesh Kumar K.V wrote:
Hi all,
I am seeing the below error in the console. But the tests are reported
as success.
EXT4-fs: mballoc enabled
EXT4-fs error (device sda7): ext4_ext_find_extent: bad header in inode
#204044
On Tue, Feb 19, 2008 at 10:39:52AM -0600, Eric Sandeen wrote:
Eric Sandeen wrote:
e2fsck doesn't expect to find char, block, fifo, or socket
files with the extent flag set, so clear that in ext4_mknod.
Signed-off-by: Eric Sandeen [EMAIL PROTECTED]
---
Index:
error later when we are verifying the extent header
Also we don't want to set extent flag for symlinks, char, block, fifo
or socket
Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED]
---
fs/ext4/ialloc.c | 22 +++---
fs/ext4/namei.c |1 -
2 files changed, 15 insertions(+), 8
Mingming,
On Wed, Feb 20, 2008 at 01:19:05AM +0530, Aneesh Kumar K.V wrote:
Also don't inherit EXT4_EXTENTS_FL from parent directory.
If we have a directory with extent flag set and later mount the file
system with -o noextents, the files created in that directory will also
have extent flag
-by: Aneesh Kumar K.V [EMAIL PROTECTED]
CC:Eric Sandeen [EMAIL PROTECTED]
---
fs/ext4/mballoc.c | 62 ++--
1 files changed, 40 insertions(+), 22 deletions(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 89772b9..ccddd21 100644
--- a/fs/ext4
. But that is
another patch.
From 6a73edd4dbb32344e6a83ebdc07edd0e96d376bd Mon Sep 17 00:00:00 2001
From: Aneesh Kumar K.V [EMAIL PROTECTED]
Date: Thu, 21 Feb 2008 23:57:38 +0530
Subject: [PATCH] ext4: Convert uninitialized extent to initialized extent in
case of file system full
A write to prealloc
On Thu, Feb 21, 2008 at 09:39:20AM -0800, Mingming Cao wrote:
On Tue, 2008-02-19 at 09:13 +0530, Aneesh Kumar K.V wrote:
We would like to get notified when we are doing a write on mmap section.
This is needed with respect to preallocated area. We split the preallocated
area into initialzed
to the extent to prevent wrong data
reaching
userspace.
Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED]
---
fs/ext4/extents.c | 151 ++---
1 files changed, 144 insertions(+), 7 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
Put the old extent details back if we fail to split the
uninitialized extent.
Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED]
---
fs/ext4/extents.c | 26 --
1 files changed, 24 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index
Test results for the patch.
mmaptest simply maps a range and write to it.
The length of the extent indicate whether it is initialized or not.
There is no space in the file system for another block.
So the uninitialized extent have to be converted to initialized extent.
[EMAIL PROTECTED]:/ext4#
On Fri, Feb 22, 2008 at 08:01:28PM +0530, Aneesh Kumar K.V wrote:
+
+ /* Now write all the buffer_heads in the page */
+ do {
+ set_buffer_uptodate(bh);
+ if (ext4_should_journal_data(inode)) {
+ err
On Fri, Feb 22, 2008 at 10:10:48AM -0800, Mingming Cao wrote:
On Fri, 2008-02-22 at 20:09 +0530, Aneesh Kumar K.V wrote:
.
+ ext4_journal_stop(handle);
+ goto out_unlock;
+ }
+ if (!ret ext4_should_order_data(inode)) {
+ ret = walk_page_buffers
extent format for symlink.
From: Aneesh Kumar K.V [EMAIL PROTECTED]
This patch enable extent format for normal symlink. Extent format enables
to refere file system blocks 32 bits. Enabling extent format for symlink
enables to have symlink block beyond 2**32 blocks. We still don't enable
extent
201 - 257 of 257 matches
Mail list logo
