[RFC] e2fsprogs: Add ext4migrate

2007-03-19 Thread Aneesh Kumar K.V
This is work in progress The below patches add ext4migrate utility that helps in migrating a ext3 block mapped inode to ext4 extent mapped inode. I have split the patches into two. They don't build individually. The purpose of splitting the patches into two is to make the review easeir. The

[PATCH 1/2] e2fsprogs: Add ext4migrate

2007-03-19 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] Add ext4migrate utility that helps in migrating a ext3 block mapped inode to ext4 extent mapped inode. ext4migrate command takes the below syntax ext4migrate [--display | --migrate ] image_name filename The --display option helps in displaying the block

[PATCH 2/2] Add extent related functions

2007-03-19 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] The code is derived out of the latest ext4 kernel source. I have tried to keep the code as close as possible to the kernel sources. This makes sure that any fixes for the tree building code in kernel should be easily applied to ext4migrate. The ext3_ext

[PATCH 1/2] Add extent related functions

2007-04-03 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] The code is derived out of the latest ext4 kernel source. I have tried to keep the code as close as possible to the kernel sources. This makes sure that any fixes for the tree building code in kernel should be easily applied to ext4migrate. The ext3_ext

[PATCH 2/2] e2fsprogs: Add ext4migrate

2007-04-03 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] Add ext4migrate utility that helps in migrating a ext3 block mapped inode to ext4 extent mapped inode. ext4migrate command takes the below syntax ext4migrate [--display | --migrate ] image_name filename The --display option helps in displaying the block

Re: [RFC][take 2] e2fsprogs: Add ext4migrate

2007-04-04 Thread Aneesh Kumar K.V
Andreas Dilger wrote: On Apr 03, 2007 15:37 +0530, Aneesh Kumar K.V wrote: The extent insert code is derived out of the latest ext4 kernel source. I have tried to keep the code as close as possible to the kernel sources. This makes sure that any fixes for the tree building code in kernel

[RFC][take 3] e2fsprogs: Add ext4migrate

2007-04-10 Thread Aneesh Kumar K.V
This is work in progress Changes from from my previous patches are as follows: a) Mark the file system unclean if we fail migrating b) support for migrating more than one file c) Support for migrating all the ext3 inode in the file system d) Fix the free block counts. ( Make sure fsck pass

[PATCH 1/2] Add extent related functions

2007-04-10 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] The code is derived out of the latest ext4 kernel source. I have tried to keep the code as close as possible to the kernel sources. This makes sure that any fixes for the tree building code in kernel should be easily applied to ext4migrate. The ext3_ext

[PATCH 2/2] e2fsprogs: Add ext4migrate

2007-04-10 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] Add ext4migrate utility that helps in migrating a ext3 block mapped inode to ext4 extent mapped inode. ext4migrate command takes the below syntax ext4migrate --display | --migrate image_name [filename] The --display option helps in displaying the block

[RFC][take 4] e2fsprogs: Add ext4migrate

2007-05-04 Thread Aneesh Kumar K.V
This is work in progress Changes from from my previous patches are as follows: a) COW unix io manager using libtdb b) add ext4replay to undo the file system changes done during migration Changes from from my previous patches are as follows: a) Mark the file system unclean if we fail migrating

[PATCH 2/4] Add extent related functions

2007-05-04 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] The code is derived out of the latest ext4 kernel source. I have tried to keep the code as close as possible to the kernel sources. This makes sure that any fixes for the tree building code in kernel should be easily applied to ext4migrate. The ext3_ext

[PATCH 1/4] Add unix COW io manager

2007-05-04 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- lib/ext2fs/Makefile.in |6 + lib/ext2fs/ext2_io.h |3 + lib/ext2fs/unix_cow_io.c | 864 ++ 3 files changed, 873 insertions(+), 0 deletions

[PATCH 4/4] Add ext4replay tool.

2007-05-04 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] This tool can be used to replay the transactions stored in the database during ext4migrate. Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- ext4migrate/Makefile.in |7 ++- ext4migrate/replay.c| 45

Re: [RFC][take 4] e2fsprogs: Add ext4migrate

2007-05-06 Thread Aneesh Kumar K.V
Andreas Dilger wrote: On May 04, 2007 14:43 +0530, Aneesh Kumar K.V wrote: Changes from from my previous patches are as follows: a) support for files with holes b) use the block iterator present in libext2fs c) don't mark the indirect blocks as unused early. If we mark the the blocks

Re: [RFC][take 4] e2fsprogs: Add ext4migrate

2007-05-07 Thread Aneesh Kumar K.V
Hi, Theodore Tso wrote: On Mon, May 07, 2007 at 08:56:11AM +0530, Aneesh Kumar K.V wrote: Andreas Dilger wrote: If this code could also (or optionally just) increase the size of inodes it would be very useful. AFAIK right now it will only change the inodes from block-mapped to extent-mapped

Re: [RFC][take 4] e2fsprogs: Add ext4migrate

2007-05-07 Thread Aneesh Kumar K.V
Theodore Tso wrote: That is correct. My next step is to enhance the tool to support migration to large inodes. I would actually suggest that the place to add that functionality would be via tune2fs -I inode_size. Since mke2fs -I inode_size is used to set the inode size, it makes sense

e2fsprogs: Undo I/O manager

2007-05-09 Thread Aneesh Kumar K.V
This is a very early prototype of what i working on. I have done only minimal testing of this. To use one need to use the below steps. io_manager io_mng = stack_io_manager_init(); stack_push_io_manager(io_mng, unix_io_manager); stack_push_io_manager(io_mng, undo_io_manager);

[PATCH 1/2] Add stack I/O manager.

2007-05-09 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] This I/O manager helps in stacking different I/O managers. For example one can stack the undo I/O manager on top of Unix I/O manager to achieve the undo functionality. Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- lib/ext2fs/Makefile.in | 10

[PATCH 2/2] Add undo I/O manager.

2007-05-09 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] This I/O manager saves the contents of the location being overwritten to a tdb database. This helps in undoing the changes done to the file system. This can be stacked over unix I/O manager to get the undo functionality. Signed-off-by: Aneesh Kumar K.V

[PATCH 1/2] Add stack I/O manager.

2007-05-09 Thread Aneesh Kumar K.V
This I/O manager helps in stacking different I/O managers. For example one can stack the undo I/O manager on top of Unix I/O manager to achieve the undo functionality. Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- lib/ext2fs/Makefile.in | 10 +- lib/ext2fs/ext2_io.h |4 + lib

Re: Ext4 Patch Queue using stgit.

2007-05-18 Thread Aneesh Kumar K.V
Dave Kleikamp wrote: On Fri, 2007-05-18 at 18:12 +0530, Aneesh Kumar K.V wrote: Hi All, I was looking at ext4 patch queue and was wondering why we are putting .patch under git. If we are looking for a quilt like functionality, one can achieve the same using stgit. I was using stgit

Re: Ext4 Patch Queue using stgit.

2007-05-18 Thread Aneesh Kumar K.V
Theodore Tso wrote: On Fri, May 18, 2007 at 06:12:23PM +0530, Aneesh Kumar K.V wrote: Hi All, I was looking at ext4 patch queue and was wondering why we are putting .patch under git. If we are looking for a quilt like functionality, one can achieve the same using stgit. I was using stgit

Re: [PATCH 1/2] Add stack I/O manager.

2007-05-21 Thread Aneesh Kumar K.V
Theodore Tso wrote: On Wed, May 09, 2007 at 01:42:17PM +0530, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V [EMAIL PROTECTED] This I/O manager helps in stacking different I/O managers. For example one can stack the undo I/O manager on top of Unix I/O manager to achieve the undo

Re: Online defragmentation and ext4migrate

2007-05-21 Thread Aneesh Kumar K.V
Takashi Sato wrote: Hi Aneesh san, In my opinion, to keep the ioctl simple and small is very important for ease of maintenance. So I would rather not support indirect block files in the ioctl. Instead, I can add the call of the migration ioctl to my defrag tool in order to defragment

Re: which tree should I generate the ext4 patch ?

2007-05-24 Thread Aneesh Kumar K.V
coly wrote: Theodore, I can see all the files, but how can I download the files by cvs ? I tried pserver, but it seems does not work .. could you give me some hints ? hg clone http://thunk.org/hg/e2fsprogs/ hg come in mercurial package. -aneesh - To unsubscribe from this list: send

[PATCH] update ext4-nanosecond-patch comments

2007-05-28 Thread Aneesh Kumar K.V
Also can we have a description of why s_{min, want}_extra_isize fields are added in the commit message ? diff --git a/ext4-nanosecond-patch b/ext4-nanosecond-patch index ceaf339..02d00b7 100644 --- a/ext4-nanosecond-patch +++ b/ext4-nanosecond-patch @@ -1,8 +1,8 @@ This patch is a spinoff of

Re: [PATCH] update ext4-nanosecond-patch comments

2007-05-29 Thread Aneesh Kumar K.V
Kalpak Shah wrote: On Tue, 2007-05-29 at 11:18 +0530, Aneesh Kumar K.V wrote: Also can we have a description of why s_{min, want}_extra_isize fields are added in the commit message ? The i_extra_isize for each inode should ideally be s_want_extra_isize after inode expansion. If expansion

Re: [PATCH] update ext4-nanosecond-patch comments

2007-05-29 Thread Aneesh Kumar K.V
Andreas Dilger wrote: On May 29, 2007 13:48 +0530, Aneesh Kumar K.V wrote: When the nanosecond timestamp extension was first proposed, the requirement from Ted and Stephen were that s_min_extra_isize was a requirement. Otherwise it would be possible to have a filesystem where

Online defragmentation

2007-05-30 Thread Aneesh Kumar K.V
Hi Takashi, I was looking at online defrag code and found that the tmp_inode is created with tmp_inode-i_nlink equal to zero. Now i am not sure whether i understand the code correctly, but AFAIU we allocate contiguous block using this tmp_inode. That means tmp_inode have extent details

Re: [RFC PATCH 1/1] e2fsprogs: Add undo I/O manager.

2007-06-06 Thread Aneesh Kumar K.V
Theodore Tso wrote: On Tue, May 22, 2007 at 03:47:33PM +0530, Aneesh Kumar K.V wrote: This I/O manager saves the contents of the location being overwritten to a tdb database. This helps in undoing the changes done to the file system. + /* loop through the existing entries and find

Re: [RFC PATCH 1/1] e2fsprogs: Add undo I/O manager.

2007-06-07 Thread Aneesh Kumar K.V
Theodore Tso wrote: On Wed, Jun 06, 2007 at 03:32:27PM +0530, Aneesh Kumar K.V wrote: If we allow to change the block size in between that would mean the records that we store in the tdb database will be of variable size ( different block sizes). That would also add all the code/complexity

[PATCH 1/1] e2fsprogs: Add undo I/O manager.

2007-06-08 Thread Aneesh Kumar K.V
, flags, superblock, block_size, undo_io_manager, current_fs); The patch is on top of e2fsprogs-upstream mercurial repo Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] diff -r 11b6e3e021f0 lib/ext2fs/Makefile.in --- a/lib/ext2fs/Makefile.inThu May 31 12:39

Add EXT4_IOC_MIGRATE ioctl

2007-06-12 Thread Aneesh Kumar K.V
Corporation, 2007 + * Author Aneesh Kumar K.V [EMAIL PROTECTED] + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of version 2.1 of the GNU Lesser General Public License + * as published by the Free Software Foundation. + * + * This program

Re: Add EXT4_IOC_MIGRATE ioctl

2007-06-12 Thread Aneesh Kumar K.V
Andreas Dilger wrote: On Jun 12, 2007 12:17 +0530, Aneesh Kumar K.V wrote: The below patch add ioctl for migrating ext3 indirect block mapped inode to ext4 extent mapped inode. How does this relate to the migrate ioctl used by Takashi in the current ext4 defragmenter patch series? You

ext4-block-reservation.patch

2007-06-19 Thread Aneesh Kumar K.V
Hi, In block reservation code while rebalancing the free blocks why are we not looking at the reservation slots that have no free blocks left. Rebalancing the free blocks equally across all the reservation slots will make sure we have less chances of failure later when we try to reserve

Re: delayed allocatiou result in Oops

2007-06-19 Thread Aneesh Kumar K.V
Mingming Cao wrote: O BTW, can you point me your latest and greatest mballoc patch? I am trying to forward port and merge that patch to ext4 patch queue I am looking at the one found at. ftp://ftp.clusterfs.com/pub/people/alex/2.6.19-rc6 -aneesh - To unsubscribe from this list:

Re: ext4-block-reservation.patch

2007-06-19 Thread Aneesh Kumar K.V
Eric Sandeen wrote: Aneesh Kumar K.V wrote: Hi, In block reservation code while rebalancing the free blocks why are we not looking at the reservation slots that have no free blocks left. Rebalancing the free blocks equally across all the reservation slots will make sure we have less

Re: ext4-block-reservation.patch

2007-06-19 Thread Aneesh Kumar K.V
Aneesh Kumar K.V wrote: Eric Sandeen wrote: Aneesh Kumar K.V wrote: Hi, In block reservation code while rebalancing the free blocks why are we not looking at the reservation slots that have no free blocks left. Rebalancing the free blocks equally across all the reservation slots

Re: [RFC][PATCH 1/11][take 2] add new mkfs option to create ext4 filesystems

2007-06-25 Thread Aneesh Kumar K.V
Valerie Clement wrote: This patch adds a new option '-D' to mkfs to allow creating ext4 filesystem. lib/ext2fs/ext2_fs.h|7 +++ lib/ext2fs/initialize.c |1 + misc/mke2fs.c | 18 -- 3 files changed, 24 insertions(+), 2 deletions(-)

[PATCH] e2fsprogs: Add undo I/O manager [ Was Re: E2fsprogs 1.40 release imminent! ]

2007-06-25 Thread Aneesh Kumar K.V
, superblock, block_size, undo_io_manager, current_fs); The patch is on top of e2fsprogs-upstream mercurial repo Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] diff -r fe55db3e508c lib/ext2fs/Makefile.in --- a/lib/ext2fs/Makefile.inSun Jun 24 17:32:47 2007

[PATCH 2/2] Add EXT4_IOC_MIGRATE ioctl

2007-06-28 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] The below patch add ioctl for migrating ext3 indirect block mapped inode to ext4 extent mapped inode. Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- fs/ext4/Makefile|2 +- fs/ext4/ioctl.c |3 + fs/ext4/migrate.c

Re: [EXT4 set 4][PATCH 4/5] i_version:ext4 inode version update

2007-07-03 Thread Aneesh Kumar K.V
Mingming Cao wrote: Index: linux-2.6.22-rc4/fs/ext4/super.c === --- linux-2.6.22-rc4.orig/fs/ext4/super.c 2007-06-13 17:19:11.0 -0700 +++ linux-2.6.22-rc4/fs/ext4/super.c2007-06-13 17:24:45.0 -0700 @@

finding the author of the patches in ext4-patch-queue

2007-07-03 Thread Aneesh Kumar K.V
off extents. Signed-off-by: Mingming Cao [EMAIL PROTECTED] Without the change: I get below commit 4a4f228f99e263767fe5b395cdb843a5c5d083fe Author: Aneesh Kumar K.V [EMAIL PROTECTED] Date: Wed Jul 4 10:05:19 2007 +0530 Turn on extents feature by default in ext4 filesystem. User could

Re: [EXT4 set 4][PATCH 4/5] i_version:ext4 inode version update

2007-07-03 Thread Aneesh Kumar K.V
Aneesh Kumar K.V wrote: If we bump i_version in ext4_mark_iloc_dity then we should be removing the i_version update at other places. A simple grep of ext4 dir shows i_version being updated followed by ext4_mark_inode_dirty. How about the below patch. I also removed the i_version = 1

Re: [EXT4 set 4][PATCH 4/5] i_version:ext4 inode version update

2007-07-03 Thread Aneesh Kumar K.V
Aneesh Kumar K.V wrote: If we bump i_version in ext4_mark_iloc_dity then we should be removing the i_version update at other places. A simple grep of ext4 dir shows i_version being updated followed by ext4_mark_inode_dirty. How about the below patch. I also removed the i_version = 1

Re: [EXT4 set 3][PATCH 1/1] ext4 nanosecond timestamp

2007-07-04 Thread Aneesh Kumar K.V
Aneesh Kumar K.V wrote: Mingming Cao wrote: On Tue, 2007-07-03 at 15:58 +0530, Kalpak Shah wrote: On Sun, 2007-07-01 at 03:36 -0400, Mingming Cao wrote: + +#define EXT4_INODE_GET_XTIME(xtime, inode, raw_inode) \ +do

[PATCH]mballoc rebased on top of ext4-patch-queue.

2007-07-05 Thread Aneesh Kumar K.V
The patch set is forward port of the changes found at ftp://ftp.clusterfs.com/pub/people/alex/2.6.19-rc6/ on top of 2.6.22-rc6 (ext4-patch-queue) Only visible change i made is to enabled MBALLOC option default so that we get wider testing. Test booted and did minimal testing on ext4 files

[PATCH 2/4] Add support for locality group.

2007-07-05 Thread Aneesh Kumar K.V
From: Alex Tomas [EMAIL PROTECTED] Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- fs/ext4/Makefile |2 +- fs/ext4/lg.c | 576 fs/ext4/super.c|5 + fs/fs-writeback.c |8 +- include/linux

Re: simple block bitmap sanity checking

2007-07-09 Thread Aneesh Kumar K.V
Andreas Dilger wrote: During a discussion at OLS, I came up with a very simple way of validating the ext2/3/4 block bitmaps at read time. Until such a time when we have checksums for the bitmaps we can have a simple but quite robust mechanism that is useful for ext2/3/4. When a new block

[PATCH] ext2/ext3/ext4: Add block bitmap validation

2007-07-09 Thread Aneesh Kumar K.V
When a new block bitmap is read from disk in read_block_bitmap() there are a few bits that should ALWAYS be set. In particular, the blocks given by ext4_blk_bitmap, ext4_inode_bitmap and ext4_inode_table. Validate the block bitmap against these blocks. Signed-off-by: Aneesh Kumar K.V [EMAIL

[PATCH] ext2/ext3/ext4: Add block bitmap validation

2007-07-09 Thread Aneesh Kumar K.V
When a new block bitmap is read from disk in read_block_bitmap() there are a few bits that should ALWAYS be set. In particular, the blocks given by ext4_blk_bitmap, ext4_inode_bitmap and ext4_inode_table. Validate the block bitmap against these blocks. Signed-off-by: Aneesh Kumar K.V [EMAIL

e2fsprogs: Undo I/O manager

2007-07-11 Thread Aneesh Kumar K.V
Hi Ted, Following patch implement the Undo I/O manager and undoe2fs. The patches are on top of latest git(23edf9b4674ced1cdf8625bd609d95dbd62923b3) -aneesh - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo

[PATCH 2/2] e2fsprogs: Add undoe2fs

2007-07-11 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] undoe2fs can be used to replay the transaction saved in the transaction file using undo I/O Manager Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- misc/Makefile.in | 10 -- misc/undoe2fs.c | 48

Re: Ext3 onlie resize failure due to small journal size

2007-07-11 Thread Aneesh Kumar K.V
Andreas Dilger wrote: On Jul 11, 2007 19:30 +0530, Suzuki wrote: Trying to resize a mounted ext3 filesystem fails due to small journal size. Background : The filesystem was created with default values, except blocksize = 4K on a LV partition. Later we tried extended the partition to +16M

[PATCH] Update series file

2007-07-16 Thread Aneesh Kumar K.V
I think the series file got updated wrongly -aneesh diff --git a/series b/series index 183d72e..bf34353 100644 --- a/series +++ b/series @@ -2,14 +2,10 @@ # fallocate() syscall patches and ext4 fallocate() implementation # Missing manpages -ext4-fallocate-1-syscall_i386_amd64_ppc

[Take 2]e2fsprogs: Undo I/O manager

2007-07-19 Thread Aneesh Kumar K.V
This patch fixes some bugs found during testing of the large inode migration patches. -aneesh - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] e2fsprogs: Add undoe2fs

2007-07-19 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] undoe2fs can be used to replay the transaction saved in the transaction file using undo I/O Manager Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- misc/Makefile.in | 10 +- misc/undoe2fs.c | 77

Re: New e2fsprog doc on the ext4 wiki page.

2007-07-24 Thread Aneesh Kumar K.V
Jose R. Santos wrote: On Tue, 24 Jul 2007 21:48:58 +0530 Aneesh Kumar K.V [EMAIL PROTECTED] wrote: Jose R. Santos wrote: Hi folks ext4migrate: - Patches submited to the mailing list by Aneesh Kumar http://thread.gmane.org/gmane.comp.file-systems.ext4/1395 I guess what we are looking

e2fsprogs: Undo I/O Manager and large inode migration support in tune2fs

2007-07-24 Thread Aneesh Kumar K.V
Hi Ted, The series is on top of f1f115a78f5ea599fc5f8815a741d43fedd5840d Changes from last post include a) Add O_EXCL flag to tdb_open. b) Fix the return value when we fail to create the tdb file c) Add tune2fs -I new_inode_size for migrating to large inode size. - To unsubscribe from this

[PATCH 2/3] e2fsprogs: Add undoe2fs

2007-07-24 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] undoe2fs can be used to replay the transaction saved in the transaction file using undo I/O Manager Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- misc/Makefile.in | 10 +- misc/undoe2fs.c | 77

Re: [PATCH 3/3] e2fsprogs: Support for large inode migration.

2007-07-26 Thread Aneesh Kumar K.V
Theodore Tso wrote: On Thu, Jul 26, 2007 at 05:15:30PM +0530, Aneesh Kumar K.V wrote: Let me guess, you're testing with a filesystem with two block groups, right? And to date you've tested *only* by doubling the size of the inode. I tested this with multiple ( 1 and 7 ) groups. But yes all

Re: [PATCH 3/3] e2fsprogs: Support for large inode migration.

2007-07-27 Thread Aneesh Kumar K.V
Theodore Tso wrote: On Fri, Jul 27, 2007 at 08:29:31AM +0530, Aneesh Kumar K.V wrote: What are the issues you see with PATCH 1 and PATCH 2 which implement Undo I/O Manager and undoe2fs other than it is not hooked into any of the existing tools. I will try to add it to mke2fs as you suggested

[PATCH 2/4] e2fsprogs: Add undoe2fs

2007-07-31 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] undoe2fs can be used to replay the transaction saved in the transaction file using undo I/O Manager Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- misc/Makefile.in | 10 +- misc/undoe2fs.c | 77

[PATCH 3/4] e2fsprogs: Make mke2fs use undo I/O manager.

2007-07-31 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] When running mke2fs, if a file system is detected on the device, we use Undo I/O manager as the io manager. This helps in reverting the changes made to the filesystem in case we wrongly selected the device. The environment variable MKE2FS_SCRATCH_DIR

[PATCH 1/4] e2fsprogs: Add undo I/O manager

2007-07-31 Thread Aneesh Kumar K.V
, flags, superblock, block_size, undo_io_manager, current_fs); Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- lib/ext2fs/Makefile.in |7 +- lib/ext2fs/ext2_io.h |5 + lib/ext2fs/undo_io.c | 500 3

Re: [PATCH 2/4] e2fsprogs: Add undoe2fs

2007-08-01 Thread Aneesh Kumar K.V
Andreas Dilger wrote: On Aug 01, 2007 07:34 +0530, Aneesh Kumar K.V wrote: undoe2fs can be used to replay the transaction saved in the transaction file using undo I/O Manager This should save the mtime of the superblock, and only do the undo step if the filesystem hasn't changed

Re: [PATCH 3/4] e2fsprogs: Make mke2fs use undo I/O manager.

2007-08-01 Thread Aneesh Kumar K.V
Andreas Dilger wrote: On Aug 01, 2007 07:34 +0530, Aneesh Kumar K.V wrote: When running mke2fs, if a file system is detected on the device, we use Undo I/O manager as the io manager. This helps in reverting the changes made to the filesystem in case we wrongly selected the device

Re: [PATCH 2/4] e2fsprogs: Add undoe2fs

2007-08-01 Thread Aneesh Kumar K.V
Andreas Dilger wrote: On Aug 01, 2007 11:46 +0530, Aneesh Kumar K.V wrote: Andreas Dilger wrote: On Aug 01, 2007 07:34 +0530, Aneesh Kumar K.V wrote: undoe2fs can be used to replay the transaction saved in the transaction file using undo I/O Manager This should save the mtime

e2fsprogs patches

2007-08-01 Thread Aneesh Kumar K.V
I have updated the patches to take care of comments posted by Andreas. I also reworked the undoe2fs to use io_channel rather than open coding open/write. Regarding the naming of tdb file i decided to go with mke2fs-device_name instead of mke2fs-device_name-time-stamp. I guess having multiple

[PATCH 2/4] e2fsprogs: Add undoe2fs

2007-08-01 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] undoe2fs can be used to replay the transaction saved in the transaction file using undo I/O Manager Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- misc/Makefile.in | 10 ++- misc/undoe2fs.c | 217

[PATCH 4/4] e2fsprogs: Support for large inode migration.

2007-08-01 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] Add new option -I inode_size to tune2fs. This is used to change the inode size. The size need to be multiple of 2 and we don't allow to decrease the inode size. As a part of increasing the inode size we increase the inode table size. We also move the used

[PATCH 1/4] e2fsprogs: Add undo I/O manager

2007-08-01 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] This I/O manager saves the contents of the location being overwritten to a tdb database. This helps in undoing the changes done to the file system. The call sequence involve set_undo_io_backing_manager(unix_io_manager); set_undo_io_backup_file(/tmp

[PATCH 3/4] e2fsprogs: Make mke2fs use undo I/O manager.

2007-08-01 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V [EMAIL PROTECTED] When running mke2fs, if a file system is detected on the device, we use Undo I/O manager as the io manager. This helps in reverting the changes made to the filesystem in case we wrongly selected the device. The environment variable MKE2FS_SCRATCH_DIR

Re: [PATCH 1/4] e2fsprogs: Add undo I/O manager

2007-08-02 Thread Aneesh Kumar K.V
Andreas Dilger wrote: On Aug 01, 2007 21:04 +0530, Aneesh Kumar K.V wrote: +static errcode_t write_file_system_identity(io_channel undo_channel, + TDB_CONTEXT *tdb) +{ + /* Write to tdb file in the file system byte order

Re: [PATCH] ext3: fix ext34_fill_super group description initialization

2007-08-13 Thread Aneesh Kumar K.V
Dmitry Monakhov wrote: -s_group_desc have to be zero filled because if sb_read() failed we jump to following error path. failed_mount2: for (i = 0; i db_count; i++) brelse(sbi-s_group_desc[i]); Bad things may happen here But the db_count is updated in the failure

[RFC] mballoc patches

2007-08-13 Thread Aneesh Kumar K.V
Alex actually pointed me the new mballoc patches at ftp://ftp.clusterfs.com/pub/people/alex/mballoc3 The series is the forward port of the same on top of d4ac2477fad0f2680e84ec12e387ce67682c5c13 (v2.6.23-rc2) I guess the mballoc3 patch at clusterfs.com is based on a patched ext3(I guess it is

[PATCH 3/4] This is the equivalent of ext3-mballoc3-sles10.patch

2007-08-13 Thread Aneesh Kumar K.V
--- fs/ext4/Makefile |2 +- fs/ext4/balloc.c | 58 ++--- fs/ext4/extents.c | 44 +++--- fs/ext4/inode.c | 14 +- fs/ext4/super.c | 18 ++

[PATCH 1/4] Add some new function for searching extent tree.

2007-08-13 Thread Aneesh Kumar K.V
From: Alex Tomas [EMAIL PROTECTED] ext4_ext_search_left ext4_ext_search_right --- fs/ext4/extents.c | 142 +++ include/linux/ext4_fs_extents.h |2 + 2 files changed, 144 insertions(+), 0 deletions(-) diff --git a/fs/ext4/extents.c

[PATCH 1/6] e2fsprogs: Add undo I/O manager

2007-08-13 Thread Aneesh Kumar K.V
, flags, superblock, block_size, undo_io_manager, current_fs); Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- lib/ext2fs/Makefile.in |7 +- lib/ext2fs/ext2_io.h |5 + lib/ext2fs/undo_io.c | 574 3

[PATCH 4/6] e2fsprogs: Support for large inode migration.

2007-08-13 Thread Aneesh Kumar K.V
will be named tune2fs-device-name If TUNE2FS_SCRATCH_DIR is not set /var/lib/e2fsprogs is used Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- misc/tune2fs.c | 535 +++- 1 files changed, 532 insertions(+), 3 deletions(-) diff --git

[PATCH 6/6] e2fsprogs: Add test case for undoe2fs

2007-08-13 Thread Aneesh Kumar K.V
This adds two test case for undoe2fs. Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- tests/test_config |1 + tests/u_undoe2fs_mke2fs/script | 31 +++ tests/u_undoe2fs_tune2fs/script | 31 +++ 3 files changed

e2fsprogs patches

2007-08-13 Thread Aneesh Kumar K.V
The series is on top of f1f115a78f5ea599fc5f8815a741d43fedd5840d - To unsubscribe from this list: send the line unsubscribe linux-ext4 in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/6] e2fsprogs: Add undoe2fs

2007-08-13 Thread Aneesh Kumar K.V
undoe2fs can be used to replay the transaction saved in the transaction file using undo I/O Manager Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- misc/Makefile.in | 10 ++- misc/undoe2fs.c | 220 ++ 2 files changed, 228 insertions

[PATCH 5/6] e2fsprogs: Fix the resize inode test case

2007-08-13 Thread Aneesh Kumar K.V
With the new mke2fs changes the output of the command differs if we run mke2fs on a device that already have the file system. So erase the file system before running mke2fs so that output remain as expected. Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- tests/r_resize_inode/script |2

[PATCH 3/6] e2fsprogs: Make mke2fs use undo I/O manager.

2007-08-13 Thread Aneesh Kumar K.V
which the tdb file need to be created. The file will be named mke2fs-device-name If MKE2FS_SCRATCH_DIR is not set /var/lib/e2fsprogs is used Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- misc/mke2fs.c | 109 - 1 files changed, 108

Re: [RFC] mballoc patches

2007-08-13 Thread Aneesh Kumar K.V
Aneesh Kumar K.V wrote: Alex actually pointed me the new mballoc patches at ftp://ftp.clusterfs.com/pub/people/alex/mballoc3 The series is the forward port of the same on top of d4ac2477fad0f2680e84ec12e387ce67682c5c13 (v2.6.23-rc2) I guess the mballoc3 patch at clusterfs.com is based

Patches for patch queue

2007-08-16 Thread Aneesh Kumar K.V
Hi, Can we get the below patches in patch queue. http://www.radian.org/~kvaneesh/ext4/patch-series/ext-truncate-mutex.patch http://www.radian.org/~kvaneesh/ext4/patch-series/ext3-4-migrate.patch http://www.radian.org/~kvaneesh/ext4/patch-series/new-extent-function.patch

mballoc review

2007-09-10 Thread Aneesh Kumar K.V
Hi Alex, Attaching below is some of the questions and comments i had while looking at mballoc code. Can you take a look at this. I will try to push a new patch which contain a) comments from the below review b) uninitialzed group changes assuming the uninitialized group patches will go

Re: Bad performance results with the latest git patches

2007-09-10 Thread Aneesh Kumar K.V
Andreas Dilger wrote: On Sep 07, 2007 14:24 +0200, Valerie Clement wrote: running ffsb tests (large files creation) on my system with the latest ext4 git patches against a 2.6.23-rc4 kernel, I've got very bad performance results: the I/O throughput measured on an ext4 filesystem is ten

Re: new mballoc patches.

2007-09-11 Thread Aneesh Kumar K.V
Aneesh Kumar K.V wrote: I have updated the mballoc patches. The same can be found at http://www.radian.org/~kvaneesh/ext4/patch-series/ Test status: Minor testing with KVM. I also didn't do a PPC build. running fsstress on ppc64 give me EXT4-fs: group 9: 16384 blocks in bitmap

Re: new mballoc patches.

2007-09-12 Thread Aneesh Kumar K.V
Valerie, Valerie Clement wrote: Aneesh Kumar K.V wrote: running fsstress on ppc64 give me EXT4-fs: group 9: 16384 blocks in bitmap, 32254 in gd EXT4-fs error (device sda7): ext4_mb_mark_diskspace_used: Allocating block in system zone - block = 294915 EXT4-fs error (device sda7

Re: [PATCH] Ext4: Uninitialized Block Groups

2007-09-19 Thread Aneesh Kumar K.V
Valerie Clement wrote: Hi Avantika, I ran some tests with the uninit_groups feature enabled and got error messages when running e2fsck on my ext4 partition. e2fsck complains of an invalid unused inodes count in some group descriptors. These errors occur when checking groups which have only

[PATCH] Introduce ext4_find_next_bit

2007-09-20 Thread Aneesh Kumar K.V
Also add generic_find_next_le_bit This gets used by the ext4 multi block allocator patches. Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- include/asm-generic/bitops/ext2-non-atomic.h |2 + include/asm-generic/bitops/le.h |4 ++ include/asm-powerpc/bitops.h

[PATCH] ext4: Fix spare warnings

2007-09-20 Thread Aneesh Kumar K.V
Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- fs/ext4/inode.c |6 -- include/linux/ext4_fs.h | 16 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index a4848e0..307e240 100644 --- a/fs/ext4/inode.c

Re: + ext4-uninitialized-block-groups-fix.patch added to -mm tree

2007-09-20 Thread Aneesh Kumar K.V
[EMAIL PROTECTED] Cc: Aneesh Kumar K.V [EMAIL PROTECTED] Cc: linux-ext4@vger.kernel.org Signed-off-by: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- fs/Kconfig |1 fs/ext4/ialloc.c |8 ++- fs/ext4/super.c | 51

Re: [PATCH] ext4: Fix spare warnings

2007-09-21 Thread Aneesh Kumar K.V
Balbir Singh wrote: Aneesh, The subject is a bit confusing, I presume you mean sparse warnings yes. I will send an updated patch. The group descriptor bg_flags - le16 conversion should actually go with the uninitialized block group patch. -aneesh. - To unsubscribe from this list: send

Re: [PATCH] Introduce ext4_find_next_bit

2007-09-21 Thread Aneesh Kumar K.V
Balbir Singh wrote: Aneesh Kumar K.V wrote: Also add generic_find_next_le_bit This gets used by the ext4 multi block allocator patches. Looks like it's a straight forward on Little Endian Architectures. I see something for powerpc, what about other architectures? All include/asm-arch

Patch format in ext4 patch queue.

2007-09-21 Thread Aneesh Kumar K.V
Hi all, I was looking at the patch queue and see patches with different formats. If we can standardize on what rest of the linux kernel follows it would be nice. First line should be subsystem_name: A single line description of the patch. This appear in the subject line of the mail that

[PATCH 3/7] ext4: Convert s_blocks_count_hi and s_blocks_count to le32_t

2007-09-25 Thread Aneesh Kumar K.V
Convert s_blocks_count_hi and s_blocks_count to le32_t This helps in finding BUGs due to direct partial access of these split 64 bit values Also fix direct partial access in ext4 code Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- fs/ext4/mballoc.c |4 ++-- fs/ext4/super.c

[PATCH 7/7] ext4: sparse fixes

2007-09-25 Thread Aneesh Kumar K.V
Signed-off-by: Aneesh Kumar K.V [EMAIL PROTECTED] --- fs/ext4/fsync.c |2 +- fs/ext4/xattr.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c index 2a167d7..8d50879 100644 --- a/fs/ext4/fsync.c +++ b/fs/ext4/fsync.c @@ -47,7 +47,7

  1   2   3   >