Re: [f2fs-dev] [PATCH 4/5] f2fs: optimize restore_node_summary slightly

2014-03-09 Thread Chao Yu
Hi, > -Original Message- > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > Sent: Monday, March 10, 2014 1:38 PM > To: Chao Yu > Cc: 'Gu Zheng'; 'linux-kernel'; 'f2fs' > Subject: RE: [f2fs-dev] [PATCH 4/5] f2fs: optimize restore_node_summary > slightly > > Hi, > > 2014-03-10 (월), 13

Re: [f2fs-dev] [PATCH 4/5] f2fs: optimize restore_node_summary slightly

2014-03-09 Thread Gu Zheng
Hi Kim, On 03/10/2014 12:45 PM, Jaegeuk Kim wrote: > Hi Gu, > > 2014-03-07 (금), 18:43 +0800, Gu Zheng: >> Previously, we ra_sum_pages to pre-read contiguous pages as more >> as possible, and if we fail to alloc more pages, an ENOMEM error >> will be reported upstream, even though we have alloced

Re: [f2fs-dev] [PATCH 5/5] f2fs: add a wait queue to avoid unnecessary, build_free_nid

2014-03-09 Thread Gu Zheng
Hi Kim, On 03/10/2014 12:50 PM, Jaegeuk Kim wrote: > Hi Gu, > > 2014-03-07 (금), 18:43 +0800, Gu Zheng: >> Previously, when we try to alloc free nid while the build free nid >> is going, the allocer will be run into the flow that waiting for >> "nm_i->build_lock", see following: >> /* We shou

Re: [f2fs-dev] [PATCH 4/5] f2fs: optimize restore_node_summary slightly

2014-03-09 Thread Jaegeuk Kim
Hi, 2014-03-10 (월), 13:13 +0800, Chao Yu: > Hi Gu, Kim: > > One more comment. > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > > Sent: Monday, March 10, 2014 12:46 PM > > To: Gu Zheng > > Cc: linux-kernel; f2fs > > Subject: Re: [f2fs-dev] [PATCH 4/5] f2fs

Re: [f2fs-dev] [PATCH 5/5] f2fs: add a wait queue to avoid unnecessary, build_free_nid

2014-03-09 Thread Gu Zheng
Hi Changman, On 03/10/2014 12:09 PM, Changman Lee wrote: > On 금, 2014-03-07 at 18:43 +0800, Gu Zheng wrote: >> Previously, when we try to alloc free nid while the build free nid >> is going, the allocer will be run into the flow that waiting for >> "nm_i->build_lock", see following: >> /* We

Re: [f2fs-dev] [PATCH 4/5] f2fs: optimize restore_node_summary slightly

2014-03-09 Thread Chao Yu
Hi Gu, Kim: One more comment. > -Original Message- > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > Sent: Monday, March 10, 2014 12:46 PM > To: Gu Zheng > Cc: linux-kernel; f2fs > Subject: Re: [f2fs-dev] [PATCH 4/5] f2fs: optimize restore_node_summary > slightly > > Hi Gu, > > 20

Re: [f2fs-dev] [PATCH 5/5] f2fs: add a wait queue to avoid unnecessary, build_free_nid

2014-03-09 Thread Jaegeuk Kim
Hi Gu, 2014-03-07 (금), 18:43 +0800, Gu Zheng: > Previously, when we try to alloc free nid while the build free nid > is going, the allocer will be run into the flow that waiting for > "nm_i->build_lock", see following: > /* We should not use stale free nids created by build_free_nids */ > --

Re: [f2fs-dev] [PATCH 4/5] f2fs: optimize restore_node_summary slightly

2014-03-09 Thread Jaegeuk Kim
Hi Gu, 2014-03-07 (금), 18:43 +0800, Gu Zheng: > Previously, we ra_sum_pages to pre-read contiguous pages as more > as possible, and if we fail to alloc more pages, an ENOMEM error > will be reported upstream, even though we have alloced some pages > yet. In fact, we can use the available pages to

Re: [f2fs-dev] [PATCH 5/5] f2fs: add a wait queue to avoid unnecessary, build_free_nid

2014-03-09 Thread Changman Lee
On 금, 2014-03-07 at 18:43 +0800, Gu Zheng wrote: > Previously, when we try to alloc free nid while the build free nid > is going, the allocer will be run into the flow that waiting for > "nm_i->build_lock", see following: > /* We should not use stale free nids created by build_free_nids */ >

Re: [f2fs-dev] [PATCH 1/5] f2fs: update start nid only once each circle

2014-03-09 Thread Jaegeuk Kim
Hi all, I'll handle them all by myself. Thank you for the contribution. :) 2014-03-10 (월), 09:32 +0800, Gu Zheng: > On 03/08/2014 07:46 PM, Chao Yu wrote: > > > Hi Gu, > > > >> -Original Message- > >> From: Gu Zheng [mailto:guz.f...@cn.fujitsu.com] > >> Sent: Friday, March 07, 2014 6:43

Re: [f2fs-dev] [PATCH 1/5] f2fs: update start nid only once each circle

2014-03-09 Thread Gu Zheng
On 03/08/2014 07:46 PM, Chao Yu wrote: > Hi Gu, > >> -Original Message- >> From: Gu Zheng [mailto:guz.f...@cn.fujitsu.com] >> Sent: Friday, March 07, 2014 6:43 PM >> To: Kim >> Cc: linux-kernel; f2fs >> Subject: [f2fs-dev] [PATCH 1/5] f2fs: update start nid only once each circle >> >> >>