Re: [f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-22 Thread Wanpeng Li
Hi Jaegeuk, On Fri, Mar 20, 2015 at 01:13:39PM -0700, Jaegeuk Kim wrote: Hi Wanpeng, The Chao's patch is what I intended. Could anyone of you enhance that patch? If we use inline_data by default, we need another option to disable it. Like noinline_data? Will do, thanks for you and Chao's help.

[f2fs-dev] [PATCH 1/4] f2fs: limit b_size of mapped bh in f2fs_map_bh

2015-03-22 Thread Chao Yu
Map bh over max size which caller defined is not needed, limit it in f2fs_map_bh. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/data.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index f0a18a0..a99bc7f 100644 ---

[f2fs-dev] [PATCH 3/4] f2fs: avoid NULL pointer dereference in f2fs_xattr_advise_get

2015-03-22 Thread Chao Yu
We will encounter oops by executing below command. getfattr -n system.advise /mnt/f2fs/file Killed message log: BUG: unable to handle kernel NULL pointer dereference at (null) IP: [f8b54d69] f2fs_xattr_advise_get+0x29/0x40 [f2fs] *pdpt = 319b7001 *pde = Oops: 0002 [#1]

[f2fs-dev] [PATCH v2 2/2] f2fs: enable fast symlink by utilizing inline data

2015-03-22 Thread Wanpeng Li
Fast symlink can utilize inline data flow to avoid using any i_addr region, since we need to handle many cases such as truncation, roll-forward recovery, and fsck/dump tools. Signed-off-by: Wanpeng Li wanpeng...@linux.intel.com --- fs/f2fs/inline.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [f2fs-dev] [PATCH 1/1] f2fs: correctly check empty xattr key

2015-03-22 Thread Taesoo Kim
Hi Jaegeuk, Thank you for letting us know. We have another question: @f2fs_sync_file() if (unlikely(f2fs_readonly(inode-i_sb))) return 0; Isn't it better to report '-EROFS' as ext3/4? I suspect that f2fs returns 0 as fsync() man page doesn't specify such error condition. We are