Re: [f2fs-dev] [PATCH 3/5] f2fs: report readonly status in ->fsync

Hi Chao, Thanks Marc for your report. On Mon, Dec 28, 2015 at 05:59:19PM +0800, Chao Yu wrote: > > -Original Message- > > From: Marc Lehmann [mailto:schm...@schmorp.de] > > Sent: Saturday, December 26, 2015 2:33 PM > > To: Chao Yu > > Cc: linux-f2fs-devel@lists.sourceforge.net > >

Re: [f2fs-dev] [PATCH] f2fs: add a segment and section num check in sanity_check_raw_super

Hi Yunlei, Could you send a v2 for this? Thanks, On Tue, Dec 29, 2015 at 08:58:24AM +0800, He YunLei wrote: > On 2015/12/29 7:10, Jaegeuk Kim wrote: > >Hi Yunlei, > > > >On Sat, Dec 26, 2015 at 10:55:45AM +0800, He YunLei wrote: > >>On 2015/12/26 10:46, Yunlei He wrote: > >>>This patch add a

Re: [f2fs-dev] [PATCH 1/3] f2fs: early check broken symlink length in the encrypted case

Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Tuesday, December 29, 2015 7:32 AM > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 1/3] f2fs:

[f2fs-dev] [PATCH v2] f2fs: add a segment and section num check in sanity_check_raw_super

This patch add a mismatch check between segment and section in sanity_check_raw_super. Signed-off-by: Yunlei He --- fs/f2fs/super.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index c3070c1..e88af5a 100644 ---

[f2fs-dev] [RFC PATCH 2/2] f2fs: export a threshold in sysfs for controlling dio serialization

As Yunlei He reported when he test with the patch ("f2fs: enhance multithread dio write performance"): "Does share writepages mutex lock have an effect on cache write? Here is AndroBench result on my phone: Before patch: 1R1W8R8W16R16W Sequential

[f2fs-dev] [RFC PATCH 1/2] f2fs: enhance multithread dio write performance

When performing big dio writes concurrently, our performace will be low because of Thread A's allocation of multi continuous blocks will be interrupted by Thread B, there are two cases as below: - In Thread B, we may change current segment to a new segment for LFS allocation if we dio write in

Re: [f2fs-dev] [PATCH] f2fs: add a max block count for f2fs_map_blocks

On 2015/12/26 21:21, Chao Yu wrote: > Hi, > > On 12/25/15 6:17 PM, liuxue wrote: >> On 2015/12/25 17:25, Chao Yu wrote: >>> Hi, >>> -Original Message- From: Yunlei He [mailto:heyun...@huawei.com] Sent: Friday, December 25, 2015 4:48 PM To:

[f2fs-dev] [PATCH v2] f2fs: add a max block check for get_data_block_bmap

This patch adds a max block check for get_data_block_bmap. Trinity test program will send a block number as parameter into ioctl_fibmap, which will be used in get_node_path(), when the block number large than f2fs max blocks, it will trigger kernel bug. Signed-off-by: Yunlei He

Re: [f2fs-dev] [RFC PATCH 2/2] f2fs: export a threshold in sysfs for controlling dio serialization

Hi Chao, On Mon, Dec 28, 2015 at 06:05:45PM +0800, Chao Yu wrote: > As Yunlei He reported when he test with the patch ("f2fs: enhance > multithread dio write performance"): > "Does share writepages mutex lock have an effect on cache write? > Here is AndroBench result on my phone: > > Before

[f2fs-dev] [PATCH 1/2] f2fs: split drop_inmem_pages from commit_inmem_pages

Split drop_inmem_pages from commit_inmem_pages for code readability, and prepare for the following modification. Signed-off-by: Chao Yu --- fs/f2fs/f2fs.h| 3 +- fs/f2fs/file.c| 6 ++-- fs/f2fs/inode.c | 2 +- fs/f2fs/segment.c | 101

[f2fs-dev] [PATCH 2/2] f2fs: support revoking atomic written pages

f2fs support atomic write with following semantics: 1. open db file 2. ioctl start atomic write 3. (write db file) * n 4. ioctl commit atomic write 5. close db file With this flow we can avoid file becoming corrupted when abnormal power cut, because we hold data of transaction in referenced pages

Re: [f2fs-dev] [PATCH] f2fs: add a segment and section num check in sanity_check_raw_super

On 2015/12/29 7:10, Jaegeuk Kim wrote: > Hi Yunlei, > > On Sat, Dec 26, 2015 at 10:55:45AM +0800, He YunLei wrote: >> On 2015/12/26 10:46, Yunlei He wrote: >>> This patch add a mismatch check between segment and section in >>> sanity_check_raw_super. >>> >>> Signed-off-by: Yunlei He

[f2fs-dev] [PATCH 2/3] f2fs: use i_size_read to get i_size

We need to use i_size_read() to get inode->i_size. Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index f34f42a..8a89810 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c

[f2fs-dev] [PATCH 3/3] f2fs: load largest extent all the time

Otherwise, we can get mismatched largest extent information. One example is: 1. mount f2fs w/ extent_cache 2. make a small extent 3. umount 4. mount f2fs w/o extent_cache 5. update the largest extent 6. umount 7. mount f2fs w/ extent_cache 8. get the old extent made by #2 Signed-off-by: Jaegeuk

Re: [f2fs-dev] [PATCH 3/5] f2fs: report readonly status in ->fsync

Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Tuesday, December 29, 2015 6:44 AM > To: Chao Yu > Cc: 'Marc Lehmann'; linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH 3/5] f2fs: report readonly status in ->fsync > > Hi

Re: [f2fs-dev] [RFC PATCH 2/2] f2fs: export a threshold in sysfs for controlling dio serialization

Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Tuesday, December 29, 2015 6:52 AM > To: Chao Yu > Cc: linux-f2fs-devel@lists.sourceforge.net; linux-ker...@vger.kernel.org > Subject: Re: [RFC PATCH 2/2] f2fs: export a threshold in sysfs for >

[f2fs-dev] [PATCH v2] f2fs: serialize block allocation of dio writes to enhance multithread performance

When performing big dio writes concurrently, our performace will be low because of Thread A's allocation of multi continuous blocks will be interrupted by Thread B, there are two cases as below: - In Thread B, we may change current segment to a new segment for LFS allocation if we dio write in